Re: [2/2] comdlg32/tests: Test file name selection on init

2012-06-17 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19196 Your paranoid android

Re: [PATCH 5/5] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdManufacturerDescriptor) test

2012-06-17 Thread GOUJON Alexandre
On 06/17/2012 01:19 PM, Nikolay Sivov wrote: On 6/17/2012 13:11, Alexandre Goujon wrote: case DvdManufacturerDescriptor: +nt_desc.manf->Header.Length = 0x0802; +nt_desc.manf->Header.Reserved[0] = 0; +nt_desc.manf->Header.Reserved[1] = 0; Does this

Re: [PATCH 2/5] include/ddk: Add DVD_DESCRIPTOR_HEADER descriptor structure (try 2)

2012-06-17 Thread GOUJON Alexandre
On 06/17/2012 01:16 PM, Nikolay Sivov wrote: This looks wrong, correct name for it __midl, and this also needs a check for __WIDL__ probably. This is exactly what's present in the header file but if you want, I can resubmit with #if !(defined __midl || defined __WIDL__)

Re: [PATCH 5/5] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdManufacturerDescriptor) test

2012-06-17 Thread Nikolay Sivov
On 6/17/2012 13:11, Alexandre Goujon wrote: case DvdManufacturerDescriptor: +nt_desc.manf->Header.Length = 0x0802; +nt_desc.manf->Header.Reserved[0] = 0; +nt_desc.manf->Header.Reserved[1] = 0; Does this length mean something? Looks a bit dirty to l

Re: [PATCH 2/5] include/ddk: Add DVD_DESCRIPTOR_HEADER descriptor structure (try 2)

2012-06-17 Thread Nikolay Sivov
On 6/17/2012 13:11, Alexandre Goujon wrote: Superseeds the patch of the same name (#87003) Definition and assert taken from Windows Driver Kit (WDK) 8 Consumer Preview --- include/ddk/ntddcdvd.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/include/ddk/ntdd