Re: ru.po: improved an Russian translation

2012-06-14 Thread Oleg Yarigin
Hi, Julian! 1. Patches should be sent to wine-patc...@winehq.org, not wine-devel. Thank you a lot, I didn't know these address! I don't think that's a good idea... Afaik, the general guideline is to not change formatting and punctuation (from the English original), unless there's a rule in the

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).

2012-06-14 Thread Erich E. Hoover
On Thu, Jun 14, 2012 at 11:47 AM, Erich E. Hoover wrote: > ... > I can't think of any other way they'd be doing it...  It honestly blew > me away to see that screenshot, I wouldn't have thought to implement > it that way in a million years. The bug submitter was using xchm, so for completeness I

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).

2012-06-14 Thread Erich E. Hoover
On Thu, Jun 14, 2012 at 11:44 AM, Alexandre Julliard wrote: > ... > Wow, is Windows really doing it this way?  That's a good contestant for > the Most Stupid Win32 API Behavior award. I can't think of any other way they'd be doing it... It honestly blew me away to see that screenshot, I wouldn't

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).

2012-06-14 Thread Erich E. Hoover
On Thu, Jun 14, 2012 at 11:22 AM, Alexandre Julliard wrote: > ... > > I don't see why you'd want to use ANSI code pages for this, since they > will be converted to Unicode anyway. It's important to use the ANSI code page because of the way the characters are handled internally (you can see this i

MSVCP60.dll

2012-06-14 Thread John Emmas
Firstly, I'm not a Linux user. I'm a Windows programmer but I have a passing knowledge of Linux (and several friends who are Linux programmers). I write a Windows application which gets launched as a child process by a popular Linux DAW. My program was first written many years ago when the (t

Re: [05/11] windowscodecs: Add support for more types of IFD fields. Resend.

2012-06-14 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > + case IFD_BYTE: > > + case IFD_SBYTE: > > +if (count == 1) > > +{ > > +item->value.u.bVal = *(BYTE *)&value; > > +break; > > +} > > +FIXME("loading multiple byte fields is not implemented\n"); > > +

RFC: comdlg32: Fix null lpstrFile uses in FILEDLG95_OnOpen

2012-06-14 Thread Bruno Jesus
Hi, I have written a patch to fix bug 17229 and would like to request help to complete the test part. The test creates a common dialog and select a filename (file does not need to exist), it was copied from other tests in the same file (comdlg32/tests/filedlg.c). It's not possible to have a defaul

Re: [PATCH] sfnt2fnt: Fix broken .fon files on !x86 architectures

2012-06-14 Thread Hilko Bengen
* Alexandre Julliard: > endian.h is not portable, you should use the endianness defines from > the Wine headers instead. So, do I need to define my own htobe16 and htobe32 functions or macros based on whether WORDS_BIGENDIAN is defined or not? -Hilko

Re: [PATCH (try2)] winepulse.drv: Add PulseAudio driver

2012-06-14 Thread Rosanne DiMesio
On Thu, 14 Jun 2012 13:00:33 -0500 Andrew Eikum wrote: > On Wed, Jun 13, 2012 at 09:02:33PM +0200, Alexandre Julliard wrote: > > > > It doesn't work here, it's apparently using the driver even though > > PulseAudio is not running on this box: > > > > I've tried this on two operating systems, o

Re: [PATCH (try2)] winepulse.drv: Add PulseAudio driver

2012-06-14 Thread Alexandre Julliard
Andrew Eikum writes: > Also, I should change this to load libpulse at runtime instead of > compile time, right? It works fine as-is, except it prints a > load_builtin_dll err. I'll do that for the next version of the patch. Failing to load when libpulse is missing is fine, there's no need to loa

Re: [PATCH (try2)] winepulse.drv: Add PulseAudio driver

2012-06-14 Thread Andrew Eikum
On Wed, Jun 13, 2012 at 09:02:33PM +0200, Alexandre Julliard wrote: > Andrew Eikum writes: > > > The configure.ac changes and parts of the driver itself were written by > > Maarten Lankhorst. > > It doesn't work here, it's apparently using the driver even though > PulseAudio is not running on th

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).

2012-06-14 Thread Alexandre Julliard
"Erich E. Hoover" writes: > On Thu, Jun 14, 2012 at 11:22 AM, Alexandre Julliard > wrote: >> ... >> >> I don't see why you'd want to use ANSI code pages for this, since they >> will be converted to Unicode anyway. > > It's important to use the ANSI code page because of the way the > characters a

Re: [05/11] windowscodecs: Add support for more types of IFD fields. Resend.

2012-06-14 Thread Alexandre Julliard
Dmitry Timoshkov writes: > @@ -650,30 +672,43 @@ static HRESULT load_IFD_entry(IStream *input, const > struct IFD_entry *entry, > SWAP_ULONG(count); > type = entry->type; > SWAP_USHORT(type); > +item->value.vt = tag_to_vt(type); > value = entry->value; > SWAP_ULONG(v

Re: [PATCH] sfnt2fnt: Fix broken .fon files on !x86 architectures

2012-06-14 Thread Alexandre Julliard
Hilko Bengen writes: > @@ -46,6 +46,8 @@ > > #include "pshpack1.h" > > +#include endian.h is not portable, you should use the endianness defines from the Wine headers instead. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).

2012-06-14 Thread Alexandre Julliard
"Erich E. Hoover" writes: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying internat

Re: msvcrt/tests: Fix portuguese locale test on NT4

2012-06-14 Thread Piotr Caban
On 06/14/12 11:41, Marvin wrote: === WINEBUILD (build) === Patch failed to apply Looks like wine source was not updated on testbot yesterday.

Re: msvcrt/tests: Fix portuguese locale test on NT4

2012-06-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19045 Your paranoid android

Re: msvcrt: Fix the name of the Portuguese locale alias.

2012-06-14 Thread Michael Stefaniuc
Bruno, On 06/14/2012 11:25 AM, Piotr Caban wrote: > On 06/13/12 23:51, Bruno Jesus wrote: >> Just a side note. Although I'm not sure I think portuguese is "ptg", >> brazilian portuguese is "ptb". So the correct may be: >> >>> +"portuguese", "ptg", >> >> A Portugal user would be able to check t

Re: msvcrt: Fix the name of the Portuguese locale alias.

2012-06-14 Thread Piotr Caban
On 06/13/12 23:51, Bruno Jesus wrote: Just a side note. Although I'm not sure I think portuguese is "ptg", brazilian portuguese is "ptb". So the correct may be: +"portuguese", "ptg", A Portugal user would be able to check that, or maybe it's easier to write a testcase. There already is a

Re: DllMain() seems unused in ntoskrnl.exe

2012-06-14 Thread Marcus Meissner
On Wed, Jun 13, 2012 at 07:46:47PM +0200, Francois Gouget wrote: > > The DllMain() function in ntoskrnl.exe appears to be unused: making > it static causes a compiler warning to that effect and removing it > entirely does not cause a compilation failure. Should it be removed or > is there a bui