On Wed, Jun 13, 2012 at 8:52 AM, Stefan Dösinger wrote:
> Hi,
>
> The patch needs a few improvements before it can be accepted into Wine. I
> can't comment on the dinput / xinput specifics of the patch, so this is a non-
> exhaustive list of general suggestions.
>
> Concerning the big picture, thi
Please ignore this patch, it doesn't really belong to this series, and
correct implementation should use MetadataReaderInfo interface instead.
--
Dmitry.
On Wed, Jun 13, 2012 at 2:47 PM, Francois Gouget wrote:
> ...
> dlls/msvcrt/locale.c | 2 +-
> dlls/msvcrt/tests/locale.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> ...
> - "portugese", "ptb",
> + "portuguese", "ptb",
Just a side note. Although I'm not sure I
I'll return to this patch -- merge, apply requested changes, test again
-- a week from now. I'm unfortunately occupied elsewhere in the mean
time. Thank you for your patience and quick & useful replies.
- Ulrik
Andrew Eikum writes:
> The configure.ac changes and parts of the driver itself were written by
> Maarten Lankhorst.
It doesn't work here, it's apparently using the driver even though
PulseAudio is not running on this box:
../../../tools/runtest -q -P wine -M amstream.dll -T ../../.. -p
amstrea
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=19009
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=19010
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=19007
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=19006
Your paranoid android
The DllMain() function in ntoskrnl.exe appears to be unused: making
it static causes a compiler warning to that effect and removing it
entirely does not cause a compilation failure. Should it be removed or
is there a build issue with ntoskrnl.exe?
diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/d
Hi,
The patch needs a few improvements before it can be accepted into Wine. I
can't comment on the dinput / xinput specifics of the patch, so this is a non-
exhaustive list of general suggestions.
Concerning the big picture, this patch needs a few discussions about
xinput.dll design. There have
On 6/13/2012 17:42, Ulrik Dickow wrote:
Here's a new version of the patch that follows all of your 3 requests:
Den 12-06-2012 13:11, Nikolay Sivov skrev:
[...]
Please use something like CLSID array with every available Document
CLSID, instead of only testing 2 of them. There's a lot of examples
Here's a new version of the patch that follows all of your 3 requests:
Den 12-06-2012 13:11, Nikolay Sivov skrev:
> [...]
> Please use something like CLSID array with every available Document
> CLSID, instead of only testing 2 of them. There's a lot of examples for
> that in saxreader.c.
> [...]
>
2012/6/13 Nozomi Kodama :
>>>2012/6/12 Nozomi Kodama :
>>>
>>> + if ( (pq->w >= 1.0f) || (pq->w == -1.0f) )
>>
>>I think the second comparison should be '<=', if you want to avoid getting
>> NaNs.
>
> I checked in Vista. D3DX accepts -1.0f as input and returns what the patch
> does.
>
> However
On 13 June 2012 13:27, Michael Stefaniuc wrote:
> Uh... Any reason that field cannot be just
> struct wined3d_adapter adapter;
> ?
>
Not really, but if we actually supported multihead we'd have multiple
adapters and would need to change it back again.
On 06/13/2012 12:56 PM, Henri Verbeet wrote:
> On 13 June 2012 10:41, Michael Stefaniuc wrote:
>> -object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object));
>> +object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
>> FIELD_OFFSET(struct wined3d, adapters[1]));
>
> That's
On 13 June 2012 10:41, Michael Stefaniuc wrote:
> - object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object));
> + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
> FIELD_OFFSET(struct wined3d, adapters[1]));
That's not really a VLA, just a somewhat stupid array of siz
On 06/13/12 05:19, Francois Gouget wrote:
Is there a reason why Portuguese is misspelt in these two places?
It's a typo. Thanks for spotting it.
Hi Erich,
On 06/12/12 19:03, Erich E. Hoover wrote:
> Real Name:
> Erich Hoover
>
> Description:
> This patch adds the ability in HTML Help to convert HTML encoded
> characters (e.g. ê) into the Unicode character equivalent. This
> feature is needed by the table of contents and the index
19 matches
Mail list logo
