Re: [4/4] windowscodecs: Add stub IWICMetadataBlockReader to PNG decoder.

2012-05-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18675 Your paranoid android

Re: [3/4] windowscodecs: Add test for IWICMetadataBlockReader interface.

2012-05-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18674 Your paranoid android

Re: [2/2]kernel32/test: added test for OutputDebugStringA called with NULL pointer

2012-05-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18671 Your paranoid android

crypt32/tests(1/6): Don't shadow a variable with a variable of a different type

2012-05-30 Thread Juan Lang
--Juan From 728b013f2ca52de878dc65633a9c6cbcb1a9002c Mon Sep 17 00:00:00 2001 From: Juan Lang Date: Thu, 17 May 2012 15:55:16 -0700 Subject: [PATCH 2/7] Don't shadow a variable with a variable of a different type --- dlls/crypt32/tests/cert.c | 36 ++-- 1 files

Re: [PATCH 1/5] win16/int21: make found filename uppercase.

2012-05-30 Thread David Laight
On Wed, May 30, 2012 at 01:32:28PM +0200, Alexandre Julliard wrote: > Oleksij Rempel writes: > > > @@ -3961,6 +3962,8 @@ static int INT21_FindNext( CONTEXT *context ) > > INT21_FindPath = dta->fullPath = NULL; > > } > > dta->count = n; > > +p = dta->filename

Re: [1/5] windowscodecs: Implement IWICStream::InitializeFromIStream. (try 2)

2012-05-30 Thread Vincent Povirk
BTW, the patch looks good to me. On Tue, May 29, 2012 at 8:07 AM, Vincent Povirk wrote: >>> +    offset.QuadPart = 0; >>> +    size.u.LowPart = 0x; >>> +    size.u.HighPart = 0x; >>> +    return IWICStream_InitializeFromIStreamRegion(iface, pIStream, offset, >>> size); >> >> What

Re: [1/2] mscoree: Install Wine Mono on prefix update.

2012-05-30 Thread Alexandre Julliard
Vincent Povirk writes: >> This is breaking 64-bit prefixes, because things are not done in the >> correct order. > > Can you explain what exactly is breaking? Most of my testing has been > in 64-bit prefixes, and I haven't noticed any new problems (other than > lack of gluezilla). Many things do

Re: [1/2] mscoree: Install Wine Mono on prefix update.

2012-05-30 Thread Vincent Povirk
> This is breaking 64-bit prefixes, because things are not done in the > correct order. Can you explain what exactly is breaking? Most of my testing has been in 64-bit prefixes, and I haven't noticed any new problems (other than lack of gluezilla).

Re: [PATCH 4/4] jscript: Added VT_I2 tests

2012-05-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18657 Your paranoid android

Re: [PATCH 1/5] win16/int21: make found filename uppercase.

2012-05-30 Thread Oleksij Rempel
Am 30.05.2012 13:32, schrieb Alexandre Julliard: > Oleksij Rempel writes: > >> @@ -3961,6 +3962,8 @@ static int INT21_FindNext( CONTEXT *context ) >> INT21_FindPath = dta->fullPath = NULL; >> } >> dta->count = n; >> +p = dta->filename; >> +for ( ; *p

Re: [1/2] mscoree: Install Wine Mono on prefix update.

2012-05-30 Thread Alexandre Julliard
Vincent Povirk writes: > From d271ba591f6afb4e0b2356da24841f54d5f11b9b Mon Sep 17 00:00:00 2001 > From: Vincent Povirk > Date: Tue, 29 May 2012 10:35:36 -0500 > Subject: [PATCH 1/2] mscoree: Install Wine Mono on prefix update. > > --- > dlls/mscoree/mscoree_main.c | 120 >

Re: [PATCH 1/5] win16/int21: make found filename uppercase.

2012-05-30 Thread Alexandre Julliard
Oleksij Rempel writes: > @@ -3961,6 +3962,8 @@ static int INT21_FindNext( CONTEXT *context ) > INT21_FindPath = dta->fullPath = NULL; > } > dta->count = n; > +p = dta->filename; > +for ( ; *p; p++) *p = toupper(*p); Using toupper is probably not a g

Re: [PATCH 2/3] jscript: Get rid of ret_nan hack

2012-05-30 Thread Jacek Caban
On 05/29/12 22:06, Ruslan Kabatsayev wrote: > Hello, > > This patch (committed as d0a719a79dae001df341db907fcae54118691d35) > leads to compilation error: > > make[1]: Entering directory `/fastdocs/programmer/wine-git/dlls/msadp32.acm' > make[1]: Nothing to be done for `all'. > make[1]: Leaving dire

Re: ru.po: improved an Russian translation

2012-05-30 Thread Nikolay Sivov
On Wed, May 30, 2012 at 10:20 AM, Julian Rüger wrote: > > 3. You have a lot of changes like this: > >>  #: crypt32.rc:198 >>  msgid "Access Method=" >> -msgstr "Метод доступа=" >> +msgstr "Метод доступа: " > It makes no sense to do that. > I don't think that's a good idea... Afaik, the general