Re: [1/3] user32/tests: Comment-out PostQuitMessage (causes tests skip)

2012-05-28 Thread Alexey Slepov
I figured out now. As described in wine sources, PostQuitMessage() sets a flag in the thread's message queue that signals it to generate a WM_QUIT message when there are no other pending sent or posted messages in the queue. The tests with skipped testcases are those which use WM_TIMER messages -

Re: Implementing joystick ids in DirectInput

2012-05-28 Thread Vitaliy Margolen
On 05/28/2012 12:53 PM, Lucas Zawacki wrote: The solution I came up is in the attached patch, it's a little weird It's not just weird it's incorrect. You shouldn't use that list or rely on order of devices in that list. Instead you should use get_joystick_index() to get the index. It's not ex

Implementing joystick ids in DirectInput

2012-05-28 Thread Lucas Zawacki
Hey guys, asking for a little code review here... I was looking at the solution for this bug http://bugs.winehq.org/show_bug.cgi?id=30705 and it comes down to implementing the DIPROP_JOYSTICKSID property for joystick devices. After some research on what this is I know it's always a number between

Re: 1.4 has dropped off the list for AppDB submissions

2012-05-28 Thread André Hentschel
Am 28.05.2012 15:26, schrieb Rosanne DiMesio: > As of the release of 1.5.5, 1.4 has dropped off the list of Wine versions for > which AppDB test reports can be submitted. > > Can someone please add it to the list of stable releases that are always > available in the dropdown list? Until it's put

1.4 has dropped off the list for AppDB submissions

2012-05-28 Thread Rosanne DiMesio
As of the release of 1.5.5, 1.4 has dropped off the list of Wine versions for which AppDB test reports can be submitted. Can someone please add it to the list of stable releases that are always available in the dropdown list? Until it's put back, users will not be able to submit new test report

Re: [2/5] d3dx9: Implement D3DXSaveSurfaceToFileInMemory.

2012-05-28 Thread Vincent Povirk
> -    hr = IWICImagingFactory_CreateStream(factory, &stream); > +    hr = IWICImagingFactory_CreateStream(factory, &wic_stream); >     IWICImagingFactory_Release(factory); >     if (FAILED(hr)) goto cleanup_err; > > -    hr = IWICStream_InitializeFromFilename(stream, dst_filename, > GENERIC_WRITE

Re: [1/5] windowscodecs: Implement IWICStream::InitializeFromIStream.

2012-05-28 Thread Vincent Povirk
> +static HRESULT WINAPI StreamOnStream_Seek(IStream *iface, > +    LARGE_INTEGER dlibMove, DWORD dwOrigin, ULARGE_INTEGER *plibNewPosition) > +{ > +    StreamOnStream *This = StreamOnStream_from_IStream(iface); > +    HRESULT hr=S_OK; > +    TRACE("(%p)\n", This); > + > +    EnterCriticalSection(&