Re: [1/3] user32/tests: Comment-out PostQuitMessage (causes tests skip)

2012-05-27 Thread Dmitry Timoshkov
sir-lexa wrote: > case WM_DESTROY: > -PostQuitMessage(0); > +/* PostQuitMessage(0); It lets some tests to be skipped */ > return TRUE; This is not acceptable, there is much more behind the scene. You need to figure out the real reason of skipping the tests. -- D

Re: [1/3] user32/tests: Comment-out PostQuitMessage (causes tests skip)

2012-05-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18630 Your paranoid android

Re: d3dx9_36/tests: Add tests for D3DXCreatePolygon

2012-05-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18615 Your paranoid android

Re: func or pFunc in tests ?

2012-05-27 Thread GOUJON Alexandre
On 05/27/2012 05:08 PM, Juan Lang wrote: Basically, if the function is available on all versions of Windows that the test bot runs on, use func. If it's not available on some versions, and you need to test whether it's available to avoid a non-running test, use pFunc instead. Regarding the his

Re: func or pFunc in tests ?

2012-05-27 Thread Juan Lang
Hi Alexandre, On Sun, May 27, 2012 at 6:22 AM, GOUJON Alexandre wrote: > Some tests call directly the function by its name (i.e. GetWindowsDirectory, > CreateFileA, CloseHandle...) while others declare a pointer to the function > (prefixing its name by 'p' and followed by a capital letter) retrie

func or pFunc in tests ?

2012-05-27 Thread GOUJON Alexandre
Hi, I'm planning to add a test in the wine test suite and I noticed a difference. Some tests call directly the function by its name (i.e. GetWindowsDirectory, CreateFileA, CloseHandle...) while others declare a pointer to the function (prefixing its name by 'p' and followed by a capital let