Re: quartz/tests: Fix compilation on systems that don't support nameless structs.

2012-05-20 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18512 Your paranoid android

Re: [PATCH 3/3] shell32: Move the pidl handling to the ExtractIcon_Constructor

2012-05-20 Thread Nikolay Sivov
On 5/20/2012 18:47, Detlef Riekenberg wrote: } else if (IsEqualIID(riid,&IID_IExtractIconA)&&(cidl == 1)) { - pidl = ILCombine(This->pidlRoot, apidl[0]); - pObj = (LPUNKNOWN) IExtractIconA_Constructor(pidl); - SHFree(pidl); - hr = S_OK; +

Re: [PATCH 1/3] shell32: Add IQueryInfo in ShellFolder2_GetUIObjectOf [try 2]

2012-05-20 Thread Nikolay Sivov
On 5/20/2012 18:47, Detlef Riekenberg wrote: +HRESULT IQueryInfo_Constructor(LPCITEMIDLIST root, LPCITEMIDLIST item, void ** ppvOut) +{ +IQueryInfoImpl *qi = HeapAlloc(GetProcessHeap(), 0, sizeof(IQueryInfoImpl)); +LPITEMIDLIST pidl = ILCombine(root, item); + +if (!pidl || !qi) { +