Re: [PATCH] devenum: Do not fail with a IBindCtx (with tests)

2012-05-15 Thread Dmitry Timoshkov
Detlef Riekenberg wrote: > static HRESULT WINAPI DEVENUM_IMediaCatMoniker_BindToStorage(IMoniker > *iface, IBindCtx *pbc, > IMoniker *pmkToLeft, REFIID riid, void **ppvObj) > { > +static IBindCtx *old_bc; > MediaCatMoniker *This = impl_from_IMoniker(iface); > > TRACE("

wine/clang warnings

2012-05-15 Thread Austin English
Howdy, I tried Wine with LLVM/Clang from svn recently, thought others may like some of the results. I've also ran the static analyzer. For reference, this is with: wine-1.5.4-61-g8327e6f, plus the following patch: diff --git a/include/windef.h b/include/windef.h index 9cf98e7..e95388a 100644 ---

Re: comctl32: Fix message sequence when right-clicking a treeview

2012-05-15 Thread Nikolay Sivov
On 5/15/2012 21:59, Daniel Jelinski wrote: Are there any tests I could use as a base? Of course, all tests we have are in comctl32/tests/treeview.c . Some messaging tests are also present there. 2012/5/15 Nikolay Sivov: On 5/15/2012 21:30, Daniel Jelinski wrote: Patch dropped out of the pend

Re: comctl32: Fix message sequence when right-clicking a treeview

2012-05-15 Thread Daniel Jelinski
Are there any tests I could use as a base? 2012/5/15 Nikolay Sivov : > On 5/15/2012 21:30, Daniel Jelinski wrote: >> >> Patch dropped out of the pending list, resending. > > Please add a test for this fix. >

Re: comctl32: Fix message sequence when right-clicking a treeview

2012-05-15 Thread Nikolay Sivov
On 5/15/2012 21:30, Daniel Jelinski wrote: Patch dropped out of the pending list, resending. Please add a test for this fix.

Re: [PATCH 1/4] dsound: Change mix_buffer to float instead of INT

2012-05-15 Thread Alexander E. Patrakov
Andrew Eikum wrote: > +static LONG f_to_24(float value) > +{ > if(value <= -1.f) > +return 0x8000; > +if(value >= 1.f * 0x7F / 0x80) > +return 0x7F00; > +return lrintf(value * 0x8000U); > } ... > +static inline LONG f_to_32(float value) > +{ > +

Re: [PATCH 1/4] dsound: Remove minlen, since we always mix full chunks anyway

2012-05-15 Thread Alexander E. Patrakov
Andrew Eikum wrote: > - > - TRACE("Mixed at least %d from all buffers\n", minlen); > - return minlen; Hi. You have removed the message that could say "Mixed at least 0 from all buffers" (as seen, e.g., for Armored Fist 3 and sometimes even for foobar2000). What was the reason for that "0"

Re: [PATCH 1/3] user32: Added GetMenuBarInfo implementation (try2)

2012-05-15 Thread Alexandre Julliard
Piotr Caban writes: > This patch serie is based on Andrew Eikum's and Rein Klazes's work. > --- > dlls/user32/menu.c | 94 > > 1 files changed, 87 insertions(+), 7 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M use

Re: ddraw: Forward AddAttachedSurface to the correct equivalent

2012-05-15 Thread Stefan Dösinger
Am Montag, 14. Mai 2012, 18:45:01 schrieb paulo lesgaz: > But I can write a small test. Would writing a test attaching an offscreen surface to another offscreen surface be enough to convince you of the correctness of the change? I recommend to port the entire AttachmentTest from dlls/ddraw/tests/

Re: [PATCH 1/4] dsound: Remove minlen, since we always mix full chunks anyway

2012-05-15 Thread Andrew Eikum
On Tue, May 15, 2012 at 12:33:25PM +0600, Alexander E. Patrakov wrote: > Andrew Eikum wrote: > > - > > - TRACE("Mixed at least %d from all buffers\n", minlen); > > - return minlen; > > Hi. You have removed the message that could say "Mixed at least 0 from > all buffers" (as seen, e.g., for Arm