On 5/11/2012 09:19, Christian Costa wrote:
diff --git a/dlls/dmusic/dmusic_private.h b/dlls/dmusic/dmusic_private.h
index 73a05d4..96334c9 100644
--- a/dlls/dmusic/dmusic_private.h
+++ b/dlls/dmusic/dmusic_private.h
@@ -167,13 +167,14 @@ extern HRESULT WINAPI DMUSIC_CreateDMSynthPort(REFIID
rii
Yes, it is very mechanical.
The Proxy functions that widl generates are not the same kind of
function that are exported from windowscodecs. From what I can tell,
all these functions do is call a method on a COM interface. Also, not
every COM method in WIC has a Proxy export.
If I had to guess, I'
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=18319
Your paranoid android
On May 10, 2012, at 1:17 PM, Alexandre Julliard wrote:
> Module: wine
> Branch: master
> Commit: 2fc7cdc93f6dc8ed67498b74193423c44e5bb770
> URL:
> http://source.winehq.org/git/wine.git/?a=commit;h=2fc7cdc93f6dc8ed67498b74193423c44e5bb770
>
> Author: Vincent Povirk
> Date: Tue May 8 10:49
On Thu, May 10, 2012 at 3:35 PM, Austin English wrote:
> Any reason you're not using the wine wiki for that?
This is a self-hosted wiki because a lot of the information I tend to
write there is ephemereal, since I use it mostly as a way to document
my progress and organize myself.
I suppose I sh
2012/5/10 Józef Kucia :
>
> I noticed that I put more and more texture functions tests in
> tests/surface.c, because these tests needs the dds files which are in
> tests/surface.c. I wonder if it would be better to copy needed dds
> files to tests/texture.c and move texture function tests to their
On Thu, May 10, 2012 at 8:39 PM, Stefan Dösinger wrote:
> Since I've burned my hands with DDSURFACEDESC2 pitch handling in the past(e.g.
> bug 21238), I highly recommend to test it. Knowing msdn, the above page makes
> me less confident, not more :-\
>
> The most likely situation where an error oc
On Wed, May 9, 2012 at 11:32 PM, Józef Kucia wrote:
> diff --git a/dlls/d3dx9_36/tests/surface.c b/dlls/d3dx9_36/tests/surface.c
> index ab56593..3d5a50f 100644
> --- a/dlls/d3dx9_36/tests/surface.c
> +++ b/dlls/d3dx9_36/tests/surface.c
> @@ -917,6 +917,20 @@ static void
> test_D3DXCreateVolumeTe
>> > + stat = GdipGetLogFontW((GpFont *)font, graphics, &lfw);
>> > + if (stat != Ok) return stat;
>>
>> I'm not sure it's an improvement, since you need to add these ugly
>> casts. You should find a way that doesn't require that.
>
> I don't see a way to avoid that, gdiplus APIs are broken i
Alexandre Julliard wrote:
> > +stat = GdipGetLogFontW((GpFont *)font, graphics, &lfw);
> > +if (stat != Ok) return stat;
>
> I'm not sure it's an improvement, since you need to add these ugly
> casts. You should find a way that doesn't require that.
I don't see a way to avoid that, gdip
Dmitry Timoshkov writes:
> @@ -4926,12 +4925,15 @@ GpStatus WINGDIPAPI
> GdipMeasureCharacterRanges(GpGraphics* graphics,
> TRACE("(%p %s %d %p %s %p %d %p)\n", graphics, debugstr_w(string),
> length, font, debugstr_rectf(layoutRect), stringFormat,
> regionCount, regions);
>
Am Donnerstag, 10. Mai 2012, 11:12:06 schrieb Józef Kucia:
> Surfaces pitches doesn't seem to be 4 or 8 byte aligned in DDS files.
> MSDN recommends to not use pitch_or_linear_size and gives formulas for
> computing pitches [1]. When it comes to formats mentioned by you,
> D3DFMT_P8 doesn't seem to
On Thu, May 10, 2012 at 9:40 AM, Lucas Zawacki wrote:
> Hello all,
>
> I'll use this thread to post information and ask questions regarding
> my GSoC project.
>
> First there's a wiki which aggregates some information and lists tasks
> I'm working on: http://lfzawacki.heroku.com/wine/published/Hom
On Sat, May 5, 2012 at 9:26 PM, wrote:
> winetricks settings alldlls=builtin
>
> further checking revealed, that winetricks(20120308) has several no
> longer available dll override compared to winecfg and some are
> missing, thus application uses them as native.
>
> So i add/del dlls from overrid
2012/5/10 Juan Lang :
> Hi Alex,
> first, thanks for taking the time to respond to feedback. Showing
> responsiveness helps a great deal.
You're welcome :-)
> These helpers don't really gain you anything here, there's really not
> enough code to be worth using helpers. Please just copy/paste th
Andrew Eikum writes:
> Commit 31291cdc6 introduced some process exit code. This patch removes
> it again. There is some other cleanup that happens on process exit,
> but that's been there for years. Do you want me to change the patch to
> remove that old code as well?
You might as well short-cir
Dave Chinner wrote:
> st_blksize - file block size
> st_alloc_blksize- allocation block size/alignment
> st_small_io_size- IO size/alignment that avoids
> filesystem/page cache RMW
> st_preferred_io_size- pre
On Thu, May 10, 2012 at 4:27 PM, Matteo Bruni wrote:
> It looks like you're not actually using the faces variable.
Thanks. I should multiply expected_size by faces.
On Thu, May 10, 2012 at 4:29 PM, Matteo Bruni wrote:
> 2012/5/9 Józef Kucia :
>> ---
>> +HRESULT load_texture_from_dds(IDirect3DTexture9 *texture, const void
>> *src_data, UINT srd_data_size,
>> + const PALETTEENTRY *palette, DWORD filter, D3DCOLOR color_key, const
>> D3DXIMAGE_INFO *src_info
On Thu, May 10, 2012 at 4:28 PM, Matteo Bruni wrote:
> 2012/5/9 Józef Kucia :
>> + if ((caps.Caps2 & D3DCAPS2_DYNAMICTEXTURES) && (pool !=
>> D3DPOOL_DEFAULT) && (usage != D3DUSAGE_DYNAMIC))
>> + {
>> + hr = D3DXCreateCubeTexture(device, size, mip_levels, usage, format,
>> pool, &te
On Thu, May 10, 2012 at 4:25 PM, Matteo Bruni wrote:
> I guess it would make sense to add all the new pixel formats to the
> table, assuming it doesn't break the tests or other stuff.
Luminance pixel formats could be added, but I'm not sure about
BUMPDUDV pixel formats. For BUMPDUDV pixel formats
Hi Alex,
first, thanks for taking the time to respond to feedback. Showing
responsiveness helps a great deal.
Next, on your patch: I'm trying to help you get this committed, so
this is meant to be constructive feedback.
+static void test_WideCharToMultiByte_error(UINT page, DWORD flags, LPCWSTR
Hello all,
I'll use this thread to post information and ask questions regarding
my GSoC project.
First there's a wiki which aggregates some information and lists tasks
I'm working on: http://lfzawacki.heroku.com/wine/published/HomePage
Then there's a github repo: https://github.com/lfzawacki/wine
2012/5/9 Józef Kucia :
> ---
> +HRESULT load_texture_from_dds(IDirect3DTexture9 *texture, const void
> *src_data, UINT srd_data_size,
> + const PALETTEENTRY *palette, DWORD filter, D3DCOLOR color_key, const
> D3DXIMAGE_INFO *src_info) DECLSPEC_HIDDEN;
...
> +HRESULT load_texture_from_dds(IDire
2012/5/9 Józef Kucia :
> + mip_levels = min(src_info->MipLevels,
> IDirect3DCubeTexture9_GetLevelCount(cube_texture));
> + for (face = D3DCUBEMAP_FACE_POSITIVE_X; face <=
> D3DCUBEMAP_FACE_NEGATIVE_Z; face++)
> + {
> + size = src_info->Width;
> + for (mip_level = 0; mip_lev
2012/5/9 Józef Kucia :
> +static HRESULT get_image_info_from_dds(const void *buffer, UINT length,
> D3DXIMAGE_INFO *info)
> {
> + UINT i;
> + UINT faces = 0;
...
> + /* calculate the expected length */
> + width = info->Width;
> + height = info->Height;
> + for (i = 0; i < info->MipLe
2012/5/9 Józef Kucia :
> diff --git a/dlls/d3dx9_36/util.c b/dlls/d3dx9_36/util.c
> index 4dbf44c..ad8a6ea 100644
> --- a/dlls/d3dx9_36/util.c
> +++ b/dlls/d3dx9_36/util.c
> @@ -62,6 +62,7 @@ static const PixelFormatDesc formats[] =
> {D3DFMT_G16R16, {0, 16, 16, 0}, { 0, 0, 16, 0}, 4, 1
2012/5/10 Andrew Eikum
> On Thu, May 10, 2012 at 07:52:58AM +0200, Christian Costa wrote:
> > static HRESULT read_from_stream(IStream *stream, void *data, ULONG size)
> > {
> > -ULONG readed;
> > +ULONG read;
> > HRESULT hr;
> >
> > -hr = IStream_Read(stream, data, size, &reade
On Thu, May 10, 2012 at 08:29:25AM +0200, Alexandre Julliard wrote:
> Andrew Eikum writes:
>
> > ---
> > This fixes bug 30631, introduced by
> > 31291cdc6ccc4c172ccf86f383c6a90f31a50ba1.
> >
> > In addition to safely exiting on process exit, we do much more
> > thorough cleanup on process detach.
On Thu, May 10, 2012 at 07:52:58AM +0200, Christian Costa wrote:
> static HRESULT read_from_stream(IStream *stream, void *data, ULONG size)
> {
> -ULONG readed;
> +ULONG read;
> HRESULT hr;
>
> -hr = IStream_Read(stream, data, size, &readed);
> +hr = IStream_Read(stream, da
On Thu, May 10, 2012 at 11:16 AM, Stefan Dösinger
wrote:
> Am Mittwoch, 9. Mai 2012, 23:32:10 schrieb Józef Kucia:
>> +#define check_pixel_3bpp(lockrect, x, y, color) \
>> +ok(((BYTE*)(lockrect).pBits)[3 * (x) + (y) * (lockrect).Pitch + 0] ==
>> ...
> Inline functions are generally prefered over m
Am Mittwoch, 9. Mai 2012, 23:32:10 schrieb Józef Kucia:
> +#define check_pixel_3bpp(lockrect, x, y, color) \
> +ok(((BYTE*)(lockrect).pBits)[3 * (x) + (y) * (lockrect).Pitch + 0] => ...
Inline functions are generally prefered over macros where possible. I think it
is possible to pass a different li
On Thu, May 10, 2012 at 10:32 AM, Stefan Dösinger
wrote:
> Am Mittwoch, 9. Mai 2012, 23:32:05 schrieb Józef Kucia:
>> + *pitch = width * format_desc->bytes_per_pixel;
>> + *size = *pitch * height;
> Usually surface pitches are either 4 or 8 byte aligned(depending on the API
> and poo
On 5/10/2012 12:01, Piotr Caban wrote:
Thanks to this patch we no longer ask about the item text inside this
notification before returning error.
---
dlls/comctl32/listview.c |1 +
dlls/comctl32/tests/listview.c |8 +++-
2 files changed, 8 insertions(+), 1 deletions(-)
Am Mittwoch, 9. Mai 2012, 23:32:05 schrieb Józef Kucia:
> +*pitch = width * format_desc->bytes_per_pixel;
> +*size = *pitch * height;
Usually surface pitches are either 4 or 8 byte aligned(depending on the API
and pool). I recommend to write some tests for this. The most likely
prob
35 matches
Mail list logo
