Andrew Eikum writes:
> ---
> This fixes bug 30631, introduced by
> 31291cdc6ccc4c172ccf86f383c6a90f31a50ba1.
>
> In addition to safely exiting on process exit, we do much more
> thorough cleanup on process detach.
There shouldn't be any reason to do cleanup on process exit (and you
can't really
2012/5/10 Nikolay Sivov :
>> Which file should I have used?
>
> codepage.c, you could search all test files for a thing you're trying to
> add.
Okay, I've moved the tests to codepage.c in try 4. Thanks for the tip,
I'll keep that in mind from now on.
> Nothing really changed in try3, test helpers
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=18298
Your paranoid android
On 5/10/2012 07:38, Alex Henrie wrote:
2012/5/9 Nikolay Sivov:
Does any application depend on that?
Probably. Better safe than sorry, and Wine's current behavior
definitely doesn't match what MSDN says nor what Windows actually
does.
dlls/kernel32/locale.c | 38 ++---
d
2012/5/9 Nikolay Sivov :
> Does any application depend on that?
Probably. Better safe than sorry, and Wine's current behavior
definitely doesn't match what MSDN says nor what Windows actually
does.
>> dlls/kernel32/locale.c | 38 ++---
>> dlls/kernel32/tests/locale.c | 94
>
On 5/10/2012 00:52, Alex Henrie wrote:
This patch was a lot harder to figure out than I thought it was going to be.
The MSDN documentation of most of these behaviors can be found at
http://msdn.microsoft.com/en-us/library/windows/desktop/dd319072(v=vs.85).aspx
Does any application depend on tha
Alex Henrie writes:
> 2012/5/8 Alexandre Julliard :
>> That code is hopelessly ugly, and broken in various ways. You are
>> probably better off starting from scratch.
>
> Okay. Could we use the POSIX iconv functions? Why doesn't Wine use
> iconv for UTF-8 already?
UTF-8 is trivial, using iconv w
André Hentschel writes:
> ---
> dlls/d3drm/tests/d3drm.c | 323
> +-
> 1 file changed, 320 insertions(+), 3 deletions(-)
It doesn't seem necessary to duplicate the whole thing, try to find a
better way.
--
Alexandre Julliard
julli...@winehq.org
Christian Costa writes:
> Try 5: Use a growing buffer to store name.
I don't think a growing buffer makes sense for this.
> +if (name)
> +{
> +*size = min(*size, This->name_size);
> +memcpy(name, This->name, *size);
> +/* Make sure we have the terminating 0 in ca
2012/5/8 Alexandre Julliard :
> That code is hopelessly ugly, and broken in various ways. You are
> probably better off starting from scratch.
Okay. Could we use the POSIX iconv functions? Why doesn't Wine use
iconv for UTF-8 already?
-Alex
10 matches
Mail list logo
