Alex Henrie writes:
> Hi all,
>
> Could I get some feedback on
> http://source.winehq.org/patches/data/85898 ? It was marked "Rejected"
> a week ago without explanation.
>
> Most of the code was authored by Katayama Hirofumi, whose patches have
> been accepted into Wine before. He gave permission
On 8 May 2012 12:50, Alex Henrie wrote:
> 2012/5/7 Ben Klein :
>> Without being a regular contributor, here are a few tips from a cursory
>> glance:
>> 1) Whitespace change on at least one line
>
> The only change to whitespace I made was:
>
> - if( flags)
> + if (flags)
>
> I don't
2012/5/7 Ben Klein :
> Without being a regular contributor, here are a few tips from a cursory
> glance:
> 1) Whitespace change on at least one line
The only change to whitespace I made was:
- if( flags)
+ if (flags)
I don't think this is a big deal.
> 2) Why the change from ERRO
On 8 May 2012 11:21, Alex Henrie wrote:
> Hi all,
>
> Could I get some feedback on
> http://source.winehq.org/patches/data/85898 ? It was marked "Rejected"
> a week ago without explanation.
Without being a regular contributor, here are a few tips from a cursory glance:
1) Whitespace change on at
Hi all,
Could I get some feedback on
http://source.winehq.org/patches/data/85898 ? It was marked "Rejected"
a week ago without explanation.
Most of the code was authored by Katayama Hirofumi, whose patches have
been accepted into Wine before. He gave permission to use his code
under the LGPL at h
On Sat, 5 May 2012, Frédéric Delanoy wrote:
[...]
> The msiexec conventions look sane to me: [ ] for optional and { } for
> mandatory parameters (*only* when a choice/list is involved). It's
> also what's used in other wine commands "/?" results (e.g. 'start',
> 'ipconfig', 'regedit', etc.).
It's
Hello friends,
>> Because you do seriously believe that ReactOS developers reversed the
>> Windows notepad?! Along with Solitaire & calculator, I suppose?
>> Common sense is a powerful tool, let's make use of it :-).
>
>It's a matter of trust. If a person is known to use illegal practices
>to writ
