Re: po: English (neutral / Great Britain) spelling fixes.

2012-05-03 Thread Francois Gouget
On Thu, 3 May 2012, Nicolas Le Cam wrote: [...] > > IMO they shouldn't be translated, since they indicate the long version > > of options. [...] > You're right ! > (Even if code seems to only check if the second letter is a 'a' or > anything else .. and windows only advertise /MIN and /MAX as valid

Re: [3/5] d3dx9: Implement D3DXSaveSurfaceToFileW.

2012-05-03 Thread Henri Verbeet
On 3 May 2012 15:48, Józef Kucia wrote: > Thanks for the review. > > On Thu, May 3, 2012 at 1:08 PM, Henri Verbeet wrote: >>> +    memcpy(&wic_pixel_format, pixel_format_guid, sizeof(GUID)); >>> +    hr = IWICBitmapFrameEncode_SetPixelFormat(frame, &wic_pixel_format); >>> +    d3d_pixel_format =

Re: [3/5] d3dx9: Implement D3DXSaveSurfaceToFileW.

2012-05-03 Thread Józef Kucia
Thanks for the review. On Thu, May 3, 2012 at 1:08 PM, Henri Verbeet wrote: >> +    memcpy(&wic_pixel_format, pixel_format_guid, sizeof(GUID)); >> +    hr = IWICBitmapFrameEncode_SetPixelFormat(frame, &wic_pixel_format); >> +    d3d_pixel_format = wic_guid_to_d3dformat(&wic_pixel_format); > What

Re: [2/5] d3dx9: Forward D3DXSaveSurfaceToFileA to D3DXSaveSurfaceToFileW.

2012-05-03 Thread Henri Verbeet
On 2 May 2012 23:32, Józef Kucia wrote: > +HRESULT WINAPI D3DXSaveSurfaceToFileA(LPCSTR dst_filename, > D3DXIMAGE_FILEFORMAT file_format, > +        IDirect3DSurface9 *src_surface, const PALETTEENTRY *src_palette, > const RECT *src_rect) If you're changing these anyway, LPCSTR is a broken way of

Re: [3/5] d3dx9: Implement D3DXSaveSurfaceToFileW.

2012-05-03 Thread Henri Verbeet
On 2 May 2012 23:32, Józef Kucia wrote: > +        if(wic_pixel_formats[i].d3dformat == format) Missing whitespace. > +HRESULT WINAPI D3DXSaveSurfaceToFileW(LPCWSTR dst_filename, > D3DXIMAGE_FILEFORMAT file_format, "LPCWSTR" -> "const WCHAR *" > +    TRACE("(%s, %d, %p, %p, %p)\n", > +        w

Re: Request for help/advice in investigation of one interesting "huge FPS regression" bug

2012-05-03 Thread Henri Verbeet
On 3 May 2012 07:17, Alexey Loukianov wrote: > Trying to pinpoint the cause using oprofile produced no valuable results: it > either me not able to use this wonderful profiler correctly or the issue is of > such kind that isn't easily tracked by oprofile. > Personally I think perf is a bit nicer t

Re: [PATCH 5/9] jscript: Better handling of to_integer result in String.lastIndexOf

2012-05-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18203 Your paranoid android

Re: [PATCH 3/9] jscript: Better handling of to_integer result in String.charCodeAt

2012-05-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18201 Your paranoid android

Re: [PATCH 1/9] jscript: Better handling of to_integer result in Array.splice

2012-05-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18199 Your paranoid android

Re: [PATCH 4/9] jscript: Bettter handling of to_number result in String.indexOf

2012-05-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18202 Your paranoid android

Re: [PATCH 2/9] jscript: Better handling of to_integer result in String.charAt

2012-05-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18200 Your paranoid android

Re: [PATCH 2/2] d3drm: Implement IDirect3DRMFrameX_GetChildren method and IDirect3DRMFrameArray interface. (try 2) (resend)

2012-05-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18196 Your paranoid android

Re: po: English (neutral / Great Britain) spelling fixes.

2012-05-03 Thread Nicolas Le Cam
2012/5/3 Frédéric Delanoy : > On Thu, May 3, 2012 at 7:07 AM, Nicolas Le Cam wrote: >> Le 3 mai 2012 02:45, "Francois Gouget" a écrit : >> >> >>> @@ -9429,9 +9429,9 @@ msgstr "" >>>  "start [options] document_filename\n" >>>  "\n" >>>  "Options:\n" >>> -"/M[inimized] Start the program minimized.\