Re: [1/2] comctl32/tests: Added tests for mouse events handling (try 5)

2012-04-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1 Your paranoid android

Re: [1/2] comctl32/tests: Added tests for mouse events handling (try 4)

2012-04-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17772 Your paranoid android

Re: [PATCH 1/6] msvcrt: Rewrite asctime function (try3)

2012-04-10 Thread Alexandre Julliard
Piotr Caban writes: > +|| !MSVCRT_CHECK_PMT(asctime_buf(time, mstm) != NULL)) { You don't want to use MSVCRT_CHECK_PMT this way, the error won't make sense. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 1/6] msvcrt: Rewrite asctime function

2012-04-10 Thread David Laight
On Tue, Apr 10, 2012 at 03:09:52PM +0200, Alexandre Julliard wrote: > Piotr Caban writes: > > > @@ -48,7 +49,7 @@ static const int MonthLengths[2][12] = > > > > static inline int IsLeapYear(int Year) > > { > > -return Year % 4 == 0 && (Year % 100 != 0 || Year % 400 == 0); > > +return

Re: [PATCH 1/2] server: Add mechanism to retrieve the connect time of a socket (resend 2, deferred, rebased).

2012-04-10 Thread Alexandre Julliard
"Erich E. Hoover" writes: > On Tue, Apr 10, 2012 at 6:46 AM, Alexandre Julliard > wrote: >> "Erich E. Hoover" writes: >> ... >> > Changelog: >> >     server: Add mechanism to retrieve the connect time of a socket. >> >> You should make it a generic get_info request, and return the time in >> s

Re: [PATCH 1/2] server: Add mechanism to retrieve the connect time of a socket (resend 2, deferred, rebased).

2012-04-10 Thread Erich E. Hoover
On Tue, Apr 10, 2012 at 6:46 AM, Alexandre Julliard wrote: > "Erich E. Hoover" writes: > ... > > Changelog: > >     server: Add mechanism to retrieve the connect time of a socket. > > You should make it a generic get_info request, and return the time in > standard server format. Maybe I'm missin

Re: [PATCH 1/6] msvcrt: Rewrite asctime function

2012-04-10 Thread Alexandre Julliard
Piotr Caban writes: > @@ -48,7 +49,7 @@ static const int MonthLengths[2][12] = > > static inline int IsLeapYear(int Year) > { > -return Year % 4 == 0 && (Year % 100 != 0 || Year % 400 == 0); > +return (Year % 4 == 0 && (Year % 100 != 0 || Year % 400 == 0)) ? 1 : 0; Maybe you should d

Re: msvcrt: Add bsearch_s implementation by reusing code and tests from ntdll (try 4)

2012-04-10 Thread Alexandre Julliard
André Hentschel writes: > /* > + * bsearch_s (msvcrt.@) > + */ > +void* CDECL MSVCRT_bsearch_s(const void *key, const void *base, > + MSVCRT_size_t nmemb, MSVCRT_size_t size, > +

Re: [PATCH 1/2] server: Add mechanism to retrieve the connect time of a socket (resend 2, deferred, rebased).

2012-04-10 Thread Alexandre Julliard
"Erich E. Hoover" writes: > Real Name: > Erich Hoover > > Description: > This patch implements storing the connect time of a socket for > retrieval with the SO_CONNECT_TIME socket option (part 2). > > Changelog: > server: Add mechanism to retrieve the connect time of a socket. You sh

Re: [PATCH 6/6] msvcrt/tests: Added more strftime tests

2012-04-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17760 Your paranoid android

Re: [PATCH 1/6] msvcrt: Rewrite asctime function

2012-04-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17759 Your paranoid android

Re: 'Pending' patches state

2012-04-10 Thread Dmitry Timoshkov
Marcus Meissner wrote: > Also Alexandre to some parts comments on bad patches these days. :) If by 'bad patches' you mean patches in the rejected state that's not the subject of this thread. -- Dmitry.

Re: 'Pending' patches state

2012-04-10 Thread Marcus Meissner
On Tue, Apr 10, 2012 at 04:52:42PM +0900, Dmitry Timoshkov wrote: > Jeff Latimer wrote: > > > I agree a lot of developers would benefit from feedback, however that > > does not appear to be the Wine way of doing business. Maybe a halfway > > measure would be to automatically notify the developer

Re: 'Pending' patches state

2012-04-10 Thread Dmitry Timoshkov
Jeff Latimer wrote: > I agree a lot of developers would benefit from feedback, however that > does not appear to be the Wine way of doing business. Maybe a halfway > measure would be to automatically notify the developer that their patch > has been marked as pending and then the developer can as

Re: RFC: KUSER_SHARED_DATA update patch to fix bug 29168

2012-04-10 Thread Kornél Pál
On 4/10/2012 4:48 AM, Vitaliy Margolen wrote: On 04/09/2012 12:14 PM, Kornél Pál wrote: I think this would work. (But don't know whether it was accepted.) No, it won't work. Wine itself (ntdll & kernel32) accesses it. In my opinion it still would work, just would not be optimal. Note that I