Re: [1/2] comctl32/tests: Added tests for mouse events handling (try 3)

2012-04-09 Thread Daniel Jeliński
Dnia 09-04-2012 o 04:13:44 Vitaliy Margolen napisał(a): On 04/08/2012 01:44 PM, Daniel Jelinski wrote: Hardware messages are an alternative, but I couldn't find any relevant examples, so I followed the path of least resistance. These tests you wrote won't work. Emulating mouse up/down events w

winebuild port to ARM?

2012-04-09 Thread Roger Cruz
Has anyone worked or is currently working on porting the x86 specific code in Winebuild to ARM?  Specifically the relay.c file? Thanks Roger R. Cruz

Re: RFC: KUSER_SHARED_DATA update patch to fix bug 29168

2012-04-09 Thread Vitaliy Margolen
On 04/09/2012 12:14 PM, Kornél Pál wrote: I think this would work. (But don't know whether it was accepted.) No, it won't work. Wine itself (ntdll & kernel32) accesses it. Vitaliy.

Re: 'Pending' patches state

2012-04-09 Thread Jeff Latimer
On 09/04/12 16:50, Dmitry Timoshkov wrote: > It should be in the best ineterests of the project to provide as much > feedback as possible, and should improve not only amount of accepted > code (by encouraging developers provide more > comments/explanations/tests/etc. and more actively discuss possi

Re: [PATCH 2/2] wininet/tests: Added checks for bad return values and skip tests when it happens. (try 2)

2012-04-09 Thread Alexandre Julliard
Morten Rønne writes: > Hi Alexandre > > Well if you do not get a ERROR_INSUFFICIENT_BUFFER back, then > cbCacheEntryInfo will not be changed, and that means that using that > value in a following HeapAlloc may cause different kind of problems. > If cbCacheEntryInfo were zero, this will cause the

Re: [PATCH 2/2] wininet/tests: Added checks for bad return values and skip tests when it happens. (try 2)

2012-04-09 Thread Morten Rønne
Hi Alexandre Well if you do not get a ERROR_INSUFFICIENT_BUFFER back, then cbCacheEntryInfo will not be changed, and that means that using that value in a following HeapAlloc may cause different kind of problems. If cbCacheEntryInfo were zero, this will cause the following HeapAlloc to succese

Re: RFC: KUSER_SHARED_DATA update patch to fix bug 29168

2012-04-09 Thread Kornél Pál
On 4/9/2012 7:46 PM, Francois Gouget wrote: On Thu, 22 Mar 2012, Kornél Pál wrote: [...] A bit better approach was to mark that page PAGE_GUARD. Then wine could get an indication that it needs to be updated. Frequent accesses were not impacted because PAGE_GUARD could be reset by an APC some tim

Re: RFC: KUSER_SHARED_DATA update patch to fix bug 29168

2012-04-09 Thread Francois Gouget
On Thu, 22 Mar 2012, Kornél Pál wrote: [...] > A bit better approach was to mark that page PAGE_GUARD. Then wine could get an > indication that it needs to be updated. Frequent accesses were not impacted > because PAGE_GUARD could be reset by an APC some time later. Why reset PAGE_GUARD? Would the

Re: [PATCH 2/2] wininet/tests: Added checks for bad return values and skip tests when it happens. (try 2)

2012-04-09 Thread Alexandre Julliard
Morten Rønne writes: > diff --git a/dlls/wininet/tests/urlcache.c b/dlls/wininet/tests/urlcache.c > index 02d8d28..1bf3f23 100644 > --- a/dlls/wininet/tests/urlcache.c > +++ b/dlls/wininet/tests/urlcache.c > @@ -60,7 +60,20 @@ static void test_find_url_cache_entriesA(void) > hEnumHandle = Fi

Re: [1/3] shell32: Add test for GetCurrentProcessExplicitAppUserModelID.

2012-04-09 Thread Vincent Povirk
> I don't think you need a new file for that. Probably true. I guess I was just making room for myself because I'm not sure yet how extensive the tests will have to be (or WHERE most of them will have to be).

Re: msvcrt: Add bsearch_s implementation by reusing code and tests from ntdll (try 3)

2012-04-09 Thread Alexandre Julliard
André Hentschel writes: > @@ -124,6 +124,39 @@ void* CDECL _lsearch(const void* match, void* start, > } > > /* > + * bsearch_s (msvcrt.@) > + */ > +void* CDECL MSVCRT_bsearch_s(const void *key, const void *ba

Re: [1/3] shell32: Add test for GetCurrentProcessExplicitAppUserModelID.

2012-04-09 Thread Alexandre Julliard
Vincent Povirk writes: > @@ -3,6 +3,7 @@ IMPORTS = shell32 ole32 oleaut32 user32 advapi32 > > C_SRCS = \ > appbar.c \ > + appusermodel.c \ > assoc.c \ > autocomplete.c \ > brsfolder.c \ I don't think you need a new file for that. -- Alexandre Julliard julli...@

Re: jscript: Replace only the first match for non-regexp pattern in String.replace

2012-04-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17730 Your paranoid android