Re: 'Pending' patches state

2012-03-30 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > WM_SHOWWINDOW at the start and at the end of every message sequence > > means that ShowWindow() should be used to hide and show the window > > during SetParent call processing. > > That's the sort of explanation you should have included in your > patch, instead of e

Re: jscript: Fixed jsheap_grow implementation

2012-03-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17589 Your paranoid android

Re: quartz: update ICOM_THIS_MULTI to follow the new COM standard

2012-03-30 Thread Aric Stewart
ok thanks, Glad I got this feedback before I started submitting my com cleanup patches that used it. -aric On 3/30/12 11:26 AM, Jacek Caban wrote: On 03/30/12 18:09, Aric Stewart wrote: Meaning that I should not shift TO using that macro instead shift AWAY from using it? I have been doing

Re: quartz: update ICOM_THIS_MULTI to follow the new COM standard

2012-03-30 Thread Jacek Caban
On 03/30/12 18:09, Aric Stewart wrote: > Meaning that I should not shift TO using that macro instead shift AWAY > from using it? > > I have been doing some cleanup and been shifting to using it more. ICOM_THIS_MULTI macro should go away. Your patch made ICOM_THIS_MULTI look a bit better by using C

Re: quartz: update ICOM_THIS_MULTI to follow the new COM standard

2012-03-30 Thread Aric Stewart
Meaning that I should not shift TO using that macro instead shift AWAY from using it? I have been doing some cleanup and been shifting to using it more. -aric On 3/30/12 11:08 AM, Jacek Caban wrote: On 03/30/12 17:55, Aric Stewart wrote: diff --git a/dlls/quartz/quartz_private.h b/dlls/quart

Re: quartz: update ICOM_THIS_MULTI to follow the new COM standard

2012-03-30 Thread Jacek Caban
On 03/30/12 17:55, Aric Stewart wrote: > diff --git a/dlls/quartz/quartz_private.h b/dlls/quartz/quartz_private.h > index 35cd52b..d2f680c 100644 > --- a/dlls/quartz/quartz_private.h > +++ b/dlls/quartz/quartz_private.h > @@ -38,7 +38,7 @@ > #define BYTES_FROM_MEDIATIME(time) SEC_FROM_MEDIATIME(ti

Re: [2/2] gdi32: Simplify font cache. (try 2)

2012-03-30 Thread Alexandre Julliard
Kusanagi Kouichi writes: > @@ -1516,23 +1464,8 @@ static void add_face_to_cache(Face *face) > RegSetValueExW(hkey_face, face_full_name_value, 0, REG_SZ, > (BYTE*)face->FullName, > (strlenW(face->FullName) + 1) * sizeof(WCHAR)); > > -reg_save_dword(hkey_face

Re: [PATCH 3/3] dmsynth: Put port caps that match native ones.

2012-03-30 Thread Andrew Eikum
On Fri, Mar 30, 2012 at 12:33:51PM +0200, joerg-cyril.hoe...@t-systems.com wrote: > Andrew Eikum asked Christian Costa: > >Just to be clear, which "native" do you mean? Does this match Windows > >7's dmusic behavior, or something else? I've been trying to target > >Windows 7's behavior in the new

Re: jscript: Add VT_I2 support (try 2)

2012-03-30 Thread Jacek Caban
Hi Alistair, On 03/30/12 12:29, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > jscript: Add VT_I2 support > hres = IDispatchEx_InvokeEx(dispex, id, ctx->lcid, flags, dp, retv, &ei->ei, &ctx->jscaller->IServiceProvider_iface); +if(SUCCEEDED(hres) && retv) +{ +if

Re: [2/2] scrrun: Add scrrun tests (try 3)

2012-03-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17581 Your paranoid android

Re: gdi32: Add support for loading scalable font resources.

2012-03-30 Thread Dmitry Timoshkov
Huw Davies wrote: > > > +if (size.u.LowPart < sizeof( *dos )) goto fail; > > > > Testing LowPart only could not work for large sizes. > > Of course, but we don't care if very large files fail, they won't be > genuine resource files anyway. Then returning 64-bit sizes doesn't make sence, an

Re: gdi32: Add support for loading scalable font resources.

2012-03-30 Thread Huw Davies
On Fri, Mar 30, 2012 at 07:31:54PM +0900, Dmitry Timoshkov wrote: > Huw Davies wrote: > > > +if (size.u.LowPart < sizeof( *dos )) goto fail; > > Testing LowPart only could not work for large sizes. Of course, but we don't care if very large files fail, they won't be genuine resource files a

Re: gdi32: Add support for loading scalable font resources.

2012-03-30 Thread Dmitry Timoshkov
Huw Davies wrote: > +if (size.u.LowPart < sizeof( *dos )) goto fail; Testing LowPart only could not work for large sizes. -- Dmitry.

[PATCH 3/3] dmsynth: Put port caps that match native ones.

2012-03-30 Thread Joerg-Cyril . Hoehle
Hi, Andrew Eikum asked Christian Costa: >Just to be clear, which "native" do you mean? Does this match Windows >7's dmusic behavior, or something else? I've been trying to target >Windows 7's behavior in the new audio design. A w7 target makes a lot of sense for mmdevapi/WASAPI. However, isn't D