Re: Having problems with building a deb package of the sources

2012-03-13 Thread Nicholas van Oudtshoorn
On 03/14/2012 11:43 AM, Rahul Ghose wrote: I am using the 1.4-rc6 source code to build the deb package. The source compiles smoothly but debuild -us -uc fails with this message: (last few lines, I hope which are more relevant) ../../../tools/runtest -q -P wine -M atl.dll -T ../../.. -p atl_tes

Having problems with building a deb package of the sources

2012-03-13 Thread Rahul Ghose
I am using the 1.4-rc6 source code to build the deb package. The source compiles smoothly but debuild -us -uc fails with this message: (last few lines, I hope which are more relevant) ../../../tools/runtest -q -P wine -M atl.dll -T ../../.. -p atl_test.exe.soatl_ax.c && touch atl_ax.ok Applicatio

Re: gdiplus: Use StretchBlt instead of GdiAlphaBlend if device doesn't support alpha blending.

2012-03-13 Thread Dmitry Timoshkov
Vincent Povirk wrote: > > I don't understand your objection, nothing prevents you from improving > > my patch. Printing something is still better than printing nothing, consdier > > this as adding a partial implemenation in the place of a stub. GdiAlphaBlend > > is not supported by printers, that

Re: [PATCH] po: Remove bad characters (C2 & A0) from french translations.

2012-03-13 Thread Julian Rüger
Am Dienstag, den 13.03.2012, 14:51 +0100 schrieb Frédéric Delanoy: > On Tue, Mar 13, 2012 at 11:52, Christian Costa wrote: > > This string exists in native devenum and thus is subject to translation so I > > just have to > > find why regedit displays it badly when editing the registry. Wine traces

Re: Preprocessing asm shaders

2012-03-13 Thread Józef Kucia
On Tue, Mar 13, 2012 at 1:22 PM, Matteo Bruni wrote: > That is bug http://bugs.winehq.org/show_bug.cgi?id=24614. My shot at > it was http://www.winehq.org/pipermail/wine-patches/2011-February/098609.html. > You can see that my approach was essentially what you are suggesting. > Still, that's not a

Re: A question about Wine's mshtml implementation vs. crashing app

2012-03-13 Thread Austin English
On Tue, Mar 13, 2012 at 14:59, Alexey Loukianov wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Good day to all, > > I've got a question, which is most probably should be addressed to Jacek > Caban, concerning the proper way to debug and report about the problems with > wine-gecko/msh

Re: gdiplus: Use StretchBlt instead of GdiAlphaBlend if device doesn't support alpha blending.

2012-03-13 Thread Vincent Povirk
>> > I tested printing quite a bit of different documents with an application >> > I have here and all of them get printed correctly with the patch. Before >> > the printed pages were just blank. What do you think is better for a user? >> >> It's not good if things work by coincidence in one case t

Re: gdiplus: Use StretchBlt instead of GdiAlphaBlend if device doesn't support alpha blending.

2012-03-13 Thread Dmitry Timoshkov
Vincent Povirk wrote: > > I tested printing quite a bit of different documents with an application > > I have here and all of them get printed correctly with the patch. Before > > the printed pages were just blank. What do you think is better for a user? > > It's not good if things work by coinc

A question about Wine's mshtml implementation vs. crashing app

2012-03-13 Thread Alexey Loukianov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Good day to all, I've got a question, which is most probably should be addressed to Jacek Caban, concerning the proper way to debug and report about the problems with wine-gecko/mshtml implementation. What I've got here is an app that crashes unless

Re: gdiplus: Use StretchBlt instead of GdiAlphaBlend if device doesn't support alpha blending.

2012-03-13 Thread Vincent Povirk
> I tested printing quite a bit of different documents with an application > I have here and all of them get printed correctly with the patch. Before > the printed pages were just blank. What do you think is better for a user? It's not good if things work by coincidence in one case that's importan

Re: gdiplus: Use StretchBlt instead of GdiAlphaBlend if device doesn't support alpha blending.

2012-03-13 Thread Dmitry Timoshkov
Vincent Povirk wrote: > You can't rely on the area we're drawing to be rectangular. We use > AlphaBlend to draw rotated images, any text that isn't a solid color, > and any brushes other than solid or hatch brushes. Anything we can't > do accurately with gdi32 will use AlphaBlend, and the number

Re: gdiplus: Use StretchBlt instead of GdiAlphaBlend if device doesn't support alpha blending.

2012-03-13 Thread Vincent Povirk
You can't rely on the area we're drawing to be rectangular. We use AlphaBlend to draw rotated images, any text that isn't a solid color, and any brushes other than solid or hatch brushes. Anything we can't do accurately with gdi32 will use AlphaBlend, and the number of cases will only increase. Ca

Re: msvcp90/tests: Don't redefine __thiscall (resend).

2012-03-13 Thread Nicolas Le Cam
Le 13 mars 2012 16:28, Alexandre Julliard a écrit : > Nicolas Le Cam writes: > >> @@ -60,11 +60,13 @@ static char* (__cdecl *p_Copy_s)(char*, size_t, const >> char*, size_t); >>  static unsigned short (__cdecl *p_wctype)(const char*); >>  static MSVCP__Ctypevec (__cdecl *p__Getctype)(void); >> >

Re: gdiplus: Use StretchBlt instead of GdiAlphaBlend if device doesn't support alpha blending.

2012-03-13 Thread Dmitry Timoshkov
Vincent Povirk wrote: > Uh, in many cases this will be worse than a failed draw. wineps and most (if not all) printer drivers do not support blending or any transparency, if you know another way to print images with gdiplus I'm all ears. -- Dmitry.

Re: gdiplus: Use StretchBlt instead of GdiAlphaBlend if device doesn't support alpha blending.

2012-03-13 Thread Vincent Povirk
Uh, in many cases this will be worse than a failed draw.

Re: use assert etc. in Wine dlls? What is better?

2012-03-13 Thread Frédéric Delanoy
On Tue, Mar 13, 2012 at 15:05, wrote: > Hi, > > Maarten's wine-pulse contains several instances of assert() > ... > What is current opinion on this topic? IMO asserts are for (fatal) errors that should never happen, that puts a program into an inconsistent state. Consider them as basic invariant

Re: msvcp90/tests: Don't redefine __thiscall (resend).

2012-03-13 Thread Alexandre Julliard
Nicolas Le Cam writes: > @@ -60,11 +60,13 @@ static char* (__cdecl *p_Copy_s)(char*, size_t, const > char*, size_t); > static unsigned short (__cdecl *p_wctype)(const char*); > static MSVCP__Ctypevec (__cdecl *p__Getctype)(void); > > +#ifndef __thiscall > #ifdef __i386__ > #define __thisca

Re: use assert etc. in Wine dlls? What is better?

2012-03-13 Thread Maarten Lankhorst
Hey, Op 13-03-12 15:05, joerg-cyril.hoe...@t-systems.com schreef: > Hi, > > Maarten's wine-pulse contains several instances of assert() > I've been thinking about adding a bit of protection against > inconcsistencies within mmdevapi code too. > > There are two variants that could be applicable dep

Re: use assert etc. in Wine dlls? What is better?

2012-03-13 Thread Michael Stefaniuc
Hello Joerg, On 03/13/2012 03:05 PM, joerg-cyril.hoe...@t-systems.com wrote: > Maarten's wine-pulse contains several instances of assert() > I've been thinking about adding a bit of protection against > inconcsistencies within mmdevapi code too. > > There are two variants that could be applicable

use assert etc. in Wine dlls? What is better?

2012-03-13 Thread Joerg-Cyril . Hoehle
Hi, Maarten's wine-pulse contains several instances of assert() I've been thinking about adding a bit of protection against inconcsistencies within mmdevapi code too. There are two variants that could be applicable depending on the situation: /* this should not happen, but if we detect it early,

Re: [PATCH] po: Remove bad characters (C2 & A0) from french translations.

2012-03-13 Thread Frédéric Delanoy
On Tue, Mar 13, 2012 at 11:52, Christian Costa wrote: > Never heard of this rule for french or never paid attention but I'm fine > with it if this is so. Actually there should sometimes also be thin non-breakable spaces in po, but those are very badly supported, so are not used here. Some links

Re: [PATCH] po: Remove bad characters (C2 & A0) from french translations.

2012-03-13 Thread Frédéric Delanoy
On Tue, Mar 13, 2012 at 00:42, Christian Costa wrote: > BTW, is there an editor that shows them ? gvim doesn't. Emacs does. > Non-breakable space are only present in french translations. Between a name > and a ':'. Also after/before '«' and '»", as well as before "double" punctuation (;:?!). >

Re: [PATCH] po: Remove bad characters (C2 & A0) from french translations.

2012-03-13 Thread Frédéric Delanoy
On Mon, Mar 12, 2012 at 20:32, Christian Costa wrote: > Le 12/03/2012 21:02, Nikolay Sivov a écrit : > >> On 3/12/2012 21:52, Christian Costa wrote: >>> >>> They are displayed as a single space in a text editor but visible with an >>> hex editor. >> >> I guess this is a non-breakable space. >> >>

Re: [PATCH] po: Remove bad characters (C2 & A0) from french translations.

2012-03-13 Thread Henri Verbeet
On 13 March 2012 00:42, Christian Costa wrote: > BTW, is there an editor that shows them ? gvim doesn't. Assuming gvim is similar enough to normal vim, you can use listchars to highlight various things. Use nbsp for non-breaking spaces. You can use Ctrl+K to insert digraphs. Use "NS" for non-break

Re: Preprocessing asm shaders

2012-03-13 Thread Matteo Bruni
Il 12 marzo 2012 22:13, Józef Kucia ha scritto: > Hi, > > I'm writing because I found a bug in asm shader preprocessor in Wine > and I'm not sure what's the best way to fix it. > > The D3DPreprocess function is an universal shader preprocess for HLSL > and asm shaders. In fact, it's C-like languag

Re: [PATCH] po: Remove bad characters (C2 & A0) from french translations.

2012-03-13 Thread Christian Costa
2012/3/13 Michael Stefaniuc > On 03/13/2012 12:42 AM, Christian Costa wrote: > > Le 12/03/2012 20:32, Christian Costa a écrit : > >> Le 12/03/2012 21:02, Nikolay Sivov a écrit : > >>> On 3/12/2012 21:52, Christian Costa wrote: > They are displayed as a single space in a text editor but visib

Re: What happens upon mmdevapi capture overrun on native?

2012-03-13 Thread Maarten Lankhorst
Hey Joerg, Op 12-03-12 11:01, joerg-cyril.hoe...@t-systems.com schreef: > Hi, > >>> A. mmdevapi fills the whole buffer once. >>> B. mmdevapi continuously overwrites the circular buffer. >>> I think A makes sense but really I don't know. >> I suspect B > I realized that I don't need a microphone if

Re: jscript: Add VT_I2 support

2012-03-13 Thread Jacek Caban
Hi Alistair, On 03/13/12 10:36, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > jscript: Add VT_I2 support static inline BOOL is_num_vt(enum VARENUM vt) { -return vt == VT_I4 || vt == VT_R8; +return vt == VT_I4 || vt == VT_I2 ||vt == VT_R8; } I'm not sure we want this handl

Re: [1/2] msvcrt: Add tmpfile_s implementation (resend)

2012-03-13 Thread Alexandre Julliard
André Hentschel writes: > +int CDECL MSVCRT_tmpfile_s(MSVCRT_FILE** file) > +{ > +if (!file) { > +*MSVCRT__errno() = MSVCRT_EINVAL; > +return MSVCRT_EINVAL; > +} That's not the right way to check parameters in _s functions. -- Alexandre Julliard julli...@winehq.org

Re: mscoree: Better support RUNTIME_INFO_UPGRADE_VERSION in, GetRequestedRuntimeInfo (try 4)

2012-03-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17320 Your paranoid android

Re: Preprocessing asm shaders

2012-03-13 Thread Stefan Dösinger
Am Dienstag, 13. März 2012, 00:52:58 schrieb Józef Kucia: > I'll make some tests to check how wrc and widl should behave. However > I'm not sure if submitting tests for wrc and widl would be welcome. We > don't have any tests for these tools yet and I can imagine not > everyone, who's running the t

Re: [PATCH] po: Remove bad characters (C2 & A0) from french translations.

2012-03-13 Thread Michael Stefaniuc
On 03/13/2012 12:42 AM, Christian Costa wrote: > Le 12/03/2012 20:32, Christian Costa a écrit : >> Le 12/03/2012 21:02, Nikolay Sivov a écrit : >>> On 3/12/2012 21:52, Christian Costa wrote: They are displayed as a single space in a text editor but visible with an hex editor. >>> I guess

Re: mscoree: Better support RUNTIME_INFO_UPGRADE_VERSION in, GetRequestedRuntimeInfo (try 3)

2012-03-13 Thread Alistair Leslie-Hughes
Hi Vincent, On 13/03/2012 3:35 AM, Vincent Povirk wrote: -FIXME("Unrecognized version %s\n", debugstr_w(pwzVersion)); +WARN("Unrecognized version %s\n", debugstr_w(pwzVersion)); I'll put it back and add another test. I'm not so sure about this. I think GetRuntime is still incomplete,