Re: Are we the reason Apple isn't helping us?

2012-03-10 Thread Jerome Leclanche
On Sun, Mar 11, 2012 at 4:33 AM, Charles Davis wrote: > Hi, > > An Apple developer recently contacted me directly about the Wine64 radar > (number 9269783). What's interesting about his response, however, is that > he put in an aside to berate us for our etiquette. I am convinced that at > least t

Re: gdiplus: Create GDI bitmap only when needed.

2012-03-10 Thread Vincent Povirk
Looks good, thanks.

Are we the reason Apple isn't helping us?

2012-03-10 Thread Charles Davis
Hi, An Apple developer recently contacted me directly about the Wine64 radar (number 9269783). What's interesting about his response, however, is that he put in an aside to berate us for our etiquette. I am convinced that at least this developer sees us as rude, hateful creatures now, and he ci

Re: advapi32: Correct tests under WOW64 (try 2)

2012-03-10 Thread Vitaliy Margolen
On 03/10/2012 09:44 AM, André Hentschel wrote: Am 10.03.2012 17:37, schrieb Vitaliy Margolen: On 03/10/2012 12:36 AM, Alistair Leslie-Hughes wrote: Hi, Marked test as broken if it returns true. +/* WoW64 return TRUE with the LastError set */ +ok((!ret&& GetLastError() == ERROR_INSUFFI

Re: My Idea for GSOC

2012-03-10 Thread Stefan Dösinger
Am Samstag, 10. März 2012, 17:22:51 schrieb Daniel Oom: > Hi, > > Writing tests, or implementing the command line tools seems like > something I could do. I'm kinda leaning towards the command line > tools, since it would offer a chance to thoroughly learn the shading > languages. For learning purp

Re: [PATCH 6/6] d3dxof: Do not allow separator to terminate the string. Only the double quote can do that.

2012-03-10 Thread Christian Costa
Le 10/03/2012 19:51, Nicolas Le Cam a écrit : Le 10 mars 2012 17:56, Christian Costa a écrit : Le 09/03/2012 16:11, Nicolas Le Cam a écrit : Le 9 mars 2012 14:22, Christian Costaa écrit : Le 09/03/2012 14:08, Nicolas Le Cam a écrit : Le 9 mars 2012 13:39, Christian Costa a écrit :

Re: windowscodecs: Implement DllCanUnloadNow

2012-03-10 Thread Vincent Povirk
> Um, i thought that all goes through the factory... That is incorrect in this case. Windowscodecs has several exports that create COM objects. Even when they do go through the class factory, the other COM objects can and usually do outlive the factory. > So what do you think, should i go through

Re: [PATCH 6/6] d3dxof: Do not allow separator to terminate the string. Only the double quote can do that.

2012-03-10 Thread Nicolas Le Cam
Le 10 mars 2012 17:56, Christian Costa a écrit : > Le 09/03/2012 16:11, Nicolas Le Cam a écrit : >> >> Le 9 mars 2012 14:22, Christian Costa  a écrit : >>> >>> Le 09/03/2012 14:08, Nicolas Le Cam a écrit : Le 9 mars 2012 13:39, Christian Costa    a écrit : > > Le 08/03/2012

Re: windowscodecs: Implement DllCanUnloadNow

2012-03-10 Thread André Hentschel
Am 10.03.2012 19:01, schrieb Vincent Povirk: > Um, you missed almost much every implementation of a COM interface in > the entire dll? > > 2012/3/10 André Hentschel : >> Needed for dotNet 4.5 preview >> --- >> dlls/windowscodecs/clsfactory.c| 15 +-- >> dlls/windowscodecs/ma

Re: windowscodecs: Implement DllCanUnloadNow

2012-03-10 Thread Vincent Povirk
Um, you missed almost much every implementation of a COM interface in the entire dll? 2012/3/10 André Hentschel : > Needed for dotNet 4.5 preview > --- >  dlls/windowscodecs/clsfactory.c        |   15 +-- >  dlls/windowscodecs/main.c              |    9 + >  dlls/windowscodecs/

Re: [PATCH 6/6] d3dxof: Do not allow separator to terminate the string. Only the double quote can do that.

2012-03-10 Thread Christian Costa
Le 09/03/2012 16:11, Nicolas Le Cam a écrit : Le 9 mars 2012 14:22, Christian Costa a écrit : Le 09/03/2012 14:08, Nicolas Le Cam a écrit : Le 9 mars 2012 13:39, Christian Costaa écrit : Le 08/03/2012 21:23, Alexandre Julliard a écrit : Christian Costa writes: This should fix the

Re: [1/2] kernel32: Forward RtlPcToFileHeader to ntdll also on ARM

2012-03-10 Thread André Hentschel
Am 08.03.2012 22:10, schrieb André Hentschel: > needed by native msvcrt110.dll and msvcrt110d.dll > --- > dlls/kernel32/kernel32.spec |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec > index fb3f9c2..1c794c9 1

Re: advapi32: Correct tests under WOW64 (try 2)

2012-03-10 Thread André Hentschel
Am 10.03.2012 17:37, schrieb Vitaliy Margolen: > On 03/10/2012 12:36 AM, Alistair Leslie-Hughes wrote: >> Hi, >> Marked test as broken if it returns true. >> >> +/* WoW64 return TRUE with the LastError set */ >> +ok((!ret && GetLastError() == ERROR_INSUFFICIENT_BUFFER) || broken(ret), >>

Re: advapi32: Correct tests under WOW64 (try 2)

2012-03-10 Thread Vitaliy Margolen
On 03/10/2012 12:36 AM, Alistair Leslie-Hughes wrote: Hi, Marked test as broken if it returns true. +/* WoW64 return TRUE with the LastError set */ +ok((!ret && GetLastError() == ERROR_INSUFFICIENT_BUFFER) || broken(ret), "%d with error %d\n", ret, GetLastError()); This is inc

Re: NtDelayExecution: reduce multiple stack allocation

2012-03-10 Thread Marcus Meissner
On Sat, Mar 10, 2012 at 04:20:20PM +0100, Ferdinand Nölscher wrote: > In ntdll/sync.c, line 1232 the struct "timeval" is being allocated in a > for-loop. > Would'nt it be faster if tv was created before entering the loop? > I have not tested doing so but I think that it would increase > performance

NtDelayExecution: reduce multiple stack allocation

2012-03-10 Thread Ferdinand Nölscher
In ntdll/sync.c, line 1232 the struct "timeval" is being allocated in a for-loop. Would'nt it be faster if tv was created before entering the loop? I have not tested doing so but I think that it would increase performance a tiny bit. kind regards