Re: gdi32: pOS2->xAvgCharWidth can be negative however tmAvgCharWidth needs a positive value

2012-02-21 Thread Dmitry Timoshkov
Aric Stewart wrote: > > What value does Mac return for these kind of fonts? Does it take an abs() > > like in your patch? Does it trancate the value? Does it calculate it somehow > > (like taking an average of glyphs say a+z and A+Z)? Does it do something > > different? > > > > Why dos it matter

Re: gdi32: pOS2->xAvgCharWidth can be negative however tmAvgCharWidth needs a positive value

2012-02-21 Thread Aric Stewart
On 2/21/12 10:17 AM, Dmitry Timoshkov wrote: Aric Stewart wrote: >>> what Mac does in that case? >> The mac handles the fonts without issue >>>Why do you think that your fix is correct? >>..windows tmAveCharWidth should never be negative, and yet this logic >> causes it to be s

Re: gdi32: pOS2->xAvgCharWidth can be negative however tmAvgCharWidth needs a positive value

2012-02-21 Thread Dmitry Timoshkov
Aric Stewart wrote: > >>> what Mac does in that case? > > >> The mac handles the fonts without issue > > >>>Why do you think that your fix is correct? > > >>..windows tmAveCharWidth should never be negative, and yet this logic > >> causes it to be so for these fonts. If we want to be able

Re: gdi32: pOS2->xAvgCharWidth can be negative however tmAvgCharWidth needs a positive value

2012-02-21 Thread Aric Stewart
On 2/21/12 10:03 AM, Dmitry Timoshkov wrote: Aric Stewart wrote: So, what Mac does in that case? Why do you think that your fix is correct? The mac handles the fonts without issue. The issue appears to be that the windows tmAveCharWidth should never be negative, and yet this logic causes it

Re: gdi32: pOS2->xAvgCharWidth can be negative however tmAvgCharWidth needs a positive value

2012-02-21 Thread Dmitry Timoshkov
Aric Stewart wrote: > > So, what Mac does in that case? Why do you think that your fix is correct? > > > > The mac handles the fonts without issue. The issue appears to be that > the windows tmAveCharWidth should never be negative, and yet this logic > causes it to be so for these fonts. If we

Re: gdi32: pOS2->xAvgCharWidth can be negative however tmAvgCharWidth needs a positive value

2012-02-21 Thread Aric Stewart
On 2/21/12 9:39 AM, Dmitry Timoshkov wrote: Aric Stewart wrote: Windows response appears to not allow the user to install the fonts at all. It reports any of the fonts I have which have negative OS/2 xAveCharWidth as invalid fonts when I try to install them. This blocks out a few of the main

Re: gdi32: pOS2->xAvgCharWidth can be negative however tmAvgCharWidth needs a positive value

2012-02-21 Thread Dmitry Timoshkov
Aric Stewart wrote: > Windows response appears to not allow the user to install the fonts at > all. It reports any of the fonts I have which have negative OS/2 > xAveCharWidth as invalid fonts when I try to install them. > > This blocks out a few of the main Mac UI fonts. > > -aric > > On 2

Re: gdi32: pOS2->xAvgCharWidth can be negative however tmAvgCharWidth needs a positive value

2012-02-21 Thread Aric Stewart
Windows response appears to not allow the user to install the fonts at all. It reports any of the fonts I have which have negative OS/2 xAveCharWidth as invalid fonts when I try to install them. This blocks out a few of the main Mac UI fonts. -aric On 2/20/12 10:49 PM, Dmitry Timoshkov wrote

Re: kernel32/tests: DeviceIoControl: verify IOCTL_DVD_READ_STRUCTURE outputs same buffer as IOCTL_SCSI_PASS_THROUGH_DIRECT f

2012-02-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17047 Your paranoid android

Re: kernel32/tests: DeviceIoControl.IOCTL_DVD_READ_STRUCTURE.DvdPhysicalDescriptor: check output buffer byte order (try 6)

2012-02-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17046 Your paranoid android

[PATCH] mmdevapi: Fix exclusive test.

2012-02-21 Thread Joerg-Cyril . Hoehle
Maarten, what does the patch fix? I did leave nChannels equal to what GetMixFormat returns based on the following reasoning: - It'll probably suggest a mono format on an old machine that handles mono only, so leave as is. - It may suggest 6 channels on a 5:1 card (we had a few such reports on

Re: [2/2] winefile: Get rid of _wsplitpath duplication

2012-02-21 Thread Alexandre Julliard
André Hentschel writes: > @@ -1,10 +1,9 @@ > EXTRADEFS = -D__WINE__ > MODULE= winefile.exe > -APPMODE = -mwindows -municode > +APPMODE = -mwindows -municode -mno-cygwin You can't do that, winefile wants Unix filesystem calls. -- Alexandre Julliard julli...@winehq.org