Re: [1/3] comdlg32: Adjust the size of CHOOSE_COLOR dialog.

2012-02-18 Thread Dmitry Timoshkov
Gustavo Henrique Milaré wrote: > It just occurred to me: did I violate the "Clean Room Guidelines" by using > XN Resource to see that dialog? Not really, that dialog template is a part of PSDK. -- Dmitry.

Re: [1/3] comdlg32: Adjust the size of CHOOSE_COLOR dialog.

2012-02-18 Thread Jerome Leclanche
Yes, but the changes can likely be accepted if they are trivial/obvious. J. Leclanche 2012/2/18 Gustavo Henrique Milaré > It just occurred to me: did I violate the "Clean Room Guidelines" by using > XN Resource to see that dialog? > > If that's the case, my apologies. > > Em 18 de fevereiro de

Re: [1/3] comdlg32: Adjust the size of CHOOSE_COLOR dialog.

2012-02-18 Thread Gustavo Henrique Milaré
It just occurred to me: did I violate the "Clean Room Guidelines" by using XN Resource to see that dialog? If that's the case, my apologies. Em 18 de fevereiro de 2012 14:13, Gustavo Henrique Milaré < gugamil...@gmail.com> escreveu: > > Em 18 de fevereiro de 2012 02:35, Dmitry Timoshkov escreveu

Re: [1/3] comdlg32: Adjust the size of CHOOSE_COLOR dialog.

2012-02-18 Thread Gustavo Henrique Milaré
Em 18 de fevereiro de 2012 02:35, Dmitry Timoshkov escreveu: > Gustavo Henrique Milaré wrote: > > > Windows uses the translation "Vermelho". Comparing Wine's CHOOSE_COLOR > with > > the one in Paint in Windows 7, the position of other widgets were changed > > for the text to fit. Either that or X

Re: [PATCH] quartz: fixed sizeof()s to IsBadReadPtr (Coverity)

2012-02-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17015 Your paranoid android

Re: Removing 'all' platform/os from bugzilla

2012-02-18 Thread Jerome Leclanche
Yes, all and other seem redundant. +1 on removing All. By the way, what happened to merging all the sound components? J. Leclanche On Thu, Feb 16, 2012 at 9:09 PM, Austin English wrote: > Howdy, > > We seem to discourage use of the use of 'all' platform/os on bugzilla. > While I personally am

Re: [1/3] comdlg32: Adjust the size of CHOOSE_COLOR dialog.

2012-02-18 Thread Gustavo Henrique Milaré
Windows uses the translation "Vermelho". Comparing Wine's CHOOSE_COLOR with the one in Paint in Windows 7, the position of other widgets were changed for the text to fit. Either that or XN Resource Editor is lying to me :P The overall dialog seems to be just a bit larger in Windows because there is

Re: kernel32/tests: initial tests for cdrom.c

2012-02-18 Thread Stefan Dösinger
Am Freitag, 17. Februar 2012, 14:45:37 schrieb Joerg-Cyril.Hoehle@t- systems.com: > Francois Gouget asked: > Some tests combinations. I believe Dan's tests want a DVD, whereas > mcicda expects audio CD-ROMs. Either you play disk jockey while > running the tests, or some tests will be skipped. Or