Re: kernel32/tests: initial tests for cdrom.c

2012-02-16 Thread Francois Gouget
On Fri, 10 Feb 2012, joerg-cyril.hoe...@t-systems.com wrote: > Dan Kegel wrote: > >These require a DVD in the drive, so they are skipped without > >WINETEST_INTERACTIVE=1. > I don't see the causality. Presumably the tests require no human intervention. > > winmm/tests/mcicda also skips tests if n

Re: [1/3] comdlg32: Adjust the size of CHOOSE_COLOR dialog.

2012-02-16 Thread Francois Gouget
On Fri, 17 Feb 2012, Dmitry Timoshkov wrote: > Gustavo Henrique Milaré wrote: > > > Adjusting size for the translation to fit. > > You can't do that, read the comment in that file slightly before all > common dialog templates. That comment would deserve some explanation (the b96b3d15 commit m

Re: Translators wanted!

2012-02-16 Thread Francois Gouget
On Fri, 17 Feb 2012, Matijn Woudt wrote: [...] > Francois: The untranslated errors at the consistency are almost all > because of the use of english words in dutch. Would it be OK if I send > you the L numbers that can have # potool-flags=translated so you can > send a patch? Line numbers are unre

Re: Translators wanted!

2012-02-16 Thread Francois Gouget
On Fri, 17 Feb 2012, Sven Baars wrote: > On 16-02-2012 at 7:55 PM, Matijn Woudt wrote: > > I'd like to help get the dutch translation to 100%, but I would need > > to filter out the false positives first. > I started with this a while ago, but every time I was nearly done, more > translations wer

Re: [2/2] kernel32/tests: DeviceIoControl.IOCTL_DVD_READ_STRUCTURE.DvdPhysicalDescriptor: check output buffer byte order (try 4)

2012-02-16 Thread Dan Kegel
On Wed, Feb 15, 2012 at 4:35 PM, Dan Kegel wrote: >> Change since last try: >> - moved back to kernel32 per AJ's remark on irc >> - runs even if dvd in 2nd... drive >> - simplified >> >> Passes on Wine/Linux, Wine/Mac (according to Charles), and Win7. > > Here's the same patch with the wayward utf

Re: [1/3] comdlg32: Adjust the size of CHOOSE_COLOR dialog.

2012-02-16 Thread Dmitry Timoshkov
Gustavo Henrique Milaré wrote: > Adjusting size for the translation to fit. You can't do that, read the comment in that file slightly before all common dialog templates. -- Dmitry.

Re: [PATCH] server: Add sessions directory and 0 session symlink

2012-02-16 Thread Vitaliy Margolen
On 02/16/2012 08:37 PM, Vitaliy Margolen wrote: Fixes bug 29905. --- Please ignore this. Didn't read the last bug comment. Vitaliy.

Re: Problems with translatable strings

2012-02-16 Thread Gustavo Henrique Milaré
Ok, that's good :) I'm editing the resource files to adjust the size of the widgets. I'll send the patches in a minute. Gustavo Em 16 de fevereiro de 2012 20:42, Francois Gouget escreveu: > On Tue, 14 Feb 2012, Gustavo Henrique Milaré wrote: > [...] > > while the string in wine.pot file reads >

Re: Translators wanted!

2012-02-16 Thread Matijn Woudt
On Fri, Feb 17, 2012 at 12:40 AM, Sven Baars wrote: > On 16-02-2012 at 7:55 PM, Matijn Woudt wrote: >> I'd like to help get the dutch translation to 100%, but I would need >> to filter out the false positives first. > I started with this a while ago, but every time I was nearly done, more > trans

Re: Translators wanted!

2012-02-16 Thread Sven Baars
On 16-02-2012 at 7:55 PM, Matijn Woudt wrote: > I'd like to help get the dutch translation to 100%, but I would need > to filter out the false positives first. I started with this a while ago, but every time I was nearly done, more translations were marked as fuzzy, more strings were introduced, a

Re: Problems with translatable strings

2012-02-16 Thread Francois Gouget
On Tue, 14 Feb 2012, Gustavo Henrique Milaré wrote: [...] > while the string in wine.pot file reads > > "Allows you to install new software, or remove existing software from your > computer." Just in case you missed it, this got fixed: http://bugs.winehq.org/show_bug.cgi?id=27246 -- Francois G

Re: Translators wanted!

2012-02-16 Thread Francois Gouget
On Thu, 16 Feb 2012, Matijn Woudt wrote: [...] > 1) It says there are 39 todo, is it possible to show which ones still > need to be done? Look for 'fuzzy' in the PO file. > 2) Most of the consistency errors are false positives (whe use quite a > lot english words), is it possible to mark them as

Removing 'all' platform/os from bugzilla

2012-02-16 Thread Austin English
Howdy, We seem to discourage use of the use of 'all' platform/os on bugzilla. While I personally am not opposed to it, in cases where it's obviously true (e.g., http://bugs.winehq.org/show_bug.cgi?id=29901), changing these fields causes unnecessary spam. It would be easier, imho to remove them. D

Re: wineapploader in wine64

2012-02-16 Thread Alexandre Julliard
Michael Ost writes: > On 02/16/2012 11:57 AM, Alexandre Julliard wrote: >> prefix (besides, there shouldn't be any reason to run wineboot by hand). > > We use it with --shutdown to cleanly terminate (as in WM_CLOSE, not > "kill") all wine apps from a hardware button press. Is there a > preferred

re: "Known" DLLs

2012-02-16 Thread Dan Kegel
This has been discussed off and on over the years, e.g. http://www.winehq.org/pipermail/wine-devel/2009-September/078441.html http://www.winehq.org/pipermail/wine-devel/2010-September/086465.html http://www.winehq.org/pipermail/wine-devel/2010-September/086469.html There is a kind of notification

Re: wineapploader in wine64

2012-02-16 Thread Michael Ost
On 02/16/2012 11:57 AM, Alexandre Julliard wrote: prefix (besides, there shouldn't be any reason to run wineboot by hand). We use it with --shutdown to cleanly terminate (as in WM_CLOSE, not "kill") all wine apps from a hardware button press. Is there a preferred way? Thanks! -- Michael Os

Re: wineapploader in wine64

2012-02-16 Thread Austin English
On Thu, Feb 16, 2012 at 14:21, Vincent Pelletier wrote: > Le jeudi 16 février 2012 20:57:10, Alexandre Julliard a écrit : >> (besides, there shouldn't be any reason to run wineboot by hand). > > FWIW, on wine (32bits) I use "wineboot -ks" to get rid of a crashing app > (stuck eating cpu, or just w

Re: wineapploader in wine64

2012-02-16 Thread Vincent Pelletier
Le jeudi 16 février 2012 20:57:10, Alexandre Julliard a écrit : > (besides, there shouldn't be any reason to run wineboot by hand). FWIW, on wine (32bits) I use "wineboot -ks" to get rid of a crashing app (stuck eating cpu, or just willing to stay). -- Vincent Pelletier

Re: wineapploader in wine64

2012-02-16 Thread Alexandre Julliard
Michael Ost writes: > In Fedora 15 with wine 1.3.24, the upshot is that the 'wineboot' > command doesn't work. /usr/lib/wine/wineboot.exe.so is not installed; > only /usr/lib64/wineboot.exe.so is. > > Since the /usr/bin/wineboot is running 'wine' instead of 'wine64' it > is looking for the 32bit

wineapploader in wine64

2012-02-16 Thread Michael Ost
Hi, Any explanation for why the wineapploader script doesn't use 'wine64' instead of 'wine' in a 64bit Linux with 64bit wine? That's the script that is used to build /usr/bin/wineboot and /usr/bin/regedit, for instance. In Fedora 15 with wine 1.3.24, the upshot is that the 'wineboot' command

Re: Translators wanted!

2012-02-16 Thread Alexandre Julliard
Qian Hong writes: > I would like to help to update the Simplified Chinese translation, but > most likely I have no enouth time to complete it before wine-1.4 final > release. > Could anyone give a deadline? Seeing how things are progressing, we are probably about two weeks from final release. Th

Re: Translators wanted!

2012-02-16 Thread Matijn Woudt
On Thu, Feb 16, 2012 at 7:13 PM, Francois Gouget wrote: >> Wine 1.4 is making good progress. Unfortunately we still have a lot of >> translations that are quite incomplete and have no active translators, >> thus making Wine unusable in many countries. You track progress on >> this page: >> >>    

Re: "Known" DLLs

2012-02-16 Thread Adam Kłobukowski
W dniu 16.02.2012 19:34, Stefan Dösinger pisze: Am Donnerstag, 16. Februar 2012, 18:45:37 schrieb Adam Kłobukowski: Therefore, it could be usefull if Wine would be able to detect when a program tries to use a DLL that is not implememnted, but is easily available for download. .NET, MSXML, VCRUN*

Re: "Known" DLLs

2012-02-16 Thread Stefan Dösinger
Am Donnerstag, 16. Februar 2012, 18:45:37 schrieb Adam Kłobukowski: > Therefore, it could be usefull > if Wine would be able to detect when a program tries to use a DLL that > is not implememnted, but is easily available for download. .NET, MSXML, > VCRUN* comes in mind. Instead of just failing, Wi

Re: Translators wanted!

2012-02-16 Thread Qian Hong
Hello, On Fri, Feb 17, 2012 at 2:13 AM, Francois Gouget wrote: > > I feel that we should put out a call for translators to the wider > community. In preparation for that I updated the Wiki's Translating page > and added a winepo script to help translators who don't want to check > out the whole W

Re: msxml3: Fix varargs handling in libxml2 error callback implementation

2012-02-16 Thread David Laight
On Thu, Feb 16, 2012 at 03:15:59AM +0300, Nikolay Sivov wrote: > >If I remember correctly, you can even process a va_list only once > >on some platforms. > We use it that way in couple of places, so it seems to work and I can't > find a proper description or part of a standard that says it's not p

Translators wanted!

2012-02-16 Thread Francois Gouget
I feel that we should put out a call for translators to the wider community. In preparation for that I updated the Wiki's Translating page and added a winepo script to help translators who don't want to check out the whole Wine source: http://wiki.winehq.org/Translating Here's the propos

"Known" DLLs

2012-02-16 Thread Adam Kłobukowski
Hello I've been a Wine user for a long time alreadey, since all Wine could do was running winesweper very slowly ;) I'd like to propose a feature that could be implemented in Wine. Wine does not implement all Windows APIs (yet ;)) and big parts of existing implementations are only stubs. The

Re: gdi32: Make output of dumping GDI objects more compact.

2012-02-16 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > As a person, who have debugged and fixed quite a bit of GDI handle leaks, > > and > > who actually have introduced that facility in the first place, I can say, > > that > > an ability to see each line of GDI handle table prefixed with > > 'dump_gdi_objects:', > >

Re: gdi32: Make output of dumping GDI objects more compact.

2012-02-16 Thread Alexandre Julliard
Dmitry Timoshkov writes: > As a person, who have debugged and fixed quite a bit of GDI handle leaks, and > who actually have introduced that facility in the first place, I can say, that > an ability to see each line of GDI handle table prefixed with > 'dump_gdi_objects:', > thread id, or whateve

Re: gdi32: Make output of dumping GDI objects more compact.

2012-02-16 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > Is it OK to add a prefix manually to the MESSAGE calls? > > No, that wouldn't handle +tid and the like. As a person, who have debugged and fixed quite a bit of GDI handle leaks, and who actually have introduced that facility in the first place, I can say, that an a

Re: [1/2] msxml3: Use static buffer when tracing libxml2 error messages

2012-02-16 Thread Alexandre Julliard
Nikolay Sivov writes: > Use static buffer when tracing libxml2 error messages I don't think it's necessary to rename all the functions. Please keep patches small, especially during code freeze. -- Alexandre Julliard julli...@winehq.org

Re: po: Add and fix a few Finnish translations.

2012-02-16 Thread Francois Gouget
On Thu, 16 Feb 2012, Lauri Kenttä wrote: > "Thai" is right, "Thain" is wrong. Sorry. I mistook 'Thai' as refering to the Thai language where in this case it actually refers to the Thai script. > Please don't mess with Finnish if you don't know it. As I've said, I'm > working on it. If you fee

re: How program are Loaded to wine

2012-02-16 Thread Dan Kegel
Have you read the documentation, e.g. http://www.winehq.org/docs/winedev-guide/architecture ? Have you tried stepping through the source of CreateProcess by hand? http://source.winehq.org/source/dlls/kernel32/process.c#L2389 If you need more background, I hear "Windows Internals" is useful, http:

Re: winmm: Allow new sounds to interrupt previous PlaySound invocations.

2012-02-16 Thread Andrew Eikum
On Thu, Feb 16, 2012 at 10:10:09AM +0100, joerg-cyril.hoe...@t-systems.com wrote: > Hi, > > this fixes bug #28413. > Thanks Jörg, looks sane to me and I can confirm it fixes the problem. Andrew

Re: advapi32/tests: Marked some tests that fail on Wine as todo_wine.

2012-02-16 Thread Johan Gill
Now I ran the tests on another Linux system with wine, and there the failing tests are skipped, so it seems I did not fully understand what's going on here and why the tests are run on my system.

Re: gdi32: Make output of dumping GDI objects more compact.

2012-02-16 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Is it OK to add a prefix manually to the MESSAGE calls? No, that wouldn't handle +tid and the like. -- Alexandre Julliard julli...@winehq.org

Re: msxml3: Fix varargs handling in libxml2 error callback implementation

2012-02-16 Thread Alexandre Julliard
Nikolay Sivov writes: > The problem is that vsnprintf() was called multiple times with same > va_list. Ti fix that it was necessary to get rid of some tracing bits > like macro-defined callback calls and a single function for all kinds > of error types. Actually there's no need to call vsnprintf

Re: gdi32: Make output of dumping GDI objects more compact.

2012-02-16 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > In general, these are because they don't print full lines. If they do, > they should be fixed. All traces should have a trace prefix. Is it OK to add a prefix manually to the MESSAGE calls? -- Dmitry.

Re: gdi32: Make output of dumping GDI objects more compact.

2012-02-16 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> Traces without prefixes are confusing when they are interleaved with >> other things. > > This dump is being printed only in the emergency case, so, this is not really > a "trace". Besides there are other places in Wine which use the same

Re: gdi32: Make output of dumping GDI objects more compact.

2012-02-16 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > Traces without prefixes are confusing when they are interleaved with > other things. This dump is being printed only in the emergency case, so, this is not really a "trace". Besides there are other places in Wine which use the same style: 'if (TRACE_ON()) MESSAGE();',

Re: gdi32: Make output of dumping GDI objects more compact.

2012-02-16 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Dmitry Timoshkov wrote: > >> --- >> dlls/gdi32/gdiobj.c |6 -- >> 1 files changed, 4 insertions(+), 2 deletions(-) > > What's the reason for the 'rejected' status? Traces without prefixes are confusing when they are interleaved with other things. -- Alexand

Re: comctl32: Fix TB_SETEXTENDEDSTYLE to use mask passed in wParam

2012-02-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16982 Your paranoid android