Re: user32: Only call SetWindowPos() in UpdateLayeredWindowIndirect() if needed. (try 4)

2012-02-05 Thread Adam Martinson
On 02/05/2012 09:46 PM, Dmitry Timoshkov wrote: Adam Martinson wrote: (We should not be calling SetWindowPos() in UpdateLayeredWindowIndirect() at all.) Fixes bug 26924. That's not what I was asking about (a bunch of message tests with various parameters). Your current version essentially te

Re: user32: Only call SetWindowPos() in UpdateLayeredWindowIndirect() if needed. (try 4)

2012-02-05 Thread Dmitry Timoshkov
Adam Martinson wrote: > (We should not be calling SetWindowPos() in UpdateLayeredWindowIndirect() at > all.) > Fixes bug 26924. That's not what I was asking about (a bunch of message tests with various parameters). Your current version essentially tests nothing. You should call UpdateLayeredWi

Re: [PATCH] [Kernel32]: added a couple of tests about console creation through CreateFile, and fix some corner cases

2012-02-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16816 Your paranoid android

Skype support status

2012-02-05 Thread Artem S. Tashkinov
Hello everyone, It's not a secret that Skype was bought by Microsoft a few months back and that there's a great chance that its native Linux version will get even fewer updates in the future because I doubt that Microsoft is even remotely endorse the existence of Linux and open source, thus Skyp

Re: ntdll: Remove dead code

2012-02-05 Thread Marcus Meissner
On Sun, Feb 05, 2012 at 03:59:44PM +0100, André Hentschel wrote: > --- > dlls/ntdll/signal_x86_64.c |4 > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/dlls/ntdll/signal_x86_64.c b/dlls/ntdll/signal_x86_64.c > index 0fc53c7..e9cefb8 100644 > --- a/dlls/ntdll/signal_x8

Re: kernel32: Add LCMapStringEx implementation and test it reusing tests from LCMapStringW (try 2)

2012-02-05 Thread Dmitry Timoshkov
André Hentschel wrote: > +@ stdcall LCMapStringEx(long long wstr long ptr long ptr ptr long) ... > +INT WINAPI LCMapStringEx(LPCWSTR name, DWORD flags, LPCWSTR src, INT srclen, > LPWSTR dst, INT dstlen, > + LPNLSVERSIONINFO version, LPVOID reserved, LPARAM > lparam) .sp

Re: kernel32: Add LCMapStringEx implementation and test it reusing tests from LCMapStringW

2012-02-05 Thread Dmitry Timoshkov
André Hentschel wrote: > > Also just duplicating LCMapString tests is not a very good idea, it would be > > better to find a way to share the test data. > > that's not that easy as the parameter count is different, i would need to use > macros and i dislike that idea. Since you are forwarding

Re: kernel32: Add LCMapStringEx implementation and test it reusing tests from LCMapStringW

2012-02-05 Thread André Hentschel
Am 30.01.2012 06:16, schrieb Dmitry Timoshkov: > André Hentschel wrote: > >> +/* Locale name special values */ >> +#define LOCALE_NAME_INVARIANT L"" >> +#define LOCALE_NAME_MAX_LENGTH 85 >> +#define LOCALE_NAME_SYSTEM_DEFAULT L"!sys-default-locale" >> +#define LOCALE_NAME_USER_DEFAULT