Re: user32: Only call SetWindowPos() in UpdateLayeredWindowIndirect() if needed. (try 3)

2012-02-03 Thread Dmitry Timoshkov
Adam Martinson wrote: > +static HDC (WINAPI *pGetWindowDC)(HWND hWnd); > +static int (WINAPI *pReleaseDC)(HWND hWnd,HDC hDC); There is no need to dynamically import these APIs, they are always available. > +static DWORD WINAPI test_ulw_thread(void *data) > +{ > +struct test_ulw_tdata *tdata

Re: Wine automated testing update

2012-02-03 Thread Charles Davis
On Feb 3, 2012, at 10:13 AM, Jeremy White wrote: > On 02/03/2012 10:47 AM, Dan Kegel wrote: >> Jeremy wrote: >>> the VMWare folks are not willing to provide a permanent license for VMWare >>> to us. >>> >>> So, we've shifted gears, and are exploring whether something like qemu + >>> kvm would b

Re: Wine automated testing update

2012-02-03 Thread Erich E. Hoover
On Wed, Feb 1, 2012 at 1:11 PM, Jeremy White wrote: > Hi Folks, > > At the last Wine conference, I volunteered to find a home for the > WineTestBot that Ge's brother has been hosting, and to take over the > Buildbot that Dan and Austin have been so diligently maintaining. > ... Is there any chanc

Re: Wine automated testing update

2012-02-03 Thread Jeremy White
On 02/03/2012 10:47 AM, Dan Kegel wrote: > Jeremy wrote: >> the VMWare folks are not willing to provide a permanent license for VMWare >> to us. >> >> So, we've shifted gears, and are exploring whether something like qemu + >> kvm would be a sufficient alternate. > > What's the plan for automated

Re: [2/3] msi: Use the return value of IXMLDOMNode_get_text (clang).

2012-02-03 Thread Juan Lang
Hi Hans, hr = IXMLDOMNode_get_text( node, &s ); IXMLDOMNode_Release( node ); -if (!strcmpW( s, product_code )) r = ERROR_SUCCESS; -SysFreeString(s); +if (hr == S_OK && !strcmpW( s, product_code )) r = ERROR_SUCCESS; +SysFreeString( s ); Is it real

re: Wine automated testing update

2012-02-03 Thread Dan Kegel
Jeremy wrote: > the VMWare folks are not willing to provide a permanent license for VMWare to > us. > > So, we've shifted gears, and are exploring whether something like qemu + > kvm would be a sufficient alternate. What's the plan for automated MacOSX testing? I hear 10.7 supports running in a

Re: quartz: AMFilterData_ParseFilterData returns a pointer to a pointer to filter data

2012-02-03 Thread Aric Stewart
Yeah, I agree there is something odd happening with this function. It clearly wants a pointer to a pointer, and then graphedit and all the sample code I see online frees the inner pointer but never the outer pointer. So I cannot alloc that outer pointer of we get a leak. It does not help t

Re: quartz: AMFilterData_ParseFilterData returns a pointer to a pointer to filter data

2012-02-03 Thread Chris Robinson
On Friday, February 03, 2012 2:43:57 PM Dmitry Timoshkov wrote: > Aric Stewart wrote: > > -REGFILTER2 *prf2; > > +static REGFILTER2 *prf2; > > What's the point of this change? It returns a pointer to the pointer, so the variable needs to remain valid after the function exits. The code d