Re: [PATCH 2/3] winecoreaudio: Implement the lock-free callback design.

2012-01-31 Thread Peter Rosin
joerg-cyril.hoe...@t-systems.com skrev 2012-01-31 15:23: > Peter Rosin wrote: >>> Of the same vein, one liners like >>> EnterCS >>> This-> playing = StateStopped; >>> LeaveCS >>> are suspicious too. What does that guarantee? >> Perhaps that another thread doing as below isn't fooled into >> callin

Re: Profiing windows apps

2012-01-31 Thread Ralph Little
Hi Stefan, I did put together a test for this and DirectX does indeed return DDERR_INVALIDPARMS. Here is a snippet that encapsulates what I tried: IDirectDraw * pDD = NULL; IDirectDrawSurface * pDDSPrimary = NULL; DDSURFACEDESC ddsd; .. memset(&ddsd, 0, sizeof(dds

Re: Profiing windows apps

2012-01-31 Thread Stefan Dösinger
Am Dienstag, 31. Januar 2012, 17:29:23 schrieb Ralph Little: > Hi, > I'm looking at bug #9672 again in the The Sims. > The app crashes early on during initialisation in DirectDraw. The problem > occurs after CreateSurface returns an error, since it would appear that the > DDSURFACEDESC passed into

Re: quartz: If the MediaSeeking is not implemented all the way up the passthru chain fall back to the filtergraph's clock to find position.

2012-01-31 Thread Aric Stewart
ahh ok, i see what the problem is. Thanks -aric On 1/31/12 1:45 PM, Alexandre Julliard wrote: Aric Stewart writes: Resolves bug Bug 25606 --- dlls/quartz/filtergraph.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M

Re: quartz: If the MediaSeeking is not implemented all the way up the passthru chain fall back to the filtergraph's clock to find position.

2012-01-31 Thread Alexandre Julliard
Aric Stewart writes: > Resolves bug Bug 25606 > --- > dlls/quartz/filtergraph.c |6 +- > 1 files changed, 5 insertions(+), 1 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M quartz.dll -T ../../.. -p quartz_test.exe.so filtergraph.c && touch filtergraph.ok wine: Unha

Re: crypt32: Only accept trailing NULLs in a certificate common name.

2012-01-31 Thread Juan Lang
> Wow, I clearly didn't read that you moved the code over to > match_common_name.  Apparently I'm not quite conscious today, my > apologies! Clearly I wasn't quite conscious when I reviewed your patch in the first place :) No worries, for security fixes lots of checking is always worthwhile! --Ju

Re: crypt32: Only accept trailing NULLs in a certificate common name.

2012-01-31 Thread Erich E. Hoover
On Tue, Jan 31, 2012 at 11:10 AM, Juan Lang wrote: > ... > Well, sort of.  The byte-by-byte comparison takes place component by > component.  The boundary between each component is defined by the > presence of a '.'.  That's why, in my example, I have an embedded NULL > immediately prior to a '.'.

Re: crypt32: Only accept trailing NULLs in a certificate common name.

2012-01-31 Thread Juan Lang
Hi Erich, On Tue, Jan 31, 2012 at 9:34 AM, Erich E. Hoover wrote: > On Tue, Jan 31, 2012 at 10:23 AM, Erich E. Hoover wrote: >> On Tue, Jan 31, 2012 at 10:04 AM, Juan Lang wrote: >>> Sorry I didn't spot this earlier.  Without this, someone who registers >>> a certificate common name with an emb

Re: Profiing windows apps

2012-01-31 Thread Dmitry Timoshkov
Ralph Little wrote: > Does anyone have any experience with tracing apps in real Windows in the > context of Wine development? > > Should I use a profiler or is there a simpler method? Try logger.exe from Debugging Tools For Windows. -- Dmitry.

Re: crypt32: Only accept trailing NULLs in a certificate common name.

2012-01-31 Thread Erich E. Hoover
On Tue, Jan 31, 2012 at 10:23 AM, Erich E. Hoover wrote: > On Tue, Jan 31, 2012 at 10:04 AM, Juan Lang wrote: >> Sorry I didn't spot this earlier.  Without this, someone who registers >> a certificate common name with an embedded NULL, like >> "codeweavers.com\0.badguy", could fool crypt32 into a

Profiing windows apps

2012-01-31 Thread Ralph Little
Hi, I'm looking at bug #9672 again in the The Sims. The app crashes early on during initialisation in DirectDraw. The problem occurs after CreateSurface returns an error, since it would appear that the DDSURFACEDESC passed into the call is foobar. This would lead me to conclude that something on

Re: [PATCH 2/3] winecoreaudio: Implement the lock-free callback design.

2012-01-31 Thread Joerg-Cyril . Hoehle
Peter Rosin wrote: >> Of the same vein, one liners like >> EnterCS >> This-> playing = StateStopped; >> LeaveCS >> are suspicious too. What does that guarantee? >Perhaps that another thread doing as below isn't fooled into >calling both one() and three()? Right. The next question is: What does tha

Re: Updated clang-static-analyzer results (just in time for 1.4 ;))

2012-01-31 Thread Jacek Caban
Hi Austin, On 01/31/12 06:11, Austin English wrote: > Enjoy: http://www.mediafire.com/?aiomfk1cr9bc61y > Using: > wine-1.4-rc1-34-g01947e0 > > LLVM commit 683d1e1d449e6e790ff4c0b6340a4bbf144ff919 / git-svn-id: > http://llvm.org/svn/llvm-project/llvm/trunk@149340 > 91177308-0d34-0410-b5e6-96231b3b8

Re: Warning report for wine-1.4-rc1

2012-01-31 Thread Jerome Leclanche
Yes, i build with translations disabled. J. Leclanche On Tue, Jan 31, 2012 at 1:01 PM, Henri Verbeet wrote: > On 31 January 2012 13:41, Jerome Leclanche wrote: > > ../../../tools/wrc/po.c:127:12: warning: ‘string_has_context’ defined but > > not used [-Wunused-function] > > > http://source.wi

Re: Warning report for wine-1.4-rc1

2012-01-31 Thread Henri Verbeet
On 31 January 2012 13:41, Jerome Leclanche wrote: > ../../../tools/wrc/po.c:127:12: warning: ‘string_has_context’ defined but > not used [-Wunused-function] > http://source.winehq.org/patches/data/83335 should fix that, but this also means you're building without libgettextpo.

Re: [PATCH 2/4] ddraw/tests: Add an IDirect3DTexture::Load color key test

2012-01-31 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16745 Your paranoid android

Re: [PATCH 3/4] ddraw/tests: Add an IDirect3DTexture2::Load color key test

2012-01-31 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16746 Your paranoid android

Warning report for wine-1.4-rc1

2012-01-31 Thread Jerome Leclanche
Some new warnings. Inlining it instead of attaching it this time, I hope that's ok. == 32-bit == ccache gcc -msse4 -O3 -Wall -m32 -c -I../../../tools/wrc -I. -I../../../include -I../../include -D__WINESRC__ -DINCLUDEDIR="\"/usr/include/wine\"" -Wall -pipe -fno-strict-aliasing -

Re: [PATCH 2/2] urlmon: Properly handle relative URIs with specified host in combine_uri

2012-01-31 Thread Jacek Caban
On 01/31/12 10:42, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/

Re: [PATCH 2/2] urlmon: Properly handle relative URIs with specified host in combine_uri

2012-01-31 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16738 Your paranoid android