Re: shell32: Use simple helper for case insensitive strstr()

2012-01-25 Thread Nikolay Sivov
On 1/25/2012 13:36, Alexandre Julliard wrote: Nikolay Sivov writes: Fix for http://bugs.winehq.org/show_bug.cgi?id=28087 You shouldn't need anything of the kind. If StrStrIW doesn't work right it should be fixed (plus of course there's no reason to even use strstr() here at all). When I debug

Re: [2/2] scrrun: Register Scripting interfaces

2012-01-25 Thread Alistair Leslie-Hughes
On 26/01/2012 1:03 AM, Nikolay Sivov wrote: On 1/25/2012 15:21, Jacek Caban wrote: That's what I meant, it should be implemented in one place, after that you probably won't need duplicated *.idls. Where would such a file live? Best Regards Alistair Leslie-Hughes

Re: po: Remove extraneous full stops from the Japanese translation.

2012-01-25 Thread Francois Gouget
On Wed, 25 Jan 2012, Alexandre Julliard wrote: > Francois Gouget writes: > > > You were right on both points: > > 1) All these error messages have a trailing full stop in English, > > French and Japanese. > > 2) They also tend to be much more verbose than Wine's messages and > > usua

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

2012-01-25 Thread Stefan Dösinger
Am 25.01.2012 14:40 schrieb "Andrew Eikum" : > What about > changing them to WARN so that they don't print to the console by > default? Everyone knows there are workarounds, but is anyone really > gaining anything by having these flood the console? I agree with this sentiment, althougj Henri's poin

Re: ieframe: Fixed a typo in IDocObjectService::FireNavigateComplete2

2012-01-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16644 Your paranoid android

Re: po: Remove extraneous full stops from the Japanese translation.

2012-01-25 Thread Alexandre Julliard
Francois Gouget writes: > You were right on both points: > 1) All these error messages have a trailing full stop in English, > French and Japanese. > 2) They also tend to be much more verbose than Wine's messages and > usually form a proper sentence. > > I'm not going to fix point 2.

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

2012-01-25 Thread Andrew Eikum
On Wed, Jan 25, 2012 at 02:03:04PM +0100, Henri Verbeet wrote: > The code looks like it would do what was intended to me. The problem I > have with it, and I'm pretty sure I've mentioned this before, is that > reducing debug output shouldn't be a goal on its own. If you're a > user, and the message

Re: [2/2] scrrun: Register Scripting interfaces

2012-01-25 Thread Nikolay Sivov
On 1/25/2012 15:21, Jacek Caban wrote: On 01/25/12 11:59, Nikolay Sivov wrote: On 1/25/2012 12:35, Alistair Leslie-Hughes wrote: Hi, Changelog: scrrun: Register Scripting interfaces Some of this are already used in wshom.ocx, I'm not sure which one should take precedence and implement t

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

2012-01-25 Thread Henri Verbeet
On 25 January 2012 01:25, Francois Gouget wrote: > I don't pretend to know what Henry meant but reported_once is not > initialized. It's probably put into a zero-initialized section by the > compiler but it looks worrying to me (I believe something like this has > been debated on the Linux kernel

Re: [2/2] scrrun: Register Scripting interfaces

2012-01-25 Thread Jacek Caban
On 01/25/12 11:59, Nikolay Sivov wrote: > On 1/25/2012 12:35, Alistair Leslie-Hughes wrote: >> Hi, >> >> >> Changelog: >> scrrun: Register Scripting interfaces > Some of this are already used in wshom.ocx, I'm not sure which one > should take precedence and implement that. Probably it changed i

Re: [2/2] scrrun: Register Scripting interfaces

2012-01-25 Thread Alistair Leslie-Hughes
Hi, On 25/01/2012 9:59 PM, Nikolay Sivov wrote: On 1/25/2012 12:35, Alistair Leslie-Hughes wrote: Hi, Changelog: scrrun: Register Scripting interfaces Some of this are already used in wshom.ocx, I'm not sure which one should take precedence and implement that. Probably it changed in recent W

Re: po: Remove extraneous full stops from the Japanese translation.

2012-01-25 Thread Francois Gouget
On Wed, 25 Jan 2012, Akihiro Sagawa wrote: [...] > IMHO, the error message should be well-formed sentences. I confused a > lot while translating because some messages are not sentence style. For > such a reason, I translated the message into Japanese sentence. So > full-stops are reasonable. You w

Re: [2/2] scrrun: Register Scripting interfaces

2012-01-25 Thread Alistair Leslie-Hughes
Hi, On 25/01/2012 9:59 PM, Nikolay Sivov wrote: On 1/25/2012 12:35, Alistair Leslie-Hughes wrote: Hi, Changelog: scrrun: Register Scripting interfaces Some of this are already used in wshom.ocx, I'm not sure which one should take precedence and implement that. Probably it changed in recent W

Re: shell32: Use simple helper for case insensitive strstr()

2012-01-25 Thread Alexandre Julliard
Nikolay Sivov writes: > Fix for http://bugs.winehq.org/show_bug.cgi?id=28087 You shouldn't need anything of the kind. If StrStrIW doesn't work right it should be fixed (plus of course there's no reason to even use strstr() here at all). -- Alexandre Julliard julli...@winehq.org

Re: [2/2] scrrun: Register Scripting interfaces

2012-01-25 Thread Nikolay Sivov
On 1/25/2012 12:35, Alistair Leslie-Hughes wrote: Hi, Changelog: scrrun: Register Scripting interfaces Some of this are already used in wshom.ocx, I'm not sure which one should take precedence and implement that. Probably it changed in recent Windows versions?

Re: Resource accelerators discrepancies

2012-01-25 Thread Alexandre Julliard
Frédéric Delanoy writes: > After your addition of accelerators to po file for winefile (among > others) [fe021a44 winefile: Add message contexts for accelerators that > can be translated], there seems to be some discrepancies: No, but you need to look up the resource definition to see all the fl

Resource accelerators discrepancies

2012-01-25 Thread Frédéric Delanoy
Hi Alexandre, After your addition of accelerators to po file for winefile (among others) [fe021a44 winefile: Add message contexts for accelerators that can be translated], there seems to be some discrepancies: #: winefile.rc:202 msgctxt "accelerator Fullscreen" msgid "^S" vs #: winefile.rc:70 m

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

2012-01-25 Thread Nicolas Le Cam
2012/1/25 Nicolas Le Cam : > 2012/1/25 Francois Gouget : >> On Wed, 25 Jan 2012, Detlef Riekenberg wrote: >> >>> On Sun, 2012-01-22 at 19:53 +0100, Henri Verbeet wrote: >>> > On 22 January 2012 19:44, Detlef Riekenberg wrote: >>> > > -    if (usage & ~handled) >>> > > +    static DWORD reported_on