Re: Rethinking WineConf

2012-01-09 Thread Shachar Shemesh
On 01/09/2012 08:31 PM, Jeremy White wrote: > Hi All, > > > If you've been to a technical conference recently that you thought was > well done, what did they do well? Anything we could emulate? I've gave you some of this feedback in person at WineConf in France. First, as long as it is aimed at W

Re: [PATCH] programs/explorer: Fix explorer's command line parsing (try 2)

2012-01-09 Thread Vitaliy Margolen
On 01/09/2012 08:34 AM, Jay Yang wrote: On 01/09/2012 09:46 AM, Vitaliy Margolen wrote: On 01/08/2012 08:45 PM, Jay Yang wrote: Some other issues - you will parse over parameters given to the program. Ex: explorer /desktop=foo,800x600 program.exe /n /e the "/desktop" command causes a the p

Re: [4/5] dinput: Device username being assigned at creation time (try 2)

2012-01-09 Thread Vitaliy Margolen
On 01/09/2012 10:18 AM, Lucas Fialho Zawacki wrote: From: Lucas Fialho Zawacki You leaking FindFile handle. Need to use FindClose() to close it. This is on top of more unchecked returns from HappAlloc. Vitaliy.

Re: [3/5] dinput: SetActionMap setting username

2012-01-09 Thread Vitaliy Margolen
On 01/09/2012 10:18 AM, Lucas Fialho Zawacki wrote: From: Lucas Fialho Zawacki +/* Set username in device */ +HeapFree(GetProcessHeap(), 0, This->username); +This->username = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR) * (lstrlenW(username) + 1)); +lstrcpyW(This->username, user

Re: [2/5] dinput: SetActionMap saving simple configurations to an .ini file (try 2)

2012-01-09 Thread Vitaliy Margolen
On 01/09/2012 10:18 AM, Lucas Fialho Zawacki wrote: From: Lucas Fialho Zawacki +static BOOL _write_private_profile_intW(const char *format, WCHAR* section, WCHAR* key, int value, WCHAR* file) I don't think this is such a good idea to mix ASCII and WCHAR parameters. +static WCHAR path[] =

UTF-7

2012-01-09 Thread Alex Henrie
Hello, I have been thinking about implementing UTF-7 support in MultiByteToWideChar and WideCharToMultiByte. The guts of the code that needs to be added have already been posted to bug 27388. What more needs to be done? Should a libs/wine/utf7.c file be created for the new functions, similar to li

Re: [1/5] dinput: Added DI_SETTINGSNOTSAVED flag

2012-01-09 Thread Francois Gouget
On Mon, 9 Jan 2012, Lucas Fialho Zawacki wrote: > From: Lucas Fialho Zawacki > > --- > include/dinput.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/dinput.h b/include/dinput.h > index 353ec55..cf99ecc 100644 > --- a/include/dinput.h > +++ b/include/din

Re: [6/6] d3drm: Implement GetParent

2012-01-09 Thread André Hentschel
Am 09.01.2012 22:33, schrieb Michael Stefaniuc: > On 01/09/2012 09:42 PM, André Hentschel wrote: >> Am 08.01.2012 20:02, schrieb Nikolay Sivov: >>> On 1/8/2012 20:47, André Hentschel wrote: --- dlls/d3drm/frame.c | 11 +++ dlls/d3drm/tests/d3drm.c | 16 --

Re: [6/6] d3drm: Implement GetParent

2012-01-09 Thread Michael Stefaniuc
On 01/09/2012 09:42 PM, André Hentschel wrote: > Am 08.01.2012 20:02, schrieb Nikolay Sivov: >> On 1/8/2012 20:47, André Hentschel wrote: >>> --- >>> dlls/d3drm/frame.c | 11 +++ >>> dlls/d3drm/tests/d3drm.c | 16 >>> 2 files changed, 15 insertions(+), 12 dele

Re: [6/6] d3drm: Implement GetParent

2012-01-09 Thread Nikolay Sivov
On 1/9/2012 23:42, André Hentschel wrote: Am 08.01.2012 20:02, schrieb Nikolay Sivov: On 1/8/2012 20:47, André Hentschel wrote: --- dlls/d3drm/frame.c | 11 +++ dlls/d3drm/tests/d3drm.c | 16 2 files changed, 15 insertions(+), 12 deletions(-) diff --gi

Re: [6/6] d3drm: Implement GetParent

2012-01-09 Thread André Hentschel
Am 08.01.2012 20:02, schrieb Nikolay Sivov: > On 1/8/2012 20:47, André Hentschel wrote: >> --- >> dlls/d3drm/frame.c | 11 +++ >> dlls/d3drm/tests/d3drm.c | 16 >> 2 files changed, 15 insertions(+), 12 deletions(-) >> >> diff --git a/dlls/d3drm/frame.c b/dlls/

Rethinking WineConf

2012-01-09 Thread Jeremy White
Hi All, This past Wine conference, while great fun as always, was not as well attended as Wine conferences in the past. So I would like to stir up trouble by suggesting we rethink WineConf. For those that have not attended, the Wine conference has been a mostly annual affair since 2002. It is o

Re: [PATCH] programs/explorer: Fix explorer's command line parsing (try 2)

2012-01-09 Thread Jay Yang
On 01/09/2012 09:46 AM, Vitaliy Margolen wrote: > On 01/08/2012 08:45 PM, Jay Yang wrote: >> Fixed some small formatting issues from last time. >> > > Your patch strips spaces all over the place. For example: > +LPWSTR *argv; > +if(commandline[0]=='\0') > Need an empty line after variable d

Re: [PATCH] programs/explorer: Fix explorer's command line parsing (try 2)

2012-01-09 Thread Vitaliy Margolen
On 01/08/2012 08:45 PM, Jay Yang wrote: Fixed some small formatting issues from last time. Your patch strips spaces all over the place. For example: +LPWSTR *argv; +if(commandline[0]=='\0') Need an empty line after variable declarations. No space after "if". No space around equal opera

Re: [PATCH 1/6] ieframe: Added support for SID_SHTMLWindow in WebBrowser::QueryService

2012-01-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16341 Your paranoid android

Re: user32: Add GetListBoxInfo

2012-01-09 Thread Nikolay Sivov
On 1/9/2012 01:28, Louis Lenders wrote: This should fix http://bugs.winehq.org/show_bug.cgi?id=27385 (See also Remarks on http://msdn.microsoft.com/en-us/library/windows/desktop/bb775208%28v=vs.85%29.aspx : This message is equivalent to GetListBoxInfo. +DWORD WINAPI GetListBoxInfo(HWND hwnd