Re: PVS-Studio run against ReactOS: (at least) one bug in wine git

2012-01-08 Thread Dan Kegel
On Sun, Jan 1, 2012 at 10:14 PM, Dan Kegel wrote: > Hey, cool!  I added that to http://wiki.winehq.org/StaticAnalysis > > I figured I'd try running PVS-Studio on the Wine sources in Wine, but > it runs in the Visual Studio context, and I can't even load > the wine project successfully under warn+h

Re: user32: Add GetListBoxInfo

2012-01-08 Thread Dmitry Timoshkov
Louis Lenders wrote: > +DWORD WINAPI GetListBoxInfo(HWND hwnd) > +{ > +TRACE("(%p)\n", hwnd); > +return SendMessageW( hwnd, LB_GETLISTBOXINFO, 0, 0); > +} The spacing is not consistent. > -# @ stub GetListBoxInfo > +@ stdcall GetListBoxInfo(ptr) Please have a look at other user32 spec

Re: [4/4] shell32: Fix SHLoadInProc() return value

2012-01-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16325 Your paranoid android

Re: [6/6] d3drm: Implement GetParent

2012-01-08 Thread André Hentschel
Am 08.01.2012 20:02, schrieb Nikolay Sivov: > On 1/8/2012 20:47, André Hentschel wrote: >> --- >> dlls/d3drm/frame.c | 11 +++ >> dlls/d3drm/tests/d3drm.c | 16 >> 2 files changed, 15 insertions(+), 12 deletions(-) >> >> diff --git a/dlls/d3drm/frame.c b/dlls/

Re: [6/6] d3drm: Implement GetParent

2012-01-08 Thread Nikolay Sivov
On 1/8/2012 20:47, André Hentschel wrote: --- dlls/d3drm/frame.c | 11 +++ dlls/d3drm/tests/d3drm.c | 16 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/dlls/d3drm/frame.c b/dlls/d3drm/frame.c index 212f7dd..b72700c 100644 --- a/dlls/d3drm/