Re: [PATCH 1/5] ddraw/tests: Add some clipper tests.

2012-01-05 Thread Henri Verbeet
On 5 January 2012 19:31, Alexandre Julliard wrote: > If it always succeeds without a virtual desktop, then yes the todos can > be removed. > Ok, please use the attached patch instead. From bd742ca3a55102b916f510b9c3414a621888a9df Mon Sep 17 00:00:00 2001 From: Henri Verbeet Date: Wed, 4 Jan 2012

Re: [PATCH 1/5] ddraw/tests: Add some clipper tests.

2012-01-05 Thread Alexandre Julliard
Henri Verbeet writes: > On 5 January 2012 18:19, Alexandre Julliard wrote: >> It doesn't work here: >> >> ../../../tools/runtest -q -P wine -M ddraw.dll -T ../../.. -p >> ddraw_test.exe.so ddraw1.c && touch ddraw1.ok >> ddraw1.c:225: Test succeeded inside todo block: Got unexpected bounding rec

Re: [PATCH 1/5] ddraw/tests: Add some clipper tests.

2012-01-05 Thread Henri Verbeet
On 5 January 2012 18:19, Alexandre Julliard wrote: > It doesn't work here: > > ../../../tools/runtest -q -P wine -M ddraw.dll -T ../../.. -p > ddraw_test.exe.so ddraw1.c && touch ddraw1.ok > ddraw1.c:225: Test succeeded inside todo block: Got unexpected bounding rect > {14, 33, 646, 486}, expect

Re: Any bad side-effects from not building with HAL if udisks is enabled?

2012-01-05 Thread Scott Ritchie
On 01/04/2012 10:26 AM, Alexandre Julliard wrote: > Scott Ritchie writes: > >> Assuming udisks support exists on the system, anything wrong with this? >> Does the new udisks do everything HAL used to do? > > If udisks is present, the HAL support is not used at all. > Perhaps the configure war

Re: [PATCH 1/5] ddraw/tests: Add some clipper tests.

2012-01-05 Thread Alexandre Julliard
Henri Verbeet writes: > --- > dlls/ddraw/tests/ddraw1.c | 217 > + > dlls/ddraw/tests/ddraw2.c | 217 > + > dlls/ddraw/tests/ddraw4.c | 216 > dlls/ddraw/test

Re: msvcrt: make WEOF returned from swscanf signed (try 2)

2012-01-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16280 Your paranoid android

Re: [3/3] user32: Move the server call up in order to perform the thread input check earlier in SetActiveWindow.

2012-01-05 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > SetForegroundWindow already does a similar thing. > > Yes but that's because it doesn't have to call a hook first. Do you have a suggestion how to perform the thread input check without moving the server call up? -- Dmitry.

Re: [3/3] user32: Move the server call up in order to perform the thread input check earlier in SetActiveWindow.

2012-01-05 Thread Alexandre Julliard
Dmitry Timoshkov writes: > SetForegroundWindow already does a similar thing. Yes but that's because it doesn't have to call a hook first. -- Alexandre Julliard julli...@winehq.org

Re: D3DXHANDLE for ID3DXConstantTable

2012-01-05 Thread Henri Verbeet
2012/1/5 Rico Schüller : > is a name or a handle! So the only option I see is to use the address of the > handle as index, which would require a sorted list or something like a > rbtree and also would be cpu expensive for comparison if the "index" is in > the list. Keep in mind the list could get b

Re: D3DXHANDLE for ID3DXConstantTable

2012-01-05 Thread Henri Verbeet
2012/1/5 Rico Schüller : > Sure, it could be done that way. So we may start using normal indices (0..x) > and put out a warning if there are too much handles around. That way we may > see if apps use that much handles. > Probably a FIXME, but yeah. I suppose if needed on 64-bit we could just map 2G

Re: D3DXHANDLE for ID3DXConstantTable

2012-01-05 Thread Rico Schüller
Am 05.01.2012 06:09, schrieb Henri Verbeet: 2012/1/5 Rico Schüller: char *name="test"; address may be: name -> 0x80484c4 Now what happens if the address is equal the index of another variable? You're not really supposed to have string pointers in the first MB or so of your address space. Yes,

Re: D3DXHANDLE for ID3DXConstantTable

2012-01-05 Thread Henri Verbeet
2012/1/5 Rico Schüller : > char *name="test"; address may be: name -> 0x80484c4 > Now what happens if the address is equal the index of another variable? You're not really supposed to have string pointers in the first MB or so of your address space. > The detection by something like the address //

Re: [PATCH] msvcp60: Avoid a crash, when the ptr in basic_string_char is NULL

2012-01-05 Thread Piotr Caban
Hi, void __thiscall basic_string_char__Eos(basic_string_char *this, MSVCP_size_t len) { -this->size = len; -this->ptr[len] = 0; +if (this->ptr) { +this->size = len; +this->ptr[len] = 0; +} } This function should not be called if this->ptr is NULL. The bug i

Re: D3DXHANDLE for ID3DXConstantTable

2012-01-05 Thread Rico Schüller
Am 04.01.2012 17:26, schrieb Henri Verbeet: 2012/1/5 Rico Schüller: I'm not sure what you mean by a "normal handle table". Do you mean a list? It's pretty much just a table of handles. There are a couple of different variants spread over the Wine source. For example, http://source.winehq.org/

Re: [PATCH 2/2] winmm/tests: Test some inconsistent WAVEFORMAT descriptions.

2012-01-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16276 Your paranoid android