Re: [PATCH 2/7] wined3d: Move srgb checks away from d3dfmt_get_conv.

2012-01-03 Thread Diego Nieto Cid
On Tue, Jan 03, 2012 at 09:48:59PM -0300, Diego Nieto Cid wrote: > > HEAD still shows the error above. I'll try to find what happened through > bisection. > Oh sorry, I forgot to mention this only happens when I use a virtual desktop.

Re: [PATCH 2/7] wined3d: Move srgb checks away from d3dfmt_get_conv.

2012-01-03 Thread Diego Nieto Cid
Hi, On Wed, Dec 28, 2011 at 07:46:09AM +0100, Henri Verbeet wrote: > Probably, yeah. Not just for WINED3DFMT_P8_UINT, but for all the > formats in d3dfmt_get_conv(). I guess something like the following at > the end of d3dfmt_get_conv() should work: > > > > if (*convert != NO_CONVERSION) > > { >

Re: [PATCH 1/6] [lib/port]: Added a unicode POSIX compliant regular expression library

2012-01-03 Thread Alexandre Julliard
Eric Pouech writes: > A+ > --- > > include/wine/regexw.h | 66 ++ > libs/port/Makefile.in |1 > libs/port/regexw.c| 513 > + > 3 files changed, 580 insertions(+), 0 deletions(-) > create mode 100644 include/wine/regexw.h > create

[PATCH RFC 4/5] dsound: Clean up channels

2012-01-03 Thread Joerg-Cyril . Hoehle
Alexander, You want to google the paper titled "Defining speaker locations in multi-channel streams and WDM audio drivers using the WAVEFORMATEXTENSIBLE structure" by Carsten Schulz to learn a lot about channel mapping as performed by w2k. It's a pity there's nothing like it for xp or w7! Wine's

Re: new d3d9/device.ok test always fails here, but not a regression?

2012-01-03 Thread Henri Verbeet
2012/1/3 Frédéric Delanoy : > Might be difficult to explain to "plain" users though. Some already > struggle performing a regression test (most won't even bother), let > alone understanding the fine details of what a regression really > represents. > The original thread starter excluded, I don't us

Re: new d3d9/device.ok test always fails here, but not a regression?

2012-01-03 Thread Henri Verbeet
I had hoped this was one of those threads that would go away if I ignored it. Oh well. I actually think there's value in handling anything that breaks an application as a regression. Despite claims to the contrary, we like users to test releases and find regressions sooner rather than later. If app

Re: new d3d9/device.ok test always fails here, but not a regression?

2012-01-03 Thread Austin English
2012/1/3 Frédéric Delanoy : > On Tue, Jan 3, 2012 at 13:01, Alexandre Julliard wrote: >> joerg-cyril.hoe...@t-systems.com writes: >>> >>> What benefit does it have for developers?  Having one's name appear less >>> often in source.winehq.org/regressions when doing The Right Thing (TRT)? >> >> Yes,

Re: new d3d9/device.ok test always fails here, but not a regression?

2012-01-03 Thread Frédéric Delanoy
On Tue, Jan 3, 2012 at 13:01, Alexandre Julliard wrote: > joerg-cyril.hoe...@t-systems.com writes: >> >> What benefit does it have for developers?  Having one's name appear less >> often in source.winehq.org/regressions when doing The Right Thing (TRT)? > > Yes, it reduces the noise to let you con

Re: new d3d9/device.ok test always fails here, but not a regression?

2012-01-03 Thread Alexandre Julliard
joerg-cyril.hoe...@t-systems.com writes: > Hi, > >> Bugs in newly added code cannot be regressions. >> >> Similarly, if we add a dll and some app starts using it and breaks, >> technically that's not a regression even though the behavior got worse, >> because it has always been broken, it just was

new d3d9/device.ok test always fails here, but not a regression?

2012-01-03 Thread Joerg-Cyril . Hoehle
Hi, > Bugs in newly added code cannot be regressions. > > Similarly, if we add a dll and some app starts using it and breaks, > technically that's not a regression even though the behavior got worse, > because it has always been broken, it just wasn't exercised before. What does this distinction

Re: mscoree: Implement CLRRuntimeHost_ExecuteInDefaultAppDomain

2012-01-03 Thread Vincent Povirk
Cool! Looks good to me. On Tue, Jan 3, 2012 at 4:23 AM, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: >    mscoree: Implement CLRRuntimeHost_ExecuteInDefaultAppDomain > > > Best Regards >  Alistair Leslie-Hughes > > >

Re: new d3d9/device.ok test always fails here, but not a regression?

2012-01-03 Thread Austin English
On Tue, Jan 3, 2012 at 01:10, Saulius Krasuckas wrote: > * On Mon, 2 Jan 2012, Dan Kegel wrote: >> >> If an app stops working because some missing feature is added to an >> existing DLL, it should not be tagged as a regression even though it is >> from the app's point of view, right? >> (Thinking

Re: [PATCH 3/5] d3d10/tests: Add a state groups test.

2012-01-03 Thread Henri Verbeet
On 2 January 2012 22:22, Marvin wrote: > === WINEBUILD (build) === > Patch failed to apply > I think this happens because bin/RetrievePatches.pl writes patches in the wrong encoding after retrieving them from http://source.winehq.org/patches/. The attached patch may help, but unfortunately it's un