Re: Status on SetPixelFormat patch from May 2010

2011-12-30 Thread Henri Verbeet
On 30 December 2011 22:15, Chris Robinson wrote: > years ago. I think a better fix would be for wined3d to use a dummy surface, > or a renderless context (available with OpenGL 3.0), if it's asked to use the > desktop window. > Yes, we do something along those lines in ddraw, and we'll likely move

Re: Status on SetPixelFormat patch from May 2010

2011-12-30 Thread Chris Robinson
On Friday, December 30, 2011 1:41:12 PM Jeff Cook wrote: > Hello all > > I am curious about the patch on > http://bugs.winehq.org/show_bug.cgi?id=18490 and why it's not in > vanilla. http://bugs.winehq.org/show_bug.cgi?id=18490#c9 seems to be a > pretty cogent explanation of the issue and the patc

Status on SetPixelFormat patch from May 2010

2011-12-30 Thread Jeff Cook
Hello all I am curious about the patch on http://bugs.winehq.org/show_bug.cgi?id=18490 and why it's not in vanilla. http://bugs.winehq.org/show_bug.cgi?id=18490#c9 seems to be a pretty cogent explanation of the issue and the patch appears reasonable enough. It prevents a major crasher in Empire: T

Re: [PATCH 3/3] vbscript: Added InStr tests

2011-12-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16214 Your paranoid android

Re: [7/8]usp10: implement ScriptGetFontLanguageTags

2011-12-30 Thread Alexandre Julliard
Aric Stewart writes: > --- > dlls/usp10/shape.c | 121 > ++- > dlls/usp10/tests/usp10.c| 37 - > dlls/usp10/usp10.c | 11 > dlls/usp10/usp10.spec |2 +- > dlls/usp10/usp10_internal.h |9 +++ > 5 fil

Re: [2/2] user32: Make a SetFocus message test for a top level child window pass. Resend.

2011-12-30 Thread Alexandre Julliard
Dmitry Timoshkov writes: > What kind of tests do you have in mind? Invalid window? Something else? Yes, invalid or belonging to a different thread input. -- Alexandre Julliard julli...@winehq.org

Re: [2/2] user32: Make a SetFocus message test for a top level child window pass. Resend.

2011-12-30 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > -if (!set_active_window( hwnd, &prev, FALSE, TRUE )) return 0; > > +set_active_window( hwnd, &prev, FALSE, TRUE ); > > return prev; > > } > > It doesn't seem right to ignore all errors. This would need some more > tests. What kind of tests do you have

Re: [PATCH 1/9] jscript: Handle invalid break statements in compiler

2011-12-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16210 Your paranoid android

Re: [2/2] user32: Make a SetFocus message test for a top level child window pass. Resend.

2011-12-30 Thread Alexandre Julliard
Dmitry Timoshkov writes: > +hwnd = WIN_GetFullHandle( hwnd ); > > -if (!set_active_window( hwnd, &prev, FALSE, TRUE )) return 0; > +set_active_window( hwnd, &prev, FALSE, TRUE ); > return prev; > } It doesn't seem right to ignore all errors. This would need some more tests.

Re: [PATCH 2/9] jscript: Handle invalid break statements in compiler

2011-12-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16211 Your paranoid android

Re: [2/2] user32: Make a SetFocus message test for a top level child window pass. Resend.

2011-12-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16207 Your paranoid android

Re: [1/2] user32: Add some SetFocus message tests. Resend.

2011-12-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16206 Your paranoid android