Re: [PATCH 2/7] wined3d: Move srgb checks away from d3dfmt_get_conv.

2011-12-25 Thread Diego Nieto Cid
Hi, I beleive this patch introduced some kind of regression. While testing Fallout the following message was printed to the screen: trace:d3d_surface:surface_allocate_surface (0x1a25f0) : Creating surface (target 0xde1) level 0, d3d format WINED3DFMT_P8_UINT, internal format 0x80e5, width 1024

Re: kernel32/tests: test that GetModuleFileName returns an absolute path

2011-12-25 Thread Thomas Faber
On 2011-12-25 17:12, Dmitry Timoshkov wrote: > Thomas Faber wrote: > >> diff --git a/dlls/kernel32/tests/Makefile.in >> b/dlls/kernel32/tests/Makefile.in >> index dce27db..2ce3ec6 100644 >> --- a/dlls/kernel32/tests/Makefile.in >> +++ b/dlls/kernel32/tests/Makefile.in >> @@ -1,5 +1,5 @@ >> TEST

Re: kernel32/tests: test that GetModuleFileName returns an absolute path

2011-12-25 Thread Dmitry Timoshkov
Thomas Faber wrote: > diff --git a/dlls/kernel32/tests/Makefile.in b/dlls/kernel32/tests/Makefile.in > index dce27db..2ce3ec6 100644 > --- a/dlls/kernel32/tests/Makefile.in > +++ b/dlls/kernel32/tests/Makefile.in > @@ -1,5 +1,5 @@ > TESTDLL = kernel32.dll > -IMPORTS = user32 advapi32 > +IMPO

Re: [PATCH RFC 5/5] dsound: convert from fixed to floating point

2011-12-25 Thread Chris Robinson
On Saturday, December 24, 2011 9:20:38 PM Alexander E. Patrakov wrote: > Andrew Eikum converted the buffer position calculation code from fixed > point to floating point, because floating-point code is more readable. > I agree with him. FWIW, I'm not sure using floating point for the position inde

Re: DIB crash with gdb

2011-12-25 Thread Marcus Meissner
On Fri, Dec 23, 2011 at 11:56:35PM -0600, Ken Thomases wrote: > > On Dec 23, 2011, at 3:10 PM, Michael Ost wrote: > > > This all makes sense, and pulls the code together for me. Thanks! > > You're welcome. > > > I assume this is a recent development, because I was successfully using gdb > > wi

Re: [PATCH RFC 5/5] dsound: convert from fixed to floating point

2011-12-25 Thread Alexander E. Patrakov
"Alexander E. Patrakov" wrote: > "Alexander E. Patrakov" wrote: > > > Andrew Eikum converted the buffer position calculation code from > > fixed point to floating point, because floating-point code is more > > readable. I agree with him. > > > > I am not sending further patches out, because it

Re: [PATCH RFC 5/5] dsound: convert from fixed to floating point

2011-12-25 Thread Alexander E. Patrakov
"Alexander E. Patrakov" wrote: > Andrew Eikum converted the buffer position calculation code from fixed > point to floating point, because floating-point code is more readable. > I agree with him. > > I am not sending further patches out, because it is not yet clear > which of the two proposed p