Re: [PATCH 2/2] comdlg32: Widen buffer to accomodate Catalan translation

2011-12-16 Thread Alex Henrie
Thanks for the feedback. It looks like Alexandre widened the buffer to 64 characters when he committed the patch. -Alex

Re: [6/6]usp10: add Mathematical Alphanumeric Symbols script

2011-12-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16023 Your paranoid android

Re: [4/6]usp10: add Deseret script

2011-12-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16021 Your paranoid android

Re: [5/6]usp10: add Osmanya script

2011-12-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16022 Your paranoid android

Re: About release 1.3.35

2011-12-16 Thread Alexandre Julliard
GOUJON Alexandre writes: > Am I the only one who noticed that the "Release 1.3.35" was authored > by Frédéric Delanoy ? > Who's the author (really) doesn't matter but having a commit from a > gmail.com e-mail address instead of a winehq.org one (just) surprised > me. That's a bug in my git front

Looking to implement msvcp90's basic_ifstream (and friends)

2011-12-16 Thread Aaron Faanes
Howdy! I ran into this bug when running a game of mine, and it seemed doable for me. The bug is due to msvcp90 missing its file I/O stuff. Here's the link: http://bugs.winehq.org/show_bug.cgi?id=25966 My intention is to implement these classes as wrappers of ntdll's file I/O API. Is this the rig

Re: Major mmdevapi and winmm audio bugs

2011-12-16 Thread Jari Vetoniemi
Interesting, It looks like bug #28982, could be affected by one or more of these you listed. 2011/12/16 : > Hi, > > The present list is quite different from what I posted 2 month ago. > http://www.winehq.org/pipermail/wine-devel/2011-October/092716.html > > #28723 is about handling tight timing a

About release 1.3.35

2011-12-16 Thread GOUJON Alexandre
Am I the only one who noticed that the "Release 1.3.35" was authored by Frédéric Delanoy ? Who's the author (really) doesn't matter but having a commit from a gmail.com e-mail address instead of a winehq.org one (just) surprised me. Anyway, let's pull this latest wine version, compile and test i

Major mmdevapi and winmm audio bugs

2011-12-16 Thread Joerg-Cyril . Hoehle
Hi, The present list is quite different from what I posted 2 month ago. http://www.winehq.org/pipermail/wine-devel/2011-October/092716.html #28723 is about handling tight timing and little prefill #27901 is about snd_pcm_drop erroneously being used by AudioClient_Stop. I've a patch in my queue b

Re: [PATCH] wined3d: Fixes some windows to receive mouse clicks

2011-12-16 Thread Henri Verbeet
On 14 December 2011 23:45, wrote: > @@ -871,6 +871,13 @@ static HRESULT swapchain_init(struct wined3d_swapchain > *swapchain, WINED3DSURFTY >     swapchain->win_handle = window; >     swapchain->device_window = window; > > +    if (!desc->windowed && window) > +    { > +        wined3d_device_se

Re: crypt32: Avoid reading unitialized variables (Coverity)

2011-12-16 Thread Frédéric Delanoy
2011/12/16 Frédéric Delanoy : > 2011/12/16 Juan Lang : >>> On second thought, coverity would still complain even with the >>> TRACEs adapted, so I'll mark these defects as Ignored in Coverity >> >> Does the attached patch address one of the Coverity complaints? >> --Juan > > I can't launch a new Co

Re: [PATCH 2/2] comdlg32: Widen buffer to accomodate Catalan translation

2011-12-16 Thread Francois Gouget
On Fri, 16 Dec 2011, Alex Henrie wrote: > --- > dlls/comdlg32/filedlg.c |2 +- [...] > - WCHAR buf[16]; > + WCHAR buf[17]; >LoadStringW(COMDLG32_hInstance, IDS_SAVE_AS, buf, > sizeof(buf)/sizeof(WCHAR)); I don't think it makes sense to add room for just one more WCHAR. The

Re: [PATCH 2/2] comdlg32: Widen buffer to accomodate Catalan translation

2011-12-16 Thread Paul Chitescu
On Friday 16 December 2011 09:48:01 am Alex Henrie wrote: > --- > dlls/comdlg32/filedlg.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/comdlg32/filedlg.c b/dlls/comdlg32/filedlg.c > index 5f80519..8637944 100644 > --- a/dlls/comdlg32/filedlg.c > +++ b/dlls/co

Re: crypt32: Avoid reading unitialized variables (Coverity)

2011-12-16 Thread Frédéric Delanoy
2011/12/16 Juan Lang : >> On second thought, coverity would still complain even with the >> TRACEs adapted, so I'll mark these defects as Ignored in Coverity > > Does the attached patch address one of the Coverity complaints? > --Juan I can't launch a new Coverity run by myself (only Amine Khaldi