Re: Patch for #29144

2011-12-15 Thread Damian Ivanov
Included in my build and updated to 1.3.34 Best regards, Damian 2011/12/1 Damian Ivanov : > Thank you! > > I'll test it and include it with my this Saturday. > > Best regards > > On Dec 1, 2011 10:50 AM, "Aurélien COUDERC" wrote: >> >> Please find an attached patch for #29144. >> >> It probably

Re: crypt32: Avoid reading unitialized variables (Coverity)

2011-12-15 Thread Juan Lang
> On second thought, coverity would still complain even with the > TRACEs adapted, so I'll mark these defects as Ignored in Coverity Does the attached patch address one of the Coverity complaints? --Juan From 13115c8ab68550b38f992eba04c9a05e88696f73 Mon Sep 17 00:00:00 2001 From: Juan Lang Date:

Re: wineconsole: Remove the character-width check as we need newer FreeType library.

2011-12-15 Thread Akihiro Sagawa
On Wed, 14 Dec 2011 19:35:34 +0100, Eric Pouech wrote: > this doesn't solve the printing issue as the always infer that any char has > the same size > how is this printed on real windows with your character set ? See the attachment, please. It was taken in my Windows 7 PC with Japanese Terminal fo

Re: [PATCH 5/7] jscript: Don't pass EXPR_NEWREF to name expression in array_expression_eval

2011-12-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15993 Your paranoid android

Re: [PATCH 3/7] jscript: Throw type error on invalid delete

2011-12-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15992 Your paranoid android

Re: crypt32: Avoid reading unitialized variables (Coverity)

2011-12-15 Thread Frédéric Delanoy
2011/12/14 Juan Lang : >> Should the TRACE (e.g. on crypt32:2435) be adapted so it conditionally >> prints the value instead? Or be removed altogether? > > I'd prefer a conditional print if it's not too ugly.  There haven't > been too many decoding bugs in a while, but the trace can sometimes > hel