Re: [PATCH 1/5] ddraw: Move clipper handling to ddraw.

2011-12-13 Thread Henri Verbeet
On 13 December 2011 15:31, Stefan Dösinger wrote: > Assuming that msdn[1] is correct, implies that we'll have to move overlays to > ddraw as well. It probably makes sense to do overlays completely in ddraw, but I don't think this patch requires that.

Debugging Wine with Lightroom 3.5

2011-12-13 Thread Roland Baudin
Hi, let me first congratulate all the people who work hard on the Wine project : their work is much appreciated here... Now, my question : I was able to install and run Adobe Photoshop Lightroom 3.5 under wine 1.3.33 or 1.3.34. While it runs quite well and is fairly stable I have two major i

Re: [PATCH 2/4] d3dx9: Implement ID3DXBaseEffect::SetVector().

2011-12-13 Thread Rico Schüller
Am 13.12.2011 16:10, schrieb Matteo Bruni: Hi Rico, 2011/12/13 Rico Schüller: --- dlls/d3dx9_36/effect.c | 52 +-- 1 files changed, 49 insertions(+), 3 deletions(-) +static void set_vector(struct d3dx_parameter *param, CONST D3DXVECTOR4 *vector)

Re: [PATCH 4/4] d3dx9: Implement ID3DXBaseEffect::SetValue().

2011-12-13 Thread Matteo Bruni
2011/12/13 Rico Schüller : > --- >  dlls/d3dx9_36/effect.c |   42 -- >  1 files changed, 40 insertions(+), 2 deletions(-) > > +TRACE("Copy %u bytes\n", param->bytes); > +memcpy(param->data, data, bytes); That trace is not corr

Re: [PATCH 2/4] d3dx9: Implement ID3DXBaseEffect::SetVector().

2011-12-13 Thread Matteo Bruni
Hi Rico, 2011/12/13 Rico Schüller : > --- >  dlls/d3dx9_36/effect.c |   52 > +-- >  1 files changed, 49 insertions(+), 3 deletions(-) > > +static void set_vector(struct d3dx_parameter *param, CONST D3DXVECTOR4 > *vector) > +{ > +set_number((float *)

Re: [PATCH 2/5] ddraw: Add support for clipped blits.

2011-12-13 Thread Stefan Dösinger
Am Montag, 12. Dezember 2011, 20:53:56 schrieb Henri Verbeet: > +if (!dst_surface->clipper) I think some tests would be a good idea, e.g. if clippers work on offscreen surfaces or backbuffers, or what happens when a D3D render target has a clipper attached. Msdn also suggests that BltFast fai

Re: [PATCH 1/5] ddraw: Move clipper handling to ddraw.

2011-12-13 Thread Stefan Dösinger
Am Montag, 12. Dezember 2011, 20:53:55 schrieb Henri Verbeet: > --- a/dlls/wined3d/clipper.c > +++ /dev/null Assuming that msdn[1] is correct, implies that we'll have to move overlays to ddraw as well. I'm not opposed to that, just mentioning it. In fact I'm actually inclined to move the overlay