Re: Would making the Wine file dialogs know about the Nautilus bookmarks be a reasonable thing?

2011-12-12 Thread Vitaliy Margolen
On 12/12/2011 04:34 PM, Scott Ritchie wrote: Would it be appropriate to display those self-added bookmarks in Wine? I'm worried there might be something I'm missing about the implementation that would make this difficult or a bad idea. It would only work with v6 controls, not the old dialogs Wi

Re: Would making the Wine file dialogs know about the Nautilus bookmarks be a reasonable thing?

2011-12-12 Thread Dmitry Timoshkov
Scott Ritchie wrote: > Would it be appropriate to display those self-added bookmarks in Wine? > I'm worried there might be something I'm missing about the > implementation that would make this difficult or a bad idea. File open/save dialogs use the standard SDK templates, which are supposed to b

Re: [PATCH] comdlg32: Remove system menu from Find and Replace dialogs

2011-12-12 Thread Alex Henrie
I took a closer look at Windows Notepad and discovered that while the Find and Replace dialogs do not have system menu icons, they do have system menus accessible by Alt+Space. So these two patches aren't the solution after all. I came up with a new patch that seems to fix the problem properly and

Would making the Wine file dialogs know about the Nautilus bookmarks be a reasonable thing?

2011-12-12 Thread Scott Ritchie
Assuming you're running Gnome, as I'm not sure there's a freedesktop standard for the Bookmark feature yet (and perhaps there should be). In every Gnome nautilus window, save dialog, and file open dialog there's a standard set of folders you see on the side as quick links. Some are obvious, and we

Re: [1/6] gdi32/tests: Add tests for vertical font. (try 3)

2011-12-12 Thread Alexandre Julliard
Kusanagi Kouichi writes: > vertical.sfd and vertical.ttf were generated from > M+ 1p regular (http://mplus-fonts.sourceforge.jp/) > by the following fontforge script. I'm getting a failure here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch fon

Re: [PATCH 4/5] jscript: Properly handle NULL IDispatch in stack_pop_object

2011-12-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15897 Your paranoid android

Re: [PATCH 2/5] jscript: Don't use EXPR_NEWREF in forin_statement_event

2011-12-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15896 Your paranoid android

Re: [PATCH 1/5] jscript: Don't use EXPR_NEWREF in for_statement_event

2011-12-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15895 Your paranoid android

Re: [PATCH] user32: Remove system menu from Yes/No/Cancel dialog

2011-12-12 Thread Dmitry Timoshkov
Alex Henrie wrote: > MSGBOX DIALOG 100, 80, 216, 168 > -STYLE DS_MODALFRAME | DS_NOIDLEMSG | WS_POPUP | WS_VISIBLE | WS_CAPTION | > WS_SYSMENU > +STYLE DS_MODALFRAME | DS_NOIDLEMSG | WS_POPUP | WS_VISIBLE | WS_CAPTION This doesn't match what Windows does. -- Dmitry.

Re: [PATCH] comdlg32: Remove system menu from Find and Replace dialogs

2011-12-12 Thread Dmitry Timoshkov
Alex Henrie wrote: > FINDDLGORD DIALOG 36, 24, 276, 62 > -STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU > +STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION What version of PSDK does it match? It doesn't match mine. -- Dmitry.