Re: [PATCH 1/3] wined3d: Relax depth blit requirements

2011-12-09 Thread Henri Verbeet
On 9 December 2011 13:45, Stefan Dösinger wrote: > dlls/d3d9/tests/device.c, test_scene(), line 1491 > Ok.

Re: [PATCH 1/3] wined3d: Relax depth blit requirements

2011-12-09 Thread Stefan Dösinger
2011/12/9 Henri Verbeet > On 9 December 2011 12:54, Stefan Dösinger wrote: > > This fixes bug 10636. > A proper commit message would be a good start. > > > +BOOL in_scene; > A test to show that this is actually needed for d3d9 wouldn't hurt. > The condition in wined3

Re: [PATCH 3/3] d3d8/tests: Port the depth blit test to d3d8

2011-12-09 Thread Henri Verbeet
On 9 December 2011 12:54, Stefan Dösinger wrote: > +    d3d = pDirect3DCreate8(D3D_SDK_VERSION); > +    ok(d3d != NULL, "Direct3DCreate8 failed.\n"); > +    hwnd = CreateWindow("d3d8_test_wc", "d3d8_test", WS_OVERLAPPEDWINDOW, > 100, 100, 160, 160, NULL, NULL, NULL, NULL); > +    ok(hwnd != NULL,

Re: [PATCH 1/3] wined3d: Relax depth blit requirements

2011-12-09 Thread Henri Verbeet
On 9 December 2011 12:54, Stefan Dösinger wrote: > This fixes bug 10636. A proper commit message would be a good start. > +    BOOL                          in_scene; A test to show that this is actually needed for d3d9 wouldn't hurt. The condition in wined3d is there because it was already there

Re: [PATCH 3/5] wined3d: Introduce a helper function for checking colors against a color key.

2011-12-09 Thread Stefan Dösinger
The patch is OK, this mail is just an answer to Henri's comment. 2011/12/8 Henri Verbeet > +static BOOL color_in_range(const struct wined3d_color_key *color_key, > DWORD color) > +{ > +/* FIXME: Is this really how color keys are supposed to work? I think > it > + * makes more sense to co

Re: [2/2] user32: Make a SetFocus message test for a top level child window pass.

2011-12-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15856 Your paranoid android

Re: [2/2] user32: Make a SetFocus message test for a top level child window pass.

2011-12-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15856 Your paranoid android

Re: [1/2] user32: Add some SetFocus message tests.

2011-12-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15855 Your paranoid android