Re: user32: Avoid crashing if we can't alloc text buffer

2011-12-02 Thread Nikolay Sivov
On 12/3/2011 04:35, Bruno Jesus wrote: If LocalLock fails the buffer is not allocated and get_text_length, which is used in several different places, will make wine crash. LocalLock doesn't allocate anything. You need to figure out why buffer is not allocated at this point.

Re: [PATCH] dsound: Validate format in primary buffer's SetFormat()

2011-12-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15748 Your paranoid android

Re: [PATCH 1/3] ddraw: Size handling fixes for IDirect3DDevice::GetCaps (try 4)

2011-12-02 Thread Alexandre Julliard
ste...@codeweavers.com writes: > +static inline BOOL check_d3ddevicedesc_size(DWORD size) > +{ > +if (size == 172 || size == 204 || size == sizeof(D3DDEVICEDESC) /* 252 > */) return TRUE; > +return FALSE; > +} You should use something like FIELD_OFFSET instead of these magic constants.

Re: cmd: Print error messages on stderr, not on stdout. (try3)

2011-12-02 Thread Frédéric Delanoy
2011/12/2 Francois Gouget : > On Fri, 2 Dec 2011, Frédéric Delanoy wrote: > [...] >> There is now a discrepancy between wine output, and testrunner output, e.g. >> echo -- eol option >> for /f "eol=@" %%i in ("    ad") do echo %%i >> echo bar >> >> gave >> >> -- eol option >> Syntax error >

Re: cmd: Print error messages on stderr, not on stdout. (try3)

2011-12-02 Thread Francois Gouget
On Fri, 2 Dec 2011, Frédéric Delanoy wrote: [...] > There is now a discrepancy between wine output, and testrunner output, e.g. > echo -- eol option > for /f "eol=@" %%i in ("ad") do echo %%i > echo bar > > gave > > -- eol option > Syntax error > bar > > but not gives > > -- eol

Re: cmd: Print error messages on stderr, not on stdout. (try3)

2011-12-02 Thread Francois Gouget
On Fri, 2 Dec 2011, Frédéric Delanoy wrote: [...] > > As far as I can tell the tests pass both in Wine an on Windows. > > What is test runner? > > The programs/cmd/tests/batch.c file that preprocesses the .cmd file > and compares it to the associated .exp file; this is run when you do a > "make te

Re: cmd: Print error messages on stderr, not on stdout. (try3)

2011-12-02 Thread Frédéric Delanoy
2011/12/2 Francois Gouget : > On Fri, 2 Dec 2011, Frédéric Delanoy wrote: > [...] >> Would you mind updating the http://wiki.winehq.org/CmdConformanceTests >> page with your synchronization stuff? > > Done. > > > >> There is now a discrepancy between wine output, and testrunner output, e.g. > > As

Re: cmd: Print error messages on stderr, not on stdout. (try3)

2011-12-02 Thread Francois Gouget
On Fri, 2 Dec 2011, Frédéric Delanoy wrote: [...] > Would you mind updating the http://wiki.winehq.org/CmdConformanceTests > page with your synchronization stuff? Done. > There is now a discrepancy between wine output, and testrunner output, e.g. As far as I can tell the tests pass both in Win

Re: cmd: Print error messages on stderr, not on stdout. (try3)

2011-12-02 Thread Frédéric Delanoy
On Fri, Dec 2, 2011 at 10:07, Francois Gouget wrote: > --- > > I meant to resend this one as [2/2] in my previous series but forgot. > With the resynchronization points we can now handle the fixed output > correctly in the tests this time. > >  programs/cmd/builtins.c                  |   20 +

Re: [PATCH 3/3] user32: If a dialog has no tab-accessible controls, set focus to first control (with tests)

2011-12-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15740 Your paranoid android