Re: [PATCH 1/2] kernel32: implement GetLogicalProcessorInformation

2011-11-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15626 Your paranoid android

Re: [PATCH] kernel32: implement GetLogicalProcessorInformation

2011-11-24 Thread Claudio Fontana
Hello, I saw a bug 27189 in the bug database where Austin English was waiting for a GLPI implementation. I had one already (among other patches I keep against the wine tree), so I attached it, and while I was at it, I thought to submit it to wine-patches as well. I am not sure I have the time to

Re: [PATCH] kernel32: implement GetLogicalProcessorInformation

2011-11-24 Thread Ken Thomases
On Nov 24, 2011, at 5:13 PM, Charles Davis wrote: > On Nov 24, 2011, at 4:21 AM, Claudio Fontana wrote: > >> +ret = GetLogicalProcessorInformation(buffer, &buflen); >> +ok(ret, "Normal glpi call (%d)\n", GetLastError()); > Don't call GetLastError() inside an ok(). (Actually, that's moot,

Re: [PATCH] kernel32: implement GetLogicalProcessorInformation

2011-11-24 Thread Charles Davis
Hi, On Nov 24, 2011, at 4:21 AM, Claudio Fontana wrote: > First implementation of GetLogicalProcessorInformation. > Limitations: all logical processors are added to the same NUMA set, > and all cores are added to the same package. > Only the linux-specific helper function is implemented, so for n

Re: cmd: Use WCMD_output_asis*() for strings that are not supposed to contain formating directives.

2011-11-24 Thread Frédéric Delanoy
2011/11/24 Francois Gouget : > On Thu, 24 Nov 2011, Frédéric Delanoy wrote: > [...] >> > -            WCMD_output(newline); >> > +            WCMD_output_asis(newline); >> ... >> >       static const WCHAR newLine2[] = {'\n','\n','\0'}; >> > -      if (!bare) WCMD_output (newLine2); >> > +      if

Re: winhttp: Resolve the server name only on the first request.

2011-11-24 Thread Alexandre Julliard
Hans Leidekker writes: > -send_callback( &request->hdr, WINHTTP_CALLBACK_STATUS_RESOLVING_NAME, > connect->servername, strlenW(connect->servername) + 1 ); > +if (connect->sockaddr.ss_family == 0x) > +{ This won't work on Mac OS, ss_family is a byte: gcc -m32 -c -I. -I. -I../../

Re: dinput: Stub IDirectInputJoyConfig8 interface.

2011-11-24 Thread Michael Stefaniuc
On 11/24/2011 08:46 PM, Vitaliy Margolen wrote: > On 11/24/2011 12:27 PM, Michael Stefaniuc wrote: >> Hello Vitaliy, >> >> On 11/24/2011 06:28 PM, Vitaliy Margolen wrote: >>> --- >>> dlls/dinput/dinput_main.c|7 ++ >>> dlls/dinput/dinput_private.h |2 + >>> dlls/dinput/joystick.c

Re: dinput: Stub IDirectInputJoyConfig8 interface.

2011-11-24 Thread Vitaliy Margolen
On 11/24/2011 12:27 PM, Michael Stefaniuc wrote: Hello Vitaliy, On 11/24/2011 06:28 PM, Vitaliy Margolen wrote: --- dlls/dinput/dinput_main.c|7 ++ dlls/dinput/dinput_private.h |2 + dlls/dinput/joystick.c | 195 + include/dinputd.h

Re: Sugestion about wine

2011-11-24 Thread Matijn Woudt
On Thu, Nov 24, 2011 at 8:27 PM, Kane Jade wrote: > Perhaps the program Zynamics BinNavi is useful to analyze the win32 > applications, etc: > Zynamics BinNavi is the primary binary code reverse engineering tool based > on graph visualization Hi, Most likely this is your own software and you're

Sugestion about wine

2011-11-24 Thread Kane Jade
Perhaps the program Zynamics BinNavi is useful to analyze the win32 applications, etc: Zynamics BinNavi is the primary binary code reverse engineering tool based on graph visualization Description BinNavi is a binary code reverse engineering tool that was built to assist vulnerability researchers

Re: dinput: Stub IDirectInputJoyConfig8 interface.

2011-11-24 Thread Michael Stefaniuc
Hello Vitaliy, On 11/24/2011 06:28 PM, Vitaliy Margolen wrote: > --- > dlls/dinput/dinput_main.c|7 ++ > dlls/dinput/dinput_private.h |2 + > dlls/dinput/joystick.c | 195 + > include/dinputd.h| 243 > +++

Re: cmd: Use WCMD_output_asis*() for strings that are not supposed to contain formating directives.

2011-11-24 Thread Francois Gouget
On Thu, 24 Nov 2011, Frédéric Delanoy wrote: [...] > > -            WCMD_output(newline); > > +            WCMD_output_asis(newline); > ... > >       static const WCHAR newLine2[] = {'\n','\n','\0'}; > > -      if (!bare) WCMD_output (newLine2); > > +      if (!bare) WCMD_output_asis (newLine2); >

Re: [PATCH] kernel32: implement GetLogicalProcessorInformation

2011-11-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15612 Your paranoid android

Re: cmd: Use WCMD_output_asis*() for strings that are not supposed to contain formating directives.

2011-11-24 Thread Frédéric Delanoy
On Thu, Nov 24, 2011 at 00:30, Francois Gouget wrote: > Using WCMD_output*() instead could cause crashes. > --- > > For instance if a filename is '%s'. > This patch should not interfere with the previous one. > -            WCMD_output(newline); > +            WCMD_output_asis(newline); ... >    

Re: cmd: Print error messages on stderr, not on stdout.

2011-11-24 Thread Frédéric Delanoy
On Thu, Nov 24, 2011 at 00:29, Francois Gouget wrote: > --- > > I consider messages like 'Not Yet Implemented' and 'No Argument' to be > errors so that they should go to stderr. But maybe there's a strong > argument for not doing it that way. Your point is valid. I changed some/most of those myse