Re: [PATCH] wininet: Initialize netconn_stream's content_length

On Tue, Nov 22, 2011 at 9:28 AM, Andy Clayton wrote: > Hi Jacek, > > On Tue, Nov 22, 2011 at 3:59 AM, Jacek Caban wrote: > >> This doesn't seem right. At the point where we call >> HTTP_ReceiveRequestData, content_length is supposed to be set based on >> response header. The bug must be somewhere

Re: user32: Fix 64-bit 'msg' test hang in test_timers (try 2).

On Mon, Nov 21, 2011 at 10:08 PM, Dmitry Timoshkov wrote: > ... > kernel32.RaiseException is just a wrapper around an ntdll one. I'd expect > the kernel32 API be always available despite what MSDN claims. For some reason that causes the crash function to be called twice on the 64-bit VM, thoughts

Re: po: Update French translation (try 2)

2011/11/22 Frédéric Delanoy : > try 2: xB -> xO > --- >  po/fr.po |   52 +++- >  1 files changed, 19 insertions(+), 33 deletions(-) Seems you have committed the initial version. I'll change 'bytes' to 'octets' on next po update round, therefore you m

Re: po: Update French translation

>> On Tue, Nov 22, 2011 at 11:21, Francois Gouget wrote: > As I said before there's no confusion here. These applications are all > talking about 8 bit bytes. And anyway 'byte' is totally unused in > French, at least in France, and non computer scientists would not know > what it is. I suggest you

Re: po: Update French translation

On Tue, 22 Nov 2011, Frédéric Delanoy wrote: > On Tue, Nov 22, 2011 at 11:21, Francois Gouget wrote: > > On Mon, 21 Nov 2011, Frédéric Delanoy wrote: > > [...] > >>  msgid "%1!u!MB used, %2!u!MB available" > >> -msgstr "%u MB utilisés, %u MB disponibles" > >> +msgstr "%1!u! MB utilisés, %2!u! MB

Re: [PATCH 1/2] jscript: Added tests of unary '+' on not existent property

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15587 Your paranoid android

Re: [PATCH] wininet: Initialize netconn_stream's content_length

Hi Jacek, On Tue, Nov 22, 2011 at 3:59 AM, Jacek Caban wrote: > This doesn't seem right. At the point where we call > HTTP_ReceiveRequestData, content_length is supposed to be set based on > response header. The bug must be somewhere else. > Thanks for looking over my patch. So it seems then th

Re: po: Update French translation

On Tue, Nov 22, 2011 at 11:21, Francois Gouget wrote: > On Mon, 21 Nov 2011, Frédéric Delanoy wrote: > [...] >>  msgid "%1!u!MB used, %2!u!MB available" >> -msgstr "%u MB utilisés, %u MB disponibles" >> +msgstr "%1!u! MB utilisés, %2!u! MB disponibles" > [...] > kB, MB and GB should be translated

Re: [4/5] ntdll: Remove an invalid test.

Dmitry Timoshkov writes: > On the second thought I think that the test is really invalid, it depends on > the linker to put both the static buffer and the changed data (API pointers) > in the same page of the same section in a PE binary. That still doesn't make it invalid. You can write to the v

Re: [4/5] ntdll: Remove an invalid test.

Dmitry Timoshkov wrote: > > > The test initializers that call GetProcAddress() do write to the same > > > section > > > where the static buffer resides, which leads to the image section > > > protection > > > change. > > > > That doesn't make the test invalid. > > Correct, it makes it todo_wi

Re: [4/5] ntdll: Remove an invalid test.

Alexandre Julliard wrote: > > The test initializers that call GetProcAddress() do write to the same > > section > > where the static buffer resides, which leads to the image section protection > > change. > > That doesn't make the test invalid. Correct, it makes it todo_wine. Shoudl I resend t

Re: po: Update French translation

On Mon, 21 Nov 2011, Frédéric Delanoy wrote: [...] > msgid "%1!u!MB used, %2!u!MB available" > -msgstr "%u MB utilisés, %u MB disponibles" > +msgstr "%1!u! MB utilisés, %2!u! MB disponibles" [...] > msgctxt "unit kilobyte" > msgid "kB" > -msgstr "" > +msgstr "kB" > > #: winefile.rc:122 > msg

Re: [4/5] ntdll: Remove an invalid test.

Dmitry Timoshkov writes: > The test initializers that call GetProcAddress() do write to the same section > where the static buffer resides, which leads to the image section protection > change. That doesn't make the test invalid. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH] wininet: Initialize netconn_stream's content_length

Hi Andy, On 11/22/11 5:49 AM, Andy Clayton wrote: The size that net_conn_read reads is limited by netconn_stream's remaining content_length, so if the content_length is zero it reads nothing. It also means that the read size it returns is 0, which typically indicates that the socket was closed.