Re: [PATCH] dxgi: 0 / 0 means 0 for a DXGI_RATIONAL

2011-11-21 Thread Henri Verbeet
On 22 November 2011 00:42, Eduard - Gabriel Munteanu wrote: > This fixes a division by zero generated in Unigine Tropics in D3D10 > mode. It also adds a helper to handle such conversions, which takes the > form of a macro so we don't need to worry about the result's type. > I'd prefer an actual fu

Re: user32: Fix 64-bit 'msg' test hang in test_timers (try 2).

2011-11-21 Thread Dmitry Timoshkov
"Erich E. Hoover" wrote: > > Why not use kernel32.RaiseException (which is always available) instead? > > MSDN indicates that RaiseException is only available starting with > win2k, is it actually safe to use? I used RtlRaiseException because > that's what's used in the ntdll tests and I saw no

Re: user32: Fix 64-bit 'msg' test hang in test_timers (try 2).

2011-11-21 Thread Erich E. Hoover
On Mon, Nov 21, 2011 at 9:51 PM, Dmitry Timoshkov wrote: > "Erich E. Hoover" wrote: > > The attached patch changes the test_timers() crash function to use > > RtlRaiseException (if available) rather than attempting to write to memory > > address 0.  This change stops the timer tests from hanging

Re: user32: Fix 64-bit 'msg' test hang in test_timers (try 2).

2011-11-21 Thread Dmitry Timoshkov
"Erich E. Hoover" wrote: > The attached patch changes the test_timers() crash function to use > RtlRaiseException (if available) rather than attempting to write to memory > address 0. This change stops the timer tests from hanging on the 64-bit VM. Why not use kernel32.RaiseException (which

Re: winefile: Make it possible to translate the disk size units.

2011-11-21 Thread Dmitry Timoshkov
Jerome Leclanche wrote: > Users who do not understand the meaning of GiB/MiB/kiB are unlikely to > understand GB/MB/kB. I think the "too geeky" bit is a non-issue. > > Personally, I believe kiB is the way to go. Windows is not necessarily > correct in its usage of kB. Most Linux apps also tend t

Re: winefile: Make it possible to translate the disk size units.

2011-11-21 Thread Jerome Leclanche
Users who do not understand the meaning of GiB/MiB/kiB are unlikely to understand GB/MB/kB. I think the "too geeky" bit is a non-issue. Personally, I believe kiB is the way to go. Windows is not necessarily correct in its usage of kB. Most Linux apps also tend to use kiB; although there's probably

Re: regression bisected to commit: gdi32: Implement nulldrv_StretchDIBits using the PutImage gdi driver function.

2011-11-21 Thread Austin English
On Mon, Nov 21, 2011 at 11:12, Wolfgang Walter wrote: > Hello, > > I just tested version 1.3.33. With this version an application we use shows > its icons with wrong colors. The background of the icons is wrong, too. I > bisected it to commit c9a7bb715d2db1512db30deb11e4676e76791a07. > > I then ch

regression bisected to commit: gdi32: Implement nulldrv_StretchDIBits using the PutImage gdi driver function.

2011-11-21 Thread Wolfgang Walter
Hello, I just tested version 1.3.33. With this version an application we use shows its icons with wrong colors. The background of the icons is wrong, too. I bisected it to commit c9a7bb715d2db1512db30deb11e4676e76791a07. I then checked that by replacing nulldrv_StretchDIBits in 1.3.33 with its ol

Re: winefile: Make it possible to translate the disk size units.

2011-11-21 Thread Francois Gouget
On Sat, 19 Nov 2011, Francois Gouget wrote: [...] > - static const WCHAR sFmtGB[] = {'%', '.', '1', 'f', ' ', 'G', 'B', '\0'}; > - static const WCHAR sFmtMB[] = {'%', '.', '1', 'f', ' ', 'M', 'B', '\0'}; > - static const WCHAR sFmtkB[] = {'%', '.', '1', 'f', ' ', 'k', 'B', '\0'}; To be

Question about messages and the windows these need.

2011-11-21 Thread Joerg-Cyril . Hoehle
Hi, Alexandre Julliard wrote in http://www.winehq.org/pipermail/wine-devel/2011-July/090969.html >If you are going to wait for a reply it would be better to create a >HWND_MESSAGE window and do a SendMessage to it, then you get all the >synchronization for free. MMSYSTEM_MidiStream_Player needs a

Re: [PATCH 1/1] user32: Fix 64-bit 'msg' test hang in test_timers.

2011-11-21 Thread Erich E. Hoover
On Mon, Nov 21, 2011 at 3:29 AM, Alexandre Julliard wrote: > ... > That defeats the purpose of the test. Sorry, I assumed that an ok() would be involved for anything that was part of the test. I'll look into the issue more. Erich Hoover ehoo...@mines.edu

Re: [PATCH 1/2] jscript: Use bytecode for binary negation implementation

2011-11-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15559 Your paranoid android

Re: qedit/tests: Add SampleGrabber COM aggregation test.

2011-11-21 Thread Michael Stefaniuc
Marvin wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=15558 >

Re: [1/4] msxml3: Added common ISupportErrorInfo implementation

2011-11-21 Thread Nikolay Sivov
On 11/21/2011 16:39, Jacek Caban wrote: On 11/21/11 15:33, Nikolay Sivov wrote: On 11/21/2011 16:29, Jacek Caban wrote: On 11/21/11 15:16, Nikolay Sivov wrote: On 11/21/2011 16:09, Jacek Caban wrote: This doesn't seem to be the right approach. You need to return here interfaces of an object

Re: qedit/tests: Add SampleGrabber COM aggregation test.

2011-11-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15558 Your paranoid android

Re: [1/4] msxml3: Added common ISupportErrorInfo implementation

2011-11-21 Thread Jacek Caban
On 11/21/11 15:33, Nikolay Sivov wrote: On 11/21/2011 16:29, Jacek Caban wrote: On 11/21/11 15:16, Nikolay Sivov wrote: On 11/21/2011 16:09, Jacek Caban wrote: This doesn't seem to be the right approach. You need to return here interfaces of an object that inherits your ISupportErrorInfo im

Re: [1/4] msxml3: Added common ISupportErrorInfo implementation

2011-11-21 Thread Nikolay Sivov
On 11/21/2011 16:29, Jacek Caban wrote: On 11/21/11 15:16, Nikolay Sivov wrote: On 11/21/2011 16:09, Jacek Caban wrote: Hi Nikolay, On 11/21/11 08:24, Nikolay Sivov wrote: Added common ISupportErrorInfo implementation +/* common ISupportErrorInfo implementation */ +typedef struct { + IS

Re: [1/4] msxml3: Added common ISupportErrorInfo implementation

2011-11-21 Thread Jacek Caban
On 11/21/11 15:16, Nikolay Sivov wrote: On 11/21/2011 16:09, Jacek Caban wrote: Hi Nikolay, On 11/21/11 08:24, Nikolay Sivov wrote: Added common ISupportErrorInfo implementation +/* common ISupportErrorInfo implementation */ +typedef struct { + ISupportErrorInfo ISupportErrorInfo_iface;

Re: [1/4] msxml3: Added common ISupportErrorInfo implementation

2011-11-21 Thread Nikolay Sivov
On 11/21/2011 16:09, Jacek Caban wrote: Hi Nikolay, On 11/21/11 08:24, Nikolay Sivov wrote: Added common ISupportErrorInfo implementation +/* common ISupportErrorInfo implementation */ +typedef struct { + ISupportErrorInfo ISupportErrorInfo_iface; + LONG ref; + + const tid_t* iids; +}

Re: [1/4] msxml3: Added common ISupportErrorInfo implementation

2011-11-21 Thread Jacek Caban
Hi Nikolay, On 11/21/11 08:24, Nikolay Sivov wrote: Added common ISupportErrorInfo implementation +/* common ISupportErrorInfo implementation */ +typedef struct { + ISupportErrorInfo ISupportErrorInfo_iface; + LONG ref; + + const tid_t* iids; +} SupportErrorInfo; + +static inline Suppo

Re: user32/tests: Drop superfluous function pointer casts.

2011-11-21 Thread Michael Stefaniuc
Marvin wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=15553 >

Re: user32/tests: Drop superfluous function pointer casts.

2011-11-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15553 Your paranoid android

Re: [PATCH 1/1] user32: Fix 64-bit 'msg' test hang in test_timers.

2011-11-21 Thread Alexandre Julliard
"Erich E. Hoover" writes: > Real Name: >     Erich Hoover > > Description: >     The TestBot ran into a hanging issue (noticed with, but unrelated > to, my previous user32 patch) and I took some time today to track the > problem down. Currently, on the 64-bit test system the test_timers() > test