Re: dinput: Delete the static critical section when unloading the dll.

2011-11-16 Thread Vitaliy Margolen
On 11/16/2011 07:34 PM, Vitaliy Margolen wrote: On 11/16/2011 08:31 AM, Francois Gouget wrote: --- I moved DllMain() to the end of the file so it comes after the variable declaration. It's already forward declared few lines after DllMain(). So you should move that declaration instead. Hm... i

Re: dinput: Delete the static critical section when unloading the dll.

2011-11-16 Thread Vitaliy Margolen
On 11/16/2011 08:31 AM, Francois Gouget wrote: --- I moved DllMain() to the end of the file so it comes after the variable declaration. It's already forward declared few lines after DllMain(). So you should move that declaration instead. Hm... it seems this patch already committed. Alexadre,

Re: added remaining functions, data structures, definitions required by http api to include/http.h

2011-11-16 Thread Juan Lang
> That's a lot of stuff.  What needs it? It's also obviously incorrect in places. --Juan

re: added remaining functions, data structures, definitions required by http api to include/http.h

2011-11-16 Thread Dan Kegel
That's a lot of stuff. What needs it? Also, please avoid trivial whitespace changes.

Re: added remaining functions, data structures, definitions required by http api to include/http.h

2011-11-16 Thread Frédéric Delanoy
On Wed, Nov 16, 2011 at 14:15, ArasH wrote: > --- >  include/http.h | 1266 > +++- >  1 files changed, 1251 insertions(+), 15 deletions(-) The patch should show your full name. See http://wiki.winehq.org/SubmittingPatches for more information.

Re: [PATCH 2/2] mshtml: Added tests of handling ActiveX objects without IQuickActivate interface implemented

2011-11-16 Thread Alexandre Julliard
Jacek Caban writes: > --- > dlls/mshtml/tests/activex.c | 133 > ++ > 1 files changed, 95 insertions(+), 38 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so activex.c && touch activex.

Re: [PATCH 1/1] ws2_32: Selectively bind UDP sockets to interfaces while still allowing broadcast packets (try 2, resend).

2011-11-16 Thread Juan Lang
Hi Erich, + * Bind the given socket exclusively to a specific interface. I know the style around here is to comment minimally, but I didn't find it clear what the behavior of this function is. For one thing, +static int interface_bind( int fd, struct sockaddr *addr ) (snip) +int ret = FALSE

Re: mshtml: Fixed some htmldoc.c tests on IE9

2011-11-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15467 Your paranoid android

Re: mshtml: Fixed some htmldoc.c tests on IE9

2011-11-16 Thread Jacek Caban
On 11/16/11 13:50, Marvin wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.