Re: [PATCH 1/1] user32: Prioritize focus for dialog owner on EndDialog (resend).

2011-11-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15456 Your paranoid android

Re: [PATCH 2/5] d3d10: Implement D3D10StateBlockMaskDisableCapture().

2011-11-15 Thread Matteo Bruni
2011/11/15 Henri Verbeet : > --- > +UINT end = start_idx + count; > +    start_idx += 7; > +    memset(&field[start_idx >> 3], 0, (end >> 3) - (start_idx >> 3)); Isn't that dangerous if count is < 7 (assuming that is a valid value)?

Re: [2/4] ddraw: Add more tests and fixes for SetSurfaceDesc

2011-11-15 Thread Henri Verbeet
On 15 November 2011 23:23, Stefan Dösinger wrote: > On Tuesday 15 November 2011 20:53:43 Henri Verbeet wrote: >> It's probably ok to ignore the more obscure cases of getting an >> earlier interface through QI on a newer interface, but I think we >> should at least test version differences for inte

Re: [2/4] ddraw: Add more tests and fixes for SetSurfaceDesc

2011-11-15 Thread Stefan Dösinger
On Tuesday 15 November 2011 20:53:43 Henri Verbeet wrote: > It's probably ok to ignore the more obscure cases of getting an > earlier interface through QI on a newer interface, but I think we > should at least test version differences for interfaces originally > created with a particular version. K

Re: RFH: Solaris users with IPv6

2011-11-15 Thread Vit Hrachovy
Hi Juan, feel free to send me the patch, I'll test it. Regards Hark On 11/15/2011 09:08 PM, Juan Lang wrote: Hi all, in the tidy up I've been doing to iphlpapi, I notice that on Solaris it's possible to enumerate IPv6 addresses using SIOCGIFCONF. I've got a patch written that does that, but I h

RFH: Solaris users with IPv6

2011-11-15 Thread Juan Lang
Hi all, in the tidy up I've been doing to iphlpapi, I notice that on Solaris it's possible to enumerate IPv6 addresses using SIOCGIFCONF. I've got a patch written that does that, but I have no way to test it myself. If anyone here has some version of Solaris with a machine with IPv6 addresses, eve

Re: [2/4] ddraw: Add more tests and fixes for SetSurfaceDesc

2011-11-15 Thread Henri Verbeet
On 15 November 2011 20:28, Stefan Dösinger wrote: > In principle I agree, but handling this on a per-test basis won't work. The > behavior doesn't just depend on the interface version you call, but also the > version with which the object was created(see e.g. surface::GetDDInterface, > ddraw::Quer

Re: [2/4] ddraw: Add more tests and fixes for SetSurfaceDesc

2011-11-15 Thread Stefan Dösinger
On Tuesday 15 November 2011 15:19:20 Henri Verbeet wrote: > (E.g. does calling SetSurfaceDesc() with the original surface desc > work? That's a reasonable thing to test, I'll add it to the test(The answer is no, you can't set the original surface desc). > What about bits not in DDSD_ALL? Etc.) I

Re: (resend)[5/6]usp10: Devanagari danda and double danda are use for all Indic scripts

2011-11-15 Thread Aric Stewart
You are correct about the ones in is_indic, I can replace those with the Script_XX values. the other two meaning the WCHARs we are looking for? They are unicode points. In that regard they are explanatory as they are. Or i can add extra defines for them -aric On 11/15/11 10:03 AM, Henri

Re: (resend)[5/6]usp10: Devanagari danda and double danda are use for all Indic scripts

2011-11-15 Thread Henri Verbeet
That's a fair amount of magic constants in there. The ones in is_indic() are probably Script_Devanagari and Script_Malayalam_Numeric, I didn't look at the other two.

Re: [4/6] msxml3/dom: Properly return node prefix from get_prefix()

2011-11-15 Thread Nikolay Sivov
On 11/15/2011 14:43, Jacek Caban wrote: Hi Nikolay, On 11/15/11 07:19, Nikolay Sivov wrote: -if ((ns = xmlGetNsList(This->node->doc, This->node))) +switch (This->node->type) { -if (ns[0]->prefix) *prefix = bstr_from_xmlChar( ns[0]->prefix ); -xmlFree(ns); +ca

Re: msvcrt: Don't hold FILE critical section in some functions

2011-11-15 Thread Alexandre Julliard
Piotr Caban writes: > This function is not safe under Windows 7. I was testing it with > following program: > > static DWORD WINAPI block_stdin(void *arg) > { > _lock_file(stdout); > return 0; > } > > int main( ) > { > DWORD thread_id; > > CreateThread(NULL, 0, block_stdin

Re: msvcrt: Don't hold FILE critical section in some functions

2011-11-15 Thread Piotr Caban
On 11/15/11 16:34, Alexandre Julliard wrote: Piotr Caban writes: @@ -3117,25 +3098,20 @@ int CDECL MSVCRT_fputc(int c, MSVCRT_FILE* file) */ int CDECL MSVCRT__flsbuf(int c, MSVCRT_FILE* file) { -MSVCRT__lock_file(file); - /* Flush output buffer */ if(file->_bufsiz == 0&&

Re: msvcrt: Don't hold FILE critical section in some functions

2011-11-15 Thread Alexandre Julliard
Piotr Caban writes: > @@ -3117,25 +3098,20 @@ int CDECL MSVCRT_fputc(int c, MSVCRT_FILE* file) > */ > int CDECL MSVCRT__flsbuf(int c, MSVCRT_FILE* file) > { > -MSVCRT__lock_file(file); > - > /* Flush output buffer */ > if(file->_bufsiz == 0 && !(file->_flag & MSVCRT__IONBF)) { >

Re: wininet: Give a name to the critical sections, make them static and delete them when unloading the dll.

2011-11-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15430 Your paranoid android

Re: [4/4] ddraw: Size handling fixes for IDirect3DDevice::GetDesc

2011-11-15 Thread Henri Verbeet
On 15 November 2011 00:13, Stefan Dösinger wrote: > +if (!HWDesc) > +{ > +WARN("HWDesc is NULL, returning DDERR_INVALIDPARAMS.\n"); > +return DDERR_INVALIDPARAMS; > +} > +else if(!check_d3ddevicedesc_size(HWDesc->dwSize)) > +{ > +WARN("HWDesc->dwSize is

Re: [2/4] ddraw: Add more tests and fixes for SetSurfaceDesc

2011-11-15 Thread Henri Verbeet
On 15 November 2011 00:12, Stefan Dösinger wrote: > +/* Tests show that only LPSURFACE and PIXELFORMAT can be set, and > LPSURFACE is required > + * for PIXELFORMAT to work */ This may be ok, but note that the test doesn't actually test this. (E.g. does calling SetSurfaceDesc() with the o

Re: wined3d: Disable WINED3DFMT_B8G8R8_UNORM.

2011-11-15 Thread Stefan Dösinger
On Tuesday 15 November 2011 14:21:09 Matteo Bruni wrote: > +case WINED3DFMT_B8G8R8_UNORM: /* Usable in <=dx7 but not > enumerated in any case */ > +TRACE_(d3d_caps)("[FAILED] - Not enumerated on Windows\n"); > +return FALSE; The comment "Usable in <=dx7" is mislead

Re: [PATCH 1/2] ntdll: windows refuses to load an image, if sections overlap the header size as given in the SizeOfHeaders field (resend)

2011-11-15 Thread Alexandre Julliard
Bernhard Loos writes: > --- > dlls/kernel32/tests/loader.c | 79 > ++ > dlls/ntdll/virtual.c |5 +++ > 2 files changed, 84 insertions(+), 0 deletions(-) > > diff --git a/dlls/kernel32/tests/loader.c b/dlls/kernel32/tests/loader.c > index 4d4

Re: [PATCH 1/2] userenv: Improved CreateEnvironmentBlock implementation (try3)

2011-11-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15426 Your paranoid android

Re: [PATCH 1/2] userenv: Improved CreateEnvironmentBlock implementation (try2)

2011-11-15 Thread Piotr Caban
On 11/14/11 18:26, Alexandre Julliard wrote: Piotr Caban writes: +static void set_wow64_environment(WCHAR **env) +{ +static const WCHAR archW[]= {'P','R','O','C','E','S','S','O','R','_','A','R','C','H','I','T','E','C','T','U','R','E',0}; +static const WCHAR arch6432W[] = {'P','R'

Re: [PATCH 11/12] mshtml: Added more navigation tests

2011-11-15 Thread Jacek Caban
On 11/15/11 11:46, Marvin wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.

Re: [PATCH 11/12] mshtml: Added more navigation tests

2011-11-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15423 Your paranoid android

Re: [4/6] msxml3/dom: Properly return node prefix from get_prefix()

2011-11-15 Thread Jacek Caban
Hi Nikolay, On 11/15/11 07:19, Nikolay Sivov wrote: -if ((ns = xmlGetNsList(This->node->doc, This->node))) +switch (This->node->type) { -if (ns[0]->prefix) *prefix = bstr_from_xmlChar( ns[0]->prefix ); -xmlFree(ns); +case XML_ELEMENT_NODE: +case XML_ATTRIBUT

Re: [PATCH] urlmon: Improve parsing of SCHEME_MK URIs

2011-11-15 Thread Jacek Caban
Hi Andrew, On 11/14/11 21:12, Andrew Eikum wrote: --- dlls/urlmon/tests/uri.c | 81 +++ dlls/urlmon/uri.c | 15 +++-- 2 files changed, 93 insertions(+), 3 deletions(-) The patch looks good to me, but could you please add a simpler t

Re: ws2_32: Fix handling of NULL and empty hostname in getaddrinfo/GetAddrInfoW.

2011-11-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15418 Your paranoid android