Re: [PATCH 3/3] wined3d: Report all FBO-attachable formats as suitable for render target usage.

2011-11-09 Thread Matteo Bruni
2011/11/9 Matteo Bruni : > --- This patch is not correct, please ignore it...

Re: d3dx9_36/tests [patch 2/2, try 3]: Add tests for D3DXCreatePolygon

2011-11-09 Thread Rico Schüller
Am 09.11.2011 14:42, schrieb Matteo Bruni: 2011/11/9 David Adam: Better, but there are still issues: +if( polygon ) polygon->lpVtbl->Release(polygon); +if( ppBuffer ) ID3DXBuffer_Release(ppBuffer); You aren't setting those pointers to NULL (and your test shows that D3DXCreatePolygon doe

Strange window manager bug

2011-11-09 Thread Alex Henrie
Does anyone have an idea of what could be causing http://bugs.winehq.org/show_bug.cgi?id=29027 ? -Alex

Re: [3/3] winhttp: Convert string data to UTF-8 and add a corresponding content type header.

2011-11-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15333 Your paranoid android

Re: [1/2] Revert "msi: Use MsgWaitForMultipleObjectsEx to do waits."

2011-11-09 Thread Alexandre Julliard
Hans Leidekker writes: > This reverts commit 2556173f20ba9583044aaf31b16cbb2214d2b907. > It causes a regression in the Quicken 2011 installer. Does it really break because we are processing messages, or just because we don't wait properly? If so fixing the wait would seem a better choice. --

Re: d3dx9_36/tests [patch 2/2, try 3]: Add tests for D3DXCreatePolygon

2011-11-09 Thread Matteo Bruni
2011/11/9 David Adam : > Better, but there are still issues: +if( polygon ) polygon->lpVtbl->Release(polygon); +if( ppBuffer ) ID3DXBuffer_Release(ppBuffer); You aren't setting those pointers to NULL (and your test shows that D3DXCreatePolygon doesn't touch them when the call fails), so

Re: [PATCH 1/5] wined3d: Don't print FIXMEs for misaligned surface maps.

2011-11-09 Thread Stefan Dösinger
On Tuesday 08 November 2011 23:23:23 Henri Verbeet wrote: > On 8 November 2011 21:33, Stefan Dösinger wrote: > > On Tuesday 08 November 2011 20:48:55 Henri Verbeet wrote: > >> -FIXME("Partial block lock with %s\n", > >> debug_d3dpool(surface->resource.pool)); > > > > I added t

Re: winspool.drv: Correct test for Device Capabilities (resend)

2011-11-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15332 Your paranoid android

Re: mscoree: Implement ICorDebug CreateProcess (try 2)

2011-11-09 Thread Alexandre Julliard
Alistair Leslie-Hughes writes: > Hi, > Move DuplicateHandle to Create_Process. > Added Makefile.in (missing from first patch) > > Changelog: > mscoree: Implement ICorDebug CreateProcess You should put everything in cordebug.c, there's no need to have a separate file. -- Alexandre Julliard

Re: [1/4] ddraw/tests: Add a test for YV12 partial block locks and lock offsets

2011-11-09 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, It looks like the testbot has issues with the ö in my name: error: while searching for: /* * Unit tests for DirectDraw overlay functions * * Copyright (C) 2008 Stefan D�singer for CodeWeavers * * This library is free software; you can redist