Fwd: d3dx9_36 [patch 1/2, resent]: Implement D3DXCreatePolygon

2011-11-07 Thread David Adam
Hello, any problem with this patch http://source.winehq.org/patches/data/80433 and this one http://source.winehq.org/patches/data/80434 Thanks in advance David -- Forwarded message -- From: David Adam Date: 2011/10/30 Subject: d3dx9_36 [patch 1/2, resent]: Implement D3DXCreate

Re: [10/11] ddraw/tests: Add assorted D3D3 DrawPrimitive/visual tests.

2011-11-07 Thread Stefan Dösinger
Hi, Design-wise I think the 8 triangles and readback grid make the test fairly difficult to read. You could set up a structure that contains the d3d parameters you're changing between the tests and the expected color and then loop over the table. Something like this: const struct { BO

Re: winscard/tests: Add the tests file (try 3)

2011-11-07 Thread Bruno Jesus
On Mon, Oct 31, 2011 at 23:27, Bruno Jesus <00cp...@gmail.com> wrote: > try 3 - avoid magic constants by using winscard.h defines > try 2 - split the patches and fix win2000 error > > This is the starting point for the winscard implementation. I'll add > dozens of tests and I would like all of them

Re: [PATCH 3/6] [UnInstall]: No longer use unix stdio functions, but the kernel32 equivalent

2011-11-07 Thread Alexandre Julliard
Eric Pouech writes: > do you consider it's the same for winepath and winetest (number 5& 6 > in patchset) ? or shall I resubmit the remaining two ? It's the same for winepath, yes. winetest is probably OK to change. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 3/6] [UnInstall]: No longer use unix stdio functions, but the kernel32 equivalent

2011-11-07 Thread Eric Pouech
Le 07/11/2011 14:12, Alexandre Julliard a écrit : Eric Pouech writes: #28185 A+ --- programs/uninstaller/main.c | 65 ++- 1 files changed, 46 insertions(+), 19 deletions(-) I'm not sure that's a good idea. The output of uninstaller is meant to be

Re: winealsa: Don't set ALSA's period time.

2011-11-07 Thread Alexandre Julliard
joerg-cyril.hoe...@t-systems.com writes: > Hi, > > perhaps I shouldn't send this one day before release... > > I argue that Wine has no business setting ALSA's period size, > esp. not to a completely random value like duration/10. It doesn't work here: ../../../tools/runtest -q -P wine -M dsound

Re: cmd: Add helper for 'if' comparison operations evaluation (try 2)

2011-11-07 Thread Frédéric Delanoy
On Mon, Nov 7, 2011 at 11:21, Octavian Voicu wrote: > 2011/11/7 Frédéric Delanoy : >> +    /* Note: '==' can't be returned by WCMD_parameter since '=' is a >> separator */ >> +    p = paramEnd + 1; >> +    while (*p == ' ' || *p == '\t') >> +      p++; >> + >> +    if (!p || *p != '=' || !(p+1) |

Re: [PATCH 3/6] [UnInstall]: No longer use unix stdio functions, but the kernel32 equivalent

2011-11-07 Thread Alexandre Julliard
Eric Pouech writes: > #28185 > > A+ > --- > > programs/uninstaller/main.c | 65 > ++- > 1 files changed, 46 insertions(+), 19 deletions(-) I'm not sure that's a good idea. The output of uninstaller is meant to be used by Unix apps, it's not something a

Re: [2/2] mscoree: Implement ICorDebug CreateProcess

2011-11-07 Thread Alexandre Julliard
Alistair Leslie-Hughes writes: > +{ > +HANDLE handle, thread; > +DuplicateHandle(GetCurrentProcess(), lpProcessInformation->hProcess, > +GetCurrentProcess(), &handle, 0, FALSE, > DUPLICATE_SAME_ACCESS); > +DuplicateHandle(GetCurrentProcess(), l

Re: [1/2] ntdll: Setting WRITECOPY protection on an image section is allowed.

2011-11-07 Thread Alexandre Julliard
Dmitry Timoshkov writes: > These tests have been copied from a similar VirtualAlloc ones. I'll see > what can be done for the file mapping tests. I mean testing VirtualAlloc itself. It also takes protection flags. -- Alexandre Julliard julli...@winehq.org

Re: [1/2] ntdll: Setting WRITECOPY protection on an image section is allowed.

2011-11-07 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > This patch should fix the regression reported in the bug 28994. > > This needs more test cases, in particular for normal file mappings, as > well as for VirtualAlloc behavior. These tests have been copied from a similar VirtualAlloc ones. I'll see what can be done

Re: [1/2] ntdll: Setting WRITECOPY protection on an image section is allowed.

2011-11-07 Thread Alexandre Julliard
Dmitry Timoshkov writes: > This patch should fix the regression reported in the bug 28994. This needs more test cases, in particular for normal file mappings, as well as for VirtualAlloc behavior. -- Alexandre Julliard julli...@winehq.org

Re: cmd: Add helper for 'if' comparison operations evaluation (try 2)

2011-11-07 Thread Octavian Voicu
2011/11/7 Frédéric Delanoy : > +    /* Note: '==' can't be returned by WCMD_parameter since '=' is a > separator */ > +    p = paramEnd + 1; > +    while (*p == ' ' || *p == '\t') > +      p++; > + > +    if (!p || *p != '=' || !(p+1) || *(p+1) != '=') > +      goto syntax_err; > + > +    strcpyW(