Re: [1/2] kernel32/tests: add tests for GetDllDirectoryA

2011-11-06 Thread Thomas Faber
On 2011-11-06 18:04, Vitaliy Margolen wrote: > On 11/06/2011 09:14 AM, Thomas Faber wrote: >> > >> +length = strlen(dll_directories[i]); >> +assert(sizeof(buffer) > length + 1); > Please don't do this. Tests shouldn't assert because programmer failed to > pick the right buffer siz

Re: [1/2] kernel32/tests: add tests for GetDllDirectoryA

2011-11-06 Thread Vitaliy Margolen
On 11/06/2011 09:14 AM, Thomas Faber wrote: +length = strlen(dll_directories[i]); +assert(sizeof(buffer) > length + 1); Please don't do this. Tests shouldn't assert because programmer failed to pick the right buffer size of hard-coded strings. +ok(GetLastError() ==

Re: [1/2] kernel32/tests: add tests for GetDllDirectoryA

2011-11-06 Thread Vitaliy Margolen
On 11/06/2011 09:30 AM, Thomas Faber wrote: Hey, On 2011-11-06 17:25, Vincent Povirk wrote: I don't think you can rely on C:\Windows existing. indeed. :) But the function only requires valid path syntax, not a path that actually exists. Then you should be explicit about it with a path like "

Re: [1/2] kernel32/tests: add tests for GetDllDirectoryA

2011-11-06 Thread Thomas Faber
Hey, On 2011-11-06 17:25, Vincent Povirk wrote: > I don't think you can rely on C:\Windows existing. indeed. :) But the function only requires valid path syntax, not a path that actually exists. I guess I could have made that clearer -- but C:\Windows is as good a path as any I suppose. Thanks.

Re: [1/2] kernel32/tests: add tests for GetDllDirectoryA

2011-11-06 Thread Vincent Povirk
I don't think you can rely on C:\Windows existing. On Sun, Nov 6, 2011 at 10:14 AM, Thomas Faber wrote: > > > >