Re: [3/4] d3d9/tests: Test partial block locks

2011-10-31 Thread Stefan Dösinger
On Monday 31 October 2011 21:10:41 Henri Verbeet wrote: > On 31 October 2011 20:03, Stefan Dösinger wrote: > > +case D3DPOOL_SCRATCH: > > +case D3DPOOL_SYSTEMMEM: > > +hr = > > IDirect3DDevice9_CreateOffscreenPlainSurface(device, 128, 128, > > fo

Re: ddraw/tests: Move some surface attachment tests from refcount to dsurface and enhance them.

2011-10-31 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15183 Your paranoid android

Re: [4/4] wined3d: YUY2 and UYVY are block based

2011-10-31 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15193 Your paranoid android

Re: [PATCH 2/5] wined3d: Create the DIB section for DDSCAPS_OWNDC surfaces on initialization.

2011-10-31 Thread Stefan Dösinger
On Monday 31 October 2011 21:06:09 Henri Verbeet wrote: > Probably in general. The way GetDC is supposed to work is probably by > asking the graphics driver to create a DC on top of the existing > memory or texture, instead of the DIB section hacks we do in wined3d. In the days of the old ddraw cod

Re: [3/4] d3d9/tests: Test partial block locks

2011-10-31 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15192 Your paranoid android

Re: [3/4] d3d9/tests: Test partial block locks

2011-10-31 Thread Henri Verbeet
On 31 October 2011 20:03, Stefan Dösinger wrote: > +case D3DPOOL_SCRATCH: > +case D3DPOOL_SYSTEMMEM: > +hr = > IDirect3DDevice9_CreateOffscreenPlainSurface(device, 128, 128, formats[i].fmt, > +D3DPOOL_SCRATCH, &surfac

Re: [4/4] wined3d: YUY2 and UYVY are block based

2011-10-31 Thread Henri Verbeet
On 31 October 2011 20:17, Stefan Dösinger wrote: > {WINED3DFMT_ATI2N, > GL_COMPRESSED_LUMINANCE_ALPHA_3DC_ATI, GL_COMPRESSED_LUMINANCE_ALPHA_3DC_ATI, > 0, > GL_LUMINANCE_ALPHA, GL_UNSIGNED_BYTE, 0, > -WINED3DFMT_FLAG_POSTPIXE

Re: [PATCH 2/5] wined3d: Create the DIB section for DDSCAPS_OWNDC surfaces on initialization.

2011-10-31 Thread Henri Verbeet
On 31 October 2011 20:38, Stefan Dösinger wrote: > You would get the same effect by calling GetDC and ReleaseDC from ddraw or > ddrawex without another usage flag. Yes, but I don't think that would be an improvement. >> +    /* Similar to lockable rendertargets above, creating the DIB section >>

Re: [PATCH 2/5] wined3d: Create the DIB section for DDSCAPS_OWNDC surfaces on initialization.

2011-10-31 Thread Stefan Dösinger
On Monday 31 October 2011 19:48:12 Henri Verbeet wrote: > --- > dlls/ddraw/surface.c |3 +++ > dlls/wined3d/surface.c | 11 +++ > include/wine/wined3d.h |1 + > 3 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c > ind

Re: [PATCH 4/5] wined3d: Make the buffer parameter to buffer_is_dirty() const.

2011-10-31 Thread Henri Verbeet
On 31 October 2011 19:56, Josh Juran wrote: > Looks like you lost an 'inline'.  Was that intentional? > Yes.

Re: [PATCH 4/5] wined3d: Make the buffer parameter to buffer_is_dirty() const.

2011-10-31 Thread Josh Juran
On Oct 31, 2011, at 11:48 AM, Henri Verbeet wrote: > --- > dlls/wined3d/buffer.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/wined3d/buffer.c b/dlls/wined3d/buffer.c > index 45518cc..69c110a 100644 > --- a/dlls/wined3d/buffer.c > +++ b/dlls/wined3d/buffer.

Re: 80199: shdocvw: add a stub for InstallReg_RunDLL

2011-10-31 Thread Austin English
On Thu, Oct 20, 2011 at 15:55, Dan Kegel wrote: > Fails to build here? > > On Thu, Oct 20, 2011 at 3:51 PM,   wrote: >> This is an experimental automated build and test service. >> Please feel free to ignore this email while we work the kinks out. >> >> For more info about this message, see http:/

Re: [PATCH 2/5] ddraw: Implement copy_mipmap_chain() on top of wined3d_surface_blt().

2011-10-31 Thread Henri Verbeet
On 31 October 2011 15:04, Stefan Dösinger wrote: > On Sunday 30 October 2011 18:06:33 Henri Verbeet wrote: >> +            if (FAILED(hr = >> wined3d_surface_blt(dest_level->wined3d_surface, &dst_rect, >> +                    src_level->wined3d_surface, &src_rect, 0, NULL, >> WINED3DTEXF_POINT)))

Re: [PATCH 2/5] ddraw: Implement copy_mipmap_chain() on top of wined3d_surface_blt().

2011-10-31 Thread Stefan Dösinger
On Sunday 30 October 2011 18:06:33 Henri Verbeet wrote: > +if (FAILED(hr = > wined3d_surface_blt(dest_level->wined3d_surface, &dst_rect, > +src_level->wined3d_surface, &src_rect, 0, NULL, > WINED3DTEXF_POINT))) Wouldn't wined3d_device_update_surface be a better match