Re: cmd: Avoid mixing signed and unsigned type in conditional expression

2011-10-26 Thread Eric Pouech
why do we check for ptr being null or not, when we deref ptr one line above ? something's wrong in the code logic A+ Le 27 octobre 2011 04:53, Frédéric Delanoy a écrit : > --- > programs/cmd/wcmdmain.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/programs/cmd/w

Re: basic_ifstream implementation

2011-10-26 Thread Octavian Voicu
On Thu, Oct 27, 2011 at 2:01 AM, Josh Juran wrote: >  @ stub -arch=win64 > ??0?$basic_ifstream@DU?$char_traits@D@std@@@std@@QEAA@PEBDHH@Z >  @ stub -arch=win64 ??_D?$basic_ifstream@DU?$char_traits@D@std@@@std@@QEAAXXZ You forgot to update the win64 stubs in the spec file. Octavian

Re: basic_ifstream implementation

2011-10-26 Thread Josh Juran
On Oct 26, 2011, at 11:59 AM, Josh Juran wrote: > I'm ready to begin work on a basic_ifstream implementation for Wine, which is > needed for the game Vampire Secrets among others. > > http://bugs.winehq.org/show_bug.cgi?id=28612 > > First I'd like to check that Piotr isn't already working on th

Re: [PATCH 1/3] widl: teach widl how to automatically create class factories (resend)

2011-10-26 Thread Bernhard Loos
On Tue, Oct 25, 2011 at 6:11 PM, Dan Kegel wrote: > Hi Bernhard, > build fails here: > widl.o: In function `write_dlldata': > /home/bob/wineslave.dir/sandbox/slave/runtests-default/build/tools/widl/widl.c:423: > undefined reference to `write_dlldata_list' > widl.o: In function `main': > /home/bob/

basic_ifstream implementation

2011-10-26 Thread Josh Juran
I'm ready to begin work on a basic_ifstream implementation for Wine, which is needed for the game Vampire Secrets among others. http://bugs.winehq.org/show_bug.cgi?id=28612 First I'd like to check that Piotr isn't already working on this. If not, I'm open to any advice on how to proceed. My p

Re: winscard/tests: Add the tests file

2011-10-26 Thread Bruno Jesus
On Wed, Oct 26, 2011 at 11:38, Marvin wrote: > === W2KPROSP4 (32 bit winscard) === > winscard.c:53: Test failed: SCardIsValidContext expected > SCARD_E_INVALID_HANDLE, received 0006 > winscard.c:64: Test failed: SCardReleaseContext expected > SCARD_E_INVALID_HANDLE, received 0006 > It l

Re: winscard/tests: Add the tests file

2011-10-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15123 Your paranoid android

Re: [PATCH 1/3] widl: teach widl how to automatically create class factories (resend)

2011-10-26 Thread Dan Kegel
On Wed, Oct 26, 2011 at 4:48 AM, Bernhard Loos wrote: > This means tools/widl/Makefile wasn't regenerated. > But the changes to Makefile.in are there, so it's a problem with your system. Hmm. Thanks, I'll have a look. - Dan

Re: [PATCH 2/2] d3dx9/test: Fix typo.

2011-10-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15120 Your paranoid android

Re: [PATCH 1/2] d3dx9: Improve argument check in D3DXFindShaderComment().

2011-10-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15119 Your paranoid android

Re: include: Remove 'l' modifier from numeric constants in d3d9caps.h

2011-10-26 Thread Kai Tietz
2011/10/26 Dmitry Timoshkov : > Chris Robinson wrote: > >> For Wine it doesn't really matter, since we can't use C++. For mingw-w64, >> however, it could be a big problem if it's not properly typed as a long. >> Overloads and template types would silently use 'int' where it should be >> using >>

Re: include: Remove 'l' modifier from numeric constants in d3d9caps.h

2011-10-26 Thread Dmitry Timoshkov
Chris Robinson wrote: > For Wine it doesn't really matter, since we can't use C++. For mingw-w64, > however, it could be a big problem if it's not properly typed as a long. > Overloads and template types would silently use 'int' where it should be > using > 'long', and you wouldn't necessaril

Re: include: Remove 'l' modifier from numeric constants in d3d9caps.h

2011-10-26 Thread Chris Robinson
On Wednesday, October 26, 2011 12:35:28 PM Michael Stefaniuc wrote: > Chris Robinson wrote: > > imagine some C++ function overrides tripping up with the int/long > > difference. > If you use the Wine headers this should actually fix it as it brings the > numeric constants in line with the types as

Re: include: Remove 'l' modifier from numeric constants in d3d9caps.h

2011-10-26 Thread Michael Stefaniuc
Chris Robinson wrote: > On Wednesday, October 26, 2011 12:17:22 PM Michael Stefaniuc wrote: >> Hello Jacek! >> >> Jacek Caban wrote: >>> mingw-w64 project imports some of our headers, including most of d3d >>> headers. They would probably prefer to keep them with 'l' modifier since >>> that's the r

Re: include: Remove 'l' modifier from numeric constants in d3d9caps.h

2011-10-26 Thread Chris Robinson
On Wednesday, October 26, 2011 12:17:22 PM Michael Stefaniuc wrote: > Hello Jacek! > > Jacek Caban wrote: > > mingw-w64 project imports some of our headers, including most of d3d > > headers. They would probably prefer to keep them with 'l' modifier since > > that's the right thing to do. Given th

Re: include: Remove 'l' modifier from numeric constants in d3d9caps.h

2011-10-26 Thread Kai Tietz
2011/10/26 Michael Stefaniuc : > Hello Jacek! > > Jacek Caban wrote: >> On 10/26/11 00:30, Michael Stefaniuc wrote: >>> --- >>>   include/d3d9caps.h |  182 >>> ++-- >>>   1 files changed, 91 insertions(+), 91 deletions(-) >>> >>> diff --git a/include/

Re: include: Remove 'l' modifier from numeric constants in d3d9caps.h

2011-10-26 Thread Michael Stefaniuc
Hello Jacek! Jacek Caban wrote: > On 10/26/11 00:30, Michael Stefaniuc wrote: >> --- >> include/d3d9caps.h | 182 >> ++-- >> 1 files changed, 91 insertions(+), 91 deletions(-) >> >> diff --git a/include/d3d9caps.h b/include/d3d9caps.h >> index 8e

Re: include: Remove 'l' modifier from numeric constants in d3d9caps.h

2011-10-26 Thread Jacek Caban
Hi Michael, On 10/26/11 00:30, Michael Stefaniuc wrote: --- include/d3d9caps.h | 182 ++-- 1 files changed, 91 insertions(+), 91 deletions(-) diff --git a/include/d3d9caps.h b/include/d3d9caps.h index 8ed6598..64dba21 100644 --- a/include/d3d9

winealsa: 6 Channel Audio

2011-10-26 Thread Joerg-Cyril . Hoehle
Hi, Andrew Eikum wrote: > > A configuration option (in winecfg/control panel) [...] > My reaction to this is "urrrghhh". >Tucking stuff away in the registry makes it a pain to screw >up their config, which means they'll probably turn to submitting bug >reports with the default config firs

Re: D3DXCreatePolygon

2011-10-26 Thread Frédéric Delanoy
On Tue, Oct 25, 2011 at 08:10, paulo lesgaz wrote: > Hello, > any problem with my D3DXCreatePolygon patch? > Thanks in advance. > David Don't see it on wine-patches, or http://source.winehq.org/patches/ Did you subscribe to wine-patches? Also, avoid HTML mail on wine mailing lists BTW the name