Re: winealsa: 6 Channel Audio

2011-10-23 Thread Chris Robinson
On Sunday, October 23, 2011 8:28:45 PM Jonathan McCrohan wrote: > Would someone with a better knowledge of Wine and/or ALSA be able to > assist me in tracking down the source of this bug? Hi. Part of the problem is the way Wine attempts to "detect" a default format from ALSA. ALSA doesn't report

Re: winmm: Avoid casting return value of Heap(Re)Alloc calls.

2011-10-23 Thread Dan Kegel
On Sun, Oct 23, 2011 at 3:18 PM, Austin English wrote: > This has come up a few times before, and it's already been discussed, > -Werror will not go in by default. Well, yes, several times, but I wasn't sure if that was a "never under any circumstances", or if the objections could be picked off o

Re: winmm: Avoid casting return value of Heap(Re)Alloc calls.

2011-10-23 Thread Austin English
On Sun, Oct 23, 2011 at 08:43, Dan Kegel wrote: > Debugged version: > > --- a/configure.ac > +++ b/configure.ac > @@ -1715,6 +1715,20 @@ then >   if test "x$enable_maintainer_mode" = "xyes" >   then >       WINE_TRY_CFLAGS([-Werror]) > +  else > +    dnl Enable -Werror when building from git on 32

Re: riched20: explicitly cast WPARAM to character types

2011-10-23 Thread David Laight
On Sun, Oct 23, 2011 at 09:25:26PM +0200, Michael Stefaniuc wrote: > > No clue anyway why MSVC even warns, integer to integer conversions are > allowed. ... Generally better to turn off MSVC's over-pedantic warnings about integer conversions. Using casts for integer convertions can actually hide

winealsa: 6 Channel Audio

2011-10-23 Thread Jonathan McCrohan
Hi, Using foobar2000 (Wine 1.3.31) to output 6 channel audio via WASAPI, I get an error in foobar2000, and the following Wine errors in the terminal: fixme:alsa:AudioClient_GetMixFormat Don't know what to do with 1 channels, pretending there's only 2 channels However, when using a patched ve

Re: riched20: explicitly cast WPARAM to character types

2011-10-23 Thread Michael Stefaniuc
On 10/22/2011 10:38 PM, Thomas Faber wrote: > This makes the use of casts more consistent and shows the conversion > from WPARAM to CHAR/WCHAR is intentional for WM_CHAR/EM_SETPASSWORDCHAR. > Also fixes two MSVC warnings. To make it consistent remove the WCHAR cast 3 lines above. Casts are *not* th

Re: winmm: Avoid casting return value of Heap(Re)Alloc calls.

2011-10-23 Thread Michael Stefaniuc
On 10/23/2011 02:41 PM, Dan Kegel wrote: > 2011/10/22 Frédéric Delanoy : >> OK thx. Should probably restructure that section as well (and add >> -Werror to my CFLAGS) > > How would people feel if configure turned on -Werror > when it's safe to if building from git? Something like this: This isn't

Re: [3/6] dinput: SetActionMap saving simple configurations to an .ini file

2011-10-23 Thread Vitaliy Margolen
Few nit picks. On 10/22/2011 02:53 PM, Lucas Fialho Zawacki wrote: +static void _write_private_profile_intW(const char *format, WCHAR* section, WCHAR* key, int value, WCHAR* file) +{ +WCHAR* value_str = heap_printfW(format, value); Here and everywhere else you not checking if memory alloca

Re: Compilation error when cross-compiling Wine to ARM.

2011-10-23 Thread Alexandre Julliard
Roger Cruz writes: > I'm attempting to cross-compile Wine for ARM and during the > compilation of the first file, I get the following error about some > strings.h routines not being portable.  I have tracked this down to > the redefinitions for these routines in include/port.h. Probably you shou

Re: Compilation error when cross-compiling Wine to ARM.

2011-10-23 Thread Roger Cruz
Yes, exactly. So far so good with their toolchain except for this redefinition of routines. It looks like it needs some architecture specific implementations of these routines. Thanks Roger R. Cruz On Oct 23, 2011, at 12:07 PM, André Hentschel wrote: > Am 22.10.2011 20:07, schrieb Roger C

Re: riched20: do not return incorrect values from ME_CharFromPoint[Cursor]

2011-10-23 Thread Thomas Faber
Hi, On 2011-10-22 22:45, Thomas Faber wrote: > Windows's version of GetTextExtentExPointW, which is called in that function, > returns a value of 1 in this case (Wine's does not, which would appear to be > a bug), leading to the "i control. this description isn't 100% complete (the fix is correct

Re: Compilation error when cross-compiling Wine to ARM.

2011-10-23 Thread André Hentschel
Am 22.10.2011 20:07, schrieb Roger Cruz: > I'm attempting to cross-compile Wine for ARM and during the compilation of > the first file, I get the following error about some strings.h routines not > being portable. I have tracked this down to the redefinitions for these > routines in include/por

Re: winmm: Avoid casting return value of Heap(Re)Alloc calls.

2011-10-23 Thread Dan Kegel
Debugged version: --- a/configure.ac +++ b/configure.ac @@ -1715,6 +1715,20 @@ then if test "x$enable_maintainer_mode" = "xyes" then WINE_TRY_CFLAGS([-Werror]) + else +dnl Enable -Werror when building from git on 32 bit x86 with a known good version of gcc +case $host_cpu in

Re: winmm: Avoid casting return value of Heap(Re)Alloc calls.

2011-10-23 Thread Dan Kegel
2011/10/23 Jerome Leclanche : >> How would people feel if configure turned on -Werror >> when it's safe to if building from git? Something like this... > > It's still unsafe, you're limited to a subset of gcc versions. That's not too hard to check for: --- a/configure.ac +++ b/configure.ac @@ -1

Re: winmm: Avoid casting return value of Heap(Re)Alloc calls.

2011-10-23 Thread Jerome Leclanche
2011/10/23 Dan Kegel : > 2011/10/22 Frédéric Delanoy : >> OK thx. Should probably restructure that section as well (and add >> -Werror to my CFLAGS) > > How would people feel if configure turned on -Werror > when it's safe to if building from git?  Something like this: > > --- a/configure.ac > +++

Re: winmm: Avoid casting return value of Heap(Re)Alloc calls.

2011-10-23 Thread Dan Kegel
2011/10/22 Frédéric Delanoy : > OK thx. Should probably restructure that section as well (and add > -Werror to my CFLAGS) How would people feel if configure turned on -Werror when it's safe to if building from git? Something like this: --- a/configure.ac +++ b/configure.ac @@ -1715,6 +1715,16 @@

Re: Patch resend etiquette

2011-10-23 Thread Frédéric Delanoy
On Sat, Oct 22, 2011 at 19:49, Austin English wrote: > On Sat, Oct 22, 2011 at 10:48, Erich Hoover wrote: >> How long should one wait to resend patches marked as "New" on the >> patch list?  It seems that once they've gone "far enough" down on the >> list that there's no chance they'll be looked