Re: 79921: ntdll: Move adding VPROT_READ for Solaris to the same place where it's done for FreeBSD. Take 2.

2011-10-13 Thread Dmitry Timoshkov
Dan Kegel wrote: > Fails to apply here: > $ patch -p1 < vprot.patch > patching file dlls/ntdll/virtual.c > Hunk #1 FAILED at 187. > 1 out of 2 hunks FAILED -- saving rejects to file dlls/ntdll/virtual.c.rej Becuase it depends on the 1/2 patch sent before. -- Dmitry.

Re: 79921: ntdll: Move adding VPROT_READ for Solaris to the same place where it's done for FreeBSD. Take 2.

2011-10-13 Thread Dan Kegel
Fails to apply here: $ patch -p1 < vprot.patch patching file dlls/ntdll/virtual.c Hunk #1 FAILED at 187. 1 out of 2 hunks FAILED -- saving rejects to file dlls/ntdll/virtual.c.rej On Thu, Oct 13, 2011 at 10:02 PM, wrote: > This is an experimental automated build and test service. > Please feel f

Re: [6/6] wined3d: Catch nop palette updates

2011-10-13 Thread Henri Verbeet
On 13 October 2011 20:40, Stefan Dösinger wrote: > On Thursday 13 October 2011 14:40:23 Henri Verbeet wrote: >> This looks questionable. Which applications does this help? > Age of Empires 2. It uploads the same palette regularly, which makes the main > menu quite unresponsive. > What makes it slo

Re: [3/6] wined3d: Use the destination palette when blitting between P8 surfaces

2011-10-13 Thread Henri Verbeet
On 13 October 2011 21:15, Stefan Dösinger wrote: > On Thursday 13 October 2011 14:40:09 Henri Verbeet wrote: >> Which makes much more sense. > And is the plan for offscreen P8 surfaces. It won't work for blits to the > frontbuffer(at the moment) or for the non-shader P8 surface conversion. > The p

Re: [2/6] wined3d: Pass the destination surface to blitters

2011-10-13 Thread Henri Verbeet
On 13 October 2011 20:58, Stefan Dösinger wrote: > What does the interface you plan look like? > It's mostly a matter of getting rid of set_shader() / unset_shader() and introducing calls for doing color and depth blits. This shouldn't be much of a surprise, I'm pretty sure we looked at this when

Re: [1/6] wined3d: YUV formats are block-based

2011-10-13 Thread Stefan Dösinger
On Thursday 13 October 2011 14:39:38 Henri Verbeet wrote: > On 13 October 2011 01:07, Stefan Dösinger wrote: > > diff --git a/dlls/d3d9/tests/surface.c b/dlls/d3d9/tests/surface.c > > diff --git a/dlls/ddraw/tests/overlay.c b/dlls/ddraw/tests/overlay.c > > These tests don't prove anything, they

Re: [3/6] wined3d: Use the destination palette when blitting between P8 surfaces

2011-10-13 Thread Stefan Dösinger
On Thursday 13 October 2011 14:40:09 Henri Verbeet wrote: > On 13 October 2011 01:07, Stefan Dösinger wrote: > > Native transfers the 8 bit data without modifications to the destination > > surface and does the palette lookup when showing the final front buffer > > contents on the screen. > > Whi

Re: [2/6] wined3d: Pass the destination surface to blitters

2011-10-13 Thread Stefan Dösinger
On Thursday 13 October 2011 14:39:58 Henri Verbeet wrote: > On 13 October 2011 01:07, Stefan Dösinger wrote: > > -static HRESULT arbfp_blit_set(void *blit_priv, struct wined3d_context > > *context, struct wined3d_surface *surface) + static HRESULT > > arbfp_blit_set(void *blit_priv, struct wined3d

Re: [6/6] wined3d: Catch nop palette updates

2011-10-13 Thread Stefan Dösinger
On Thursday 13 October 2011 14:40:23 Henri Verbeet wrote: > This looks questionable. Which applications does this help? Age of Empires 2. It uploads the same palette regularly, which makes the main menu quite unresponsive. signature.asc Description: This is a digitally signed message part.

Re: wined3d: Refuse to create a shader unsupported by the backend.

2011-10-13 Thread Alexandre Julliard
Matteo Bruni writes: > --- > dlls/d3d9/tests/shader.c | 22 -- > dlls/wined3d/device.c |2 ++ > dlls/wined3d/shader.c | 19 +++ > dlls/wined3d/wined3d_private.h |1 + > 4 files changed, 42 insertions(+), 2 deletions(-) It b

Re: [3/6] wined3d: Use the destination palette when blitting between P8 surfaces

2011-10-13 Thread Henri Verbeet
On 13 October 2011 01:07, Stefan Dösinger wrote: > Native transfers the 8 bit data without modifications to the destination > surface and does the palette lookup when showing the final front buffer > contents on the screen. Which makes much more sense.

Re: [Wine] WineHQ database compromise

2011-10-13 Thread Marcus Meissner
On Thu, Oct 13, 2011 at 10:23:58AM +0200, Maarten Lankhorst wrote: > Hey, > > On 10/12/2011 12:46 AM, Josh Juran wrote: > > On Oct 11, 2011, at 3:37 PM, Conan Kudo (ニール・ゴンパ) wrote: > > > >> On Tue, Oct 11, 2011 at 3:39 PM, Josh Juran wrote: > >> > >>> Since bugzilla passwords were sent in clearte

Re: [6/6] wined3d: Catch nop palette updates

2011-10-13 Thread Henri Verbeet
This looks questionable. Which applications does this help?

Re: [2/6] wined3d: Pass the destination surface to blitters

2011-10-13 Thread Henri Verbeet
On 13 October 2011 01:07, Stefan Dösinger wrote: > -static HRESULT arbfp_blit_set(void *blit_priv, struct wined3d_context > *context, struct wined3d_surface *surface) > + static HRESULT arbfp_blit_set(void *blit_priv, struct wined3d_context > *context, struct wined3d_surface *src, > + co

Re: [1/6] wined3d: YUV formats are block-based

2011-10-13 Thread Henri Verbeet
On 13 October 2011 01:07, Stefan Dösinger wrote: > diff --git a/dlls/d3d9/tests/surface.c b/dlls/d3d9/tests/surface.c > diff --git a/dlls/ddraw/tests/overlay.c b/dlls/ddraw/tests/overlay.c These tests don't prove anything, they pass on current Wine as well. > +{WINED3DFMT_YUY2, 2, 1, 4,

Re: [PATCH 5/5] server/named_pipe.c: remove the ps_disconnected_server state, if DisconnectNamedPipe is called, the server i

2011-10-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14877 Your paranoid android

Re: [PATCH 4/5] kernel32, ntdll: implement most of GetNamedPipeHandleState (try 3)

2011-10-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14876 Your paranoid android

Re: For review please: wineps.drv: Implement PS_USERSTYLE on printers

2011-10-13 Thread Bruno Jesus
Hi, Daniel. On Thu, Oct 13, 2011 at 06:14, Daniel wrote: > Hello guys.  I would like to get a little review on this patch, a follow > up to the patches that fix this problem on the screen.  Specifically, > I'm most concerned about making sure my dynamically allocated memory is > freed under all c

Re: wined3d: recognize "Brian Paul" as a mesa card vendor

2011-10-13 Thread Henri Verbeet
On 13 October 2011 02:23, Austin English wrote: > See http://bugs.winehq.org/show_bug.cgi?id=28684 / > http://cgit.freedesktop.org/mesa/mesa/tree/src/mesa/main/getstring.c#n88 > Yeah, this makes sense. You'd probably mostly run into this if you're not using the regular dri based drivers, but that'

Re: ddraw: Keep track of interface attached by AddAttachedSurface and detach correct interface when parent is released. (try 3)

2011-10-13 Thread Henri Verbeet
On 13 October 2011 10:12, Saulius Krasuckas wrote: >  refcount.c:214: Test failed: AddAttachedSurface returned 8876000a >  refcount.c:235: Test failed: AddAttachedSurface returned 8876000a >  refcount.c:237: Test failed: Got refcount 1, expected 2 >  refcount.c:262: Test failed: AddAttachedSurface

Re: [1/4] winex11.drv: Add on-screen PS_USERSTYLE support to pens (take 4)

2011-10-13 Thread Frédéric Delanoy
On Thu, Oct 13, 2011 at 06:08, Daniel wrote: > Fixes on-screen portion of http://bugs.winehq.org/show_bug.cgi?id=26091 You should configure your mail/git config so your real name appears in patches, and not just your first name "Daniel"

Re: mscoree: Register interfaces

2011-10-13 Thread Alexandre Julliard
Alistair Leslie-Hughes writes: > @@ -10,4 +10,6 @@ C_SRCS = \ > metahost.c \ > mscoree_main.c > > +IDL_R_SRCS = mscoree_v1.idl There's no reason to name the file v1, that's a leftover from stdole.tlb but it doesn't make sense here. -- Alexandre Julliard julli...@winehq.org

Re: [1/3] winex11.drv: Add on-screen PS_USERSTYLE support to pens (bugbot feeding #5)

2011-10-13 Thread Alexandre Julliard
Daniel writes: > @@ -42,29 +42,23 @@ HPEN X11DRV_SelectPen( PHYSDEV dev, HPEN hpen ) > X11DRV_PDEVICE *physDev = get_x11drv_dev( dev ); > LOGPEN logpen; > int i; > +EXTLOGPEN *elp = NULL; > +INT size = GetObjectW( hpen, 0, NULL ); > > -if (!GetObjectW( hpen, sizeof(lo

Re: [msi] initialize variable to placate static analyzers

2011-10-13 Thread Michael Stefaniuc
Hello Dan, Dan Kegel wrote: > Avoids the spurious compiler warning > > msi.c: In function 'MSI_ApplyPatchW': > msi.c:353:10: error: 'r' may be used uninitialized in this function > > Hans says "It's compiler confusion but I'm fine with a patch that initializes > r with ERROR_FUNCTION_FAILED." wh

For review please: wineps.drv: Implement PS_USERSTYLE on printers

2011-10-13 Thread Daniel
Hello guys. I would like to get a little review on this patch, a follow up to the patches that fix this problem on the screen. Specifically, I'm most concerned about making sure my dynamically allocated memory is freed under all conditions and there's no potential snafus that I'm not aware of. T

Re: [Wine] WineHQ database compromise

2011-10-13 Thread Maarten Lankhorst
Hey, On 10/12/2011 12:46 AM, Josh Juran wrote: > On Oct 11, 2011, at 3:37 PM, Conan Kudo (ニール・ゴンパ) wrote: > >> On Tue, Oct 11, 2011 at 3:39 PM, Josh Juran wrote: >> >>> Since bugzilla passwords were sent in cleartext anyway, I sincerely hope >>> none of them were otherwise valuable. (Remember F

Re: ddraw: Keep track of interface attached by AddAttachedSurface and detach correct interface when parent is released. (try 3)

2011-10-13 Thread Saulius Krasuckas
Hello, Octavian. * On Tue, 11 Oct 2011, Octavian Voicu wrote: > > try 3: > - fix test failure by moving error check from *_DeleteAttachedSurface to > ddraw_surface_delete_attached_surface, after another check (thanks Henri). > > try 2: > - use IUnknown_Release(attached_iface) instead of manual