Re: 79794: Help Test Please: use uniscribe in the single line edit control

2011-10-11 Thread Dan Kegel
Hi Aric, failed again on second run, http://buildbot.kegel.com:8010/builders/runtests-default/builds/209 Failing tests are comctl32_test.exe.so listview.c comctl32_test.exe.so updown.c user32_test.exe.so edit.c On Tue, Oct 11, 2011 at 1:26 PM, Dan Kegel wrote: > Hey Aric, > don't know if I trust

Re: [Wine] WineHQ database compromise

2011-10-11 Thread Josh Juran
On Oct 11, 2011, at 3:54 PM, Conan Kudo (ニール・ゴンパ) wrote: > 2011/10/11 Josh Juran > >> To clarify, your browser sends your password to bugzilla in cleartext, since >> HTTPS isn't an option. > > Shouldn't it be possible to modify the login environment so that a salted > hash of the password is

Re: [PATCH 1/7] msi/custom.c: unify thread handling of different custom action types (resend)

2011-10-11 Thread Bernhard Loos
On Tue, Oct 11, 2011 at 2:29 PM, Hans Leidekker wrote: > On Tue, 2011-10-11 at 13:20 +0200, Bernhard Loos wrote: > +static HRESULT get_action_info( msi_custom_action_info *info, INT *type, > +                                BSTR *source, BSTR *target, BSTR *name, > +                              

Re: [PATCH 5/7] msi/custom.c: get rid of MSIRUNNINGACTION

2011-10-11 Thread Bernhard Loos
On Tue, Oct 11, 2011 at 3:22 PM, Hans Leidekker wrote: > >> -static UINT HANDLE_CustomType50(MSIPACKAGE *package, LPCWSTR source, >> +static msi_custom_action_info *HANDLE_CustomType50(MSIPACKAGE *package, >> LPCWSTR source, >>                                  LPCWSTR target, const INT type, LPCW

Re: [Wine] WineHQ database compromise

2011-10-11 Thread ニール・ゴンパ
2011/10/11 Josh Juran > On Oct 11, 2011, at 3:37 PM, Conan Kudo (ニール・ゴンパ) wrote: > > > On Tue, Oct 11, 2011 at 3:39 PM, Josh Juran wrote: > > > >> Since bugzilla passwords were sent in cleartext anyway, I sincerely hope > none of them were otherwise valuable. (Remember FireSheep?) > > > > Wait,

Re: [Wine] WineHQ database compromise

2011-10-11 Thread Austin English
2011/10/11 Josh Juran : > On Oct 11, 2011, at 3:37 PM, Conan Kudo (ニール・ゴンパ) wrote: > >> On Tue, Oct 11, 2011 at 3:39 PM, Josh Juran wrote: >> >>> Since bugzilla passwords were sent in cleartext anyway, I sincerely hope >>> none of them were otherwise valuable.  (Remember FireSheep?) >> >> Wait, w

Re: [Wine] WineHQ database compromise

2011-10-11 Thread Josh Juran
On Oct 11, 2011, at 3:37 PM, Conan Kudo (ニール・ゴンパ) wrote: > On Tue, Oct 11, 2011 at 3:39 PM, Josh Juran wrote: > >> Since bugzilla passwords were sent in cleartext anyway, I sincerely hope >> none of them were otherwise valuable. (Remember FireSheep?) > > Wait, what? Bugzilla sends passwords i

Re: [Wine] WineHQ database compromise

2011-10-11 Thread ニール・ゴンパ
On Tue, Oct 11, 2011 at 3:39 PM, Josh Juran wrote: > On Oct 11, 2011, at 12:13 PM, Jeremy White wrote: > > > Unfortunately, the attackers were able to download the full login > > database for both the appdb and bugzilla. This means that they have all > > of those emails, as well as the passwords

Re: WineHQ database compromise

2011-10-11 Thread Jeremy White
> Almost 2 years ago I have sent you an email privately about a security > hole with the database. To be exactly, the date of the email is Wed, > Jul 29, 2009, 12:00 AM (GMT +02:00). I guess that's probably the same > trick the bad guys have used... Hmm. I can't find any such email in my archives

Re: [PATCH] dsound: Don't claim to support hardware buffers

2011-10-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14829 Your paranoid android

Re: WineHQ database compromise

2011-10-11 Thread Matijn Woudt
On Tue, Oct 11, 2011 at 9:13 PM, Jeremy White wrote: > Hi, > > I am sad to say that there was a compromise of the WineHQ database system. > > What we know at this point that someone was able to obtain unauthorized > access to the phpmyadmin utility.  We do not exactly how they obtained > access; i

Re: [PATCH] dsound: Don't claim to support hardware buffers

2011-10-11 Thread Chris Robinson
Hi. On Tuesday, October 11, 2011 3:31:59 PM Andrew Eikum wrote: > The specific drvcaps values and error code were tested against Windows > 7. How does this affect the primary buffer? Is it not allowed to be a hardware buffer either?

Re: [Wine] WineHQ database compromise

2011-10-11 Thread Josh Juran
On Oct 11, 2011, at 12:13 PM, Jeremy White wrote: > What we know at this point that someone was able to obtain unauthorized > access to the phpmyadmin utility. We do not exactly how they obtained > access; it was either by compromising an admins credentials, or by > exploiting an unpatched vulner

Re: WineHQ database compromise

2011-10-11 Thread Per Johansson
On Tue, Oct 11, 2011 at 9:13 PM, Jeremy White wrote: > Hi, > > I am sad to say that there was a compromise of the WineHQ database system. > Hi, one question. I'm not worried about my current account, but I had an old email with an old password recorded in my keychain store. I tried that email a

Re: WineHQ database compromise

2011-10-11 Thread Jerome Leclanche
On Tue, Oct 11, 2011 at 8:46 PM, Jerome Leclanche wrote: > Thank you so much for letting the users know so early on. > > Bugzilla/forum passwords should probably be reset as well for appdb > users, there's no doubt most people share passwords with the appdb. > > On Tue, Oct 11, 2011 at 8:13 PM, Je

Re: WineHQ database compromise

2011-10-11 Thread Nicolas Le Cam
2011/10/11 Jerome Leclanche : > Thank you so much for letting the users know so early on. > > Bugzilla/forum passwords should probably be reset as well for appdb > users, there's no doubt most people share passwords with the appdb. > > On Tue, Oct 11, 2011 at 8:13 PM, Jeremy White wrote: >> Hi, >>

Re: WineHQ database compromise

2011-10-11 Thread Maarten Lankhorst
Hey everyone, On 10/11/2011 09:13 PM, Jeremy White wrote: > Hi, > > I am sad to say that there was a compromise of the WineHQ database system. > > What we know at this point that someone was able to obtain unauthorized > access to the phpmyadmin utility. We do not exactly how they obtained > acce

Re: WineHQ database compromise

2011-10-11 Thread Jerome Leclanche
Thank you so much for letting the users know so early on. Bugzilla/forum passwords should probably be reset as well for appdb users, there's no doubt most people share passwords with the appdb. On Tue, Oct 11, 2011 at 8:13 PM, Jeremy White wrote: > Hi, > > I am sad to say that there was a compro

WineHQ database compromise

2011-10-11 Thread Jeremy White
Hi, I am sad to say that there was a compromise of the WineHQ database system. What we know at this point that someone was able to obtain unauthorized access to the phpmyadmin utility. We do not exactly how they obtained access; it was either by compromising an admins credentials, or by exploiti

Re: [PATCH 1/2] ntdll: windows refuses to load an image; if sections overlap the header size as given in the SizeOfHeaders field

2011-10-11 Thread Stefan Dösinger
On Tuesday 11 October 2011 18:15:29 Dan Kegel wrote: > On Tue, Oct 11, 2011 at 9:10 AM, Bernhard Loos > > wrote: > > It gets used in patch 2/2, that's why I overlooked it. Should I still > > resubmit it, as it would be only broken for a single revision? > > It would be nice; that way the tree is

Re: [3/3] ddraw: Keep track of interface attached by AddAttachedSurface and detach correct interface when parent is released. (try 2)

2011-10-11 Thread Alexandre Julliard
Octavian Voicu writes: > Fixes a bug that causes a stencil buffer leak in the game The Longest Journey. > Problem can be seen in the console output log attached to bug #11819. > This patch doesn't fix the original bug, but now game exits cleanly. > > The root of the problem is that when releasing

Re: [PATCH 1/2] ntdll: windows refuses to load an image; if sections overlap the header size as given in the SizeOfHeaders field

2011-10-11 Thread Bernhard Loos
On Tue, Oct 11, 2011 at 6:06 PM, Dan Kegel wrote: > Hi Bernhard, > Build fails here: > > loader.c: In function ‘test_section_mapping’: > loader.c:706:9: error: unused variable ‘i’ [-Werror=unused-variable] > cc1: all warnings being treated as errors > make[1]: *** [loader.o] Error 1 > make[1]: Lea

Re: [PATCH 4/4] kernel32, ntdll: implement most of GetNamedPipeHandleState

2011-10-11 Thread Bernhard Loos
On Tue, Oct 11, 2011 at 5:12 PM, Juan Lang wrote: > Hi Bernhard, > > nit: > -    todo_wine > -    ok(!ret && GetLastError() == ERROR_INVALID_PARAMETER, > +    todo_wine ok(!ret && GetLastError() == ERROR_INVALID_PARAMETER, > > This change is a no-op. > --Juan > I think I removed it first but had

Re: [PATCH 1/2] ntdll: windows refuses to load an image; if sections overlap the header size as given in the SizeOfHeaders field

2011-10-11 Thread Dan Kegel
Incidentally, the reason no automatic email was sent was that gcc still has those nonascii characters in its output, even though I set LANG=C. I'm now adding more logging to see what's up. On Tue, Oct 11, 2011 at 9:06 AM, Dan Kegel wrote: > Hi Bernhard, > Build fails here: > > loader.c: In functi

Re: [PATCH 1/2] ntdll: windows refuses to load an image; if sections overlap the header size as given in the SizeOfHeaders field

2011-10-11 Thread Dan Kegel
On Tue, Oct 11, 2011 at 9:10 AM, Bernhard Loos wrote: > It gets used in patch 2/2, that's why I overlooked it. Should I still > resubmit it, as it would be only broken for a single revision? It would be nice; that way the tree is a bit easier to bisect, etc, but mostly that way your patch series

re: [PATCH 1/2] ntdll: windows refuses to load an image; if sections overlap the header size as given in the SizeOfHeaders field

2011-10-11 Thread Dan Kegel
Hi Bernhard, Build fails here: loader.c: In function ‘test_section_mapping’: loader.c:706:9: error: unused variable ‘i’ [-Werror=unused-variable] cc1: all warnings being treated as errors make[1]: *** [loader.o] Error 1 make[1]: Leaving directory `/home/bob/wineslave.dir/sandbox/slave/runtests-def

Re: [PATCH 4/4] kernel32, ntdll: implement most of GetNamedPipeHandleState

2011-10-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14813 Your paranoid android

Re: [PATCH 4/4] kernel32, ntdll: implement most of GetNamedPipeHandleState

2011-10-11 Thread Juan Lang
Hi Bernhard, nit: -todo_wine -ok(!ret && GetLastError() == ERROR_INVALID_PARAMETER, +todo_wine ok(!ret && GetLastError() == ERROR_INVALID_PARAMETER, This change is a no-op. --Juan

Re: [PATCH 5/7] msi/custom.c: get rid of MSIRUNNINGACTION

2011-10-11 Thread Hans Leidekker
> -static UINT HANDLE_CustomType50(MSIPACKAGE *package, LPCWSTR source, > +static msi_custom_action_info *HANDLE_CustomType50(MSIPACKAGE *package, > LPCWSTR source, > LPCWSTR target, const INT type, LPCWSTR > action) > { > WCHAR *exe, *arg; > msi_custo

Re: [PATCH 3/3] vbscript: Added Hex function tests

2011-10-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14804 Your paranoid android

Re: [PATCH 1/7] msi/custom.c: unify thread handling of different custom action types (resend)

2011-10-11 Thread Hans Leidekker
On Tue, 2011-10-11 at 13:20 +0200, Bernhard Loos wrote: +static HRESULT get_action_info( msi_custom_action_info *info, INT *type, +BSTR *source, BSTR *target, BSTR *name, +IWineMsiRemotePackage **package ) { -IClassFactory *cf = N