Re: [PATCH] server: if a debugger is attached to a process, child processes shouldn't get debugged (resend)

On Fri, Oct 07, 2011 at 11:44:24AM +0900, Dmitry Timoshkov wrote: > Bernhard Loos wrote: > > > +int debug_childs:1; /* also debug all child > > processes */ > > 'debug_children' would be a better name. also unsigned intfoo:1; please. (int foo:1 works, but is s

Re: [PATCH] server: Use syscall(2) instead of inline assembly on Mac OS; too.

On Oct 7, 2011, at 1:50 PM, Dan Kegel wrote: > Probably a spurious failure Yeah... especially considering that: - That change only affects Mac OS X, and I haven't added my buildslave yet ;). (That file shouldn't even get built on non-Darwin.) - Wine won't even build 64-bit on Mac OS yet (and mi

Solved: Problems with drawing text in 1.3.29

I have narrowed the issue down to a difference in behaviour between Windows and Wine. The problem boils down to the following code: NONCLIENTMETRICS ncm; memset(&ncm, 0, sizeof(NONCLIENTMETRICS)); ncm.cbSize = sizeof(NONCLIENTMETRICS); VERIFY(SystemParametersInfo(SPI_GETNONCLIENTMETRICS

Re: [PATCH] server: Use syscall(2) instead of inline assembly on Mac OS; too.

Probably a spurious failure - I was running rpcrt4 tests on that machine, and they may both have wanted the same port number. Shame on me. On Fri, Oct 7, 2011 at 12:48 PM, Dan Kegel wrote: > Fails tests on x86_64? > > On Fri, Oct 7, 2011 at 11:52 AM,   wrote: >> This is an experimental automated

Re: Governance of Wine with respect to the Software Freedom Conservancy (update October 2011)

> As I said, our overlords are kind and benevolent and I'm sure that the > mention of "evil plans" was simply a joke as such wise and noble > developers could need harbor a malevolent thought. But, unless I've > been misreading this mailing list, all patches have to go through our > current enlight

Re: [PATCH] server: Use syscall(2) instead of inline assembly on Mac OS; too.

Fails tests on x86_64? On Fri, Oct 7, 2011 at 11:52 AM, wrote: > This is an experimental automated build and test service. > Please feel free to ignore this email while we work the kinks out. > > For more info about this message, see http://wiki.winehq.org/BuildBot > > The Buildbot has detected

Re: Governance of Wine with respect to the Software Freedom Conservancy (update October 2011)

On Fri, Oct 7, 2011 at 1:27 PM, Juan Lang wrote: > Hi Michael, > >> Not that I have any problems with our benevolent overlords, and not >> that I would likely achieve franchise with a scant 2 patches under my >> belt, but I can't help wondering how such a revolt would succeed >> seeing as the only

Re: Governance of Wine with respect to the Software Freedom Conservancy (update October 2011)

Hi Michael, > Not that I have any problems with our benevolent overlords, and not > that I would likely achieve franchise with a scant 2 patches under my > belt, but I can't help wondering how such a revolt would succeed > seeing as the only method to achieve franchise-hood is controlled by > the

Re: Governance of Wine with respect to the Software Freedom Conservancy (update October 2011)

Not that I have any problems with our benevolent overlords, and not that I would likely achieve franchise with a scant 2 patches under my belt, but I can't help wondering how such a revolt would succeed seeing as the only method to achieve franchise-hood is controlled by the same people one would b

Re: Wine Gecko 1.4-beta1

Nevermind, apparently the patch was too large and got corrupt. It's fine when downloaded off gmail. J On Fri, Oct 7, 2011 at 5:35 PM, Jacek Caban wrote: > On 10/7/11 3:57 AM, Jerome Leclanche wrote: >> >> I'm unable to apply the patch: >> patching file dlls/appwiz.cpl/addons.c >> patching file d

Re: Wine Gecko 1.4-beta1

On 10/7/11 3:57 AM, Jerome Leclanche wrote: I'm unable to apply the patch: patching file dlls/appwiz.cpl/addons.c patching file dlls/mshtml/editor.c patching file dlls/mshtml/htmldoc.c patching file dlls/mshtml/htmldoc3.c patching file dlls/mshtml/htmldoc5.c patching file dlls/mshtml/htmlimg.c pa

Re: mshtml: Implement IHTMLDOMNode replaceChild

Hi Alistair, On 10/7/11 4:50 AM, Alistair Leslie-Hughes wrote: +HTMLDOMNode *nodeNew; +HTMLDOMNode *nodeOld; Please use names consistent with the rest of the file. +if(NS_FAILED(nsres)) { +nsnode = nodeNew->nsnode; +} That seems questionable, why do you pretend to su

Re: [2/5] urlmon: Improved MapUrlToZone{Ex2} and GetSecurityId support

Hi Thomas, On 10/6/11 6:42 PM, Thomas Mullaly wrote: --- dlls/urlmon/sec_mgr.c | 41 +++-- dlls/urlmon/tests/sec_mgr.c | 30 +- 2 files changed, 68 insertions(+), 3 deletions(-) +if(hres == S_FALSE){ +

Re: todo_wine, broken() and a SW anti-pattern

Hi Joerg, > hr = IAudioClient_GetService(ac, &IID_IAudioStreamVolume, (void**)&out); > ok(hr == AUDCLNT_E_NOT_INITIALIZED, "... call returns %08x\n", hr); > todo_wine ok(broken(out != NULL), "GetService %08x &out pointer %p\n", hr, > out); > > 1. broken() documents that I consider native's observ

todo_wine, broken() and a SW anti-pattern

Hi, The question about how to use todo_wine and broken() comes up from time to time. Here's new light on it, as I'm suggesting in mmdevapi/tests/render.c: hr = IAudioClient_GetService(ac, &IID_IAudioStreamVolume, (void**)&out); ok(hr == AUDCLNT_E_NOT_INITIALIZED, "... call returns %08x\n", hr);

mmdevapi/tests: Add format tests.

Hi, Andrew Eikum wrote: > +todo_wine ok(broken(unk != NULL), ... I'll comment on that separately. >> +static void test_formats(AUDCLNT_SHAREMODE mode) >The code in this function is very difficult to follow. Indeed, it became more and more convoluted as I dug into native's "exclusive mode dis

The major mmdevapi and winmm audio bugs

Hi, Bugzilla admins, please set the 1.4 milestone on all bugs mentioned here. I'm not yet looking at dsound issues since I first want a correct foundation upon which to build to upper layers. o #28039 IAudioClock_GetPosition must ignore underruns (MacOS) Here I've no idea how to solve this. My

Re: mmdevapi/tests: Add format tests.

Hi J�rg, Thanks for adding these tests. It would have been nicer to split the patch up into discrete chunks. That would make the patch much easier to review. Overall it looks pretty good. Some remarks follow... > BTW, I've not touched > render.c:223: Test failed: IsFormatSupported(0x) cal

Re: DLLCanUnloadNow Question

On Friday 07 October 2011 11:50:17 am Alistair Leslie-Hughes wrote: > Hi, > > The Following sample code causes a crash under WINE, but not in windows. > > IUnknown *p > > LoadLibrary("mscoree.dll") > GetProcAddress("CreateDebuggingInterfaceFromVersion") > CreateDebuggingInterfaceFromVersion(..., (v

Re: Wine Gecko 1.4-beta1

I'm unable to apply the patch: patching file dlls/appwiz.cpl/addons.c patching file dlls/mshtml/editor.c patching file dlls/mshtml/htmldoc.c patching file dlls/mshtml/htmldoc3.c patching file dlls/mshtml/htmldoc5.c patching file dlls/mshtml/htmlimg.c patching file dlls/mshtml/htmlwindow.c patching

DLLCanUnloadNow Question

Hi, The Following sample code causes a crash under WINE, but not in windows. IUnknown *p LoadLibrary("mscoree.dll") GetProcAddress("CreateDebuggingInterfaceFromVersion") CreateDebuggingInterfaceFromVersion(..., (void**)&p) <-- Com Reference FreeLibrary("mscoree.dll") p->QueryInterface();

Re: Problems with drawing text in 1.3.29

Thanks for the suggestions. I've narrowed one of the issues down to WineEngGetGlyphOutline in dlls/gdi32/freetype.c. The pitch is 6640 and the height is 53003. This means that a buffer of ~335Mb has been allocated and then memset. This is where the slow down is occurring (because of the memset).